Re: [PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-04-03 Thread Vivek Gautam
Hi Kukjin, On Fri, Mar 15, 2013 at 1:32 PM, Vivek Gautam wrote: > This patch-set is in continuation with patch-series: > [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 > out of which follwowing patches have been picked up: > ARM: Exynos5250: Enabling ehci-s5p driver > ARM: Exyno

Re: [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-04-03 Thread Vivek Gautam
Hi Kukjin, On Fri, Mar 15, 2013 at 1:26 PM, Vivek Gautam wrote: > Based on 'for-next' of linux-samsung tree with following patches > from Doug on top: > usb: Document clocks in samsung, exynos4210-ehci/ohci bindings > ARM: dts: add usb 2.0 clock references to exynos5250 device tree > > Also depe

[patch 2/2] USB: keyspan: add a sanity test on "len"

2013-04-03 Thread Dan Carpenter
"len" comes from the USB transfer and it's probably correct. The thing is that we already have similar checks like: if (data[i] >= serial->num_ports) { So adding a sanity test here matches the rest of the code and is a good idea. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/s

[patch 1/2] USB: keyspan: pull in one indent level

2013-04-03 Thread Dan Carpenter
We can remove the "if (urb->actual_length) {" check because checking for "while (i < urb->actual_length) {" is sufficient. This lets us pull the code in one indent level. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c index 5b912fc..c773ac7

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-03 Thread Rajendra Nayak
Hi Tony, On Thursday 04 April 2013 05:12 AM, Tony Lindgren wrote: > Hi, > [].. >> @@ -1663,6 +1664,40 @@ static struct omap_clk omap44xx_clks[] = { >> CLK(NULL, "cpufreq_ck", &dpll_mpu_ck, CK_443X), >> }; >> >> +static struct clk *scrm_clks[] = { >> +&auxclk0_ck, >> +&a

RE: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread B, Ravi
Felipe > > Hi, > > On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: > > On 03.04.2013 14:04, Felipe Balbi wrote: > > > On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: > > > > >> Felipe, could you explain the background on how the dsps driver is > > >> supposed to work in

Re: [PATCH v3 00/11] usb: dwc3/xhci/phy: Enable runtime power management

2013-04-03 Thread Vivek Gautam
Hi Sarah, On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp wrote: > Question: Do you still need this patch for 3.10? Felipe's 'next' is closed for 3.10, so this series won't be making it to 3.10 now, as a whole. :-( > > http://marc.info/?l=linux-usb&m=136057666911621&w=2 > > Does this patchset bui

USB3.0 Interrupt transfer in u-boot

2013-04-03 Thread Puneet Sharma
Hello, I want to test USB keyboard for XHCI in u-boot and to do that i need the Interrupt transfer code in XHCI controller driver in u-boot. If possible, can you help me to give that piece of code or can you help me to figure out in kernel where can i find it so that i can try to replicate it in u

Re: Linux USB file storage gadget with new UDC

2013-04-03 Thread victor yeo
Hi, >>> > the parameter is file=/dev/mmcblk0p1 >> >> Perhaps you have already realized this... mmcblk0p1 is the first >> partition of the mmcblk0 device. Block 0 of the partition is the boot >> sector, not the MBR. The MBR is block 0 of the mmcblk0 device. So >> perhaps you really meant to use

Re: Linux USB file storage gadget with new UDC

2013-04-03 Thread victor yeo
Hi, >> > the parameter is file=/dev/mmcblk0p1 > > Perhaps you have already realized this... mmcblk0p1 is the first > partition of the mmcblk0 device. Block 0 of the partition is the boot > sector, not the MBR. The MBR is block 0 of the mmcblk0 device. So > perhaps you really meant to use: > >

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Stephen Warren
On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. To obtain a reference to the PHY without > using phandle, the p

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

2013-04-03 Thread Tony Lindgren
Hi, * Roger Quadros [130319 07:31]: > Register a device tree clock provider for AUX clocks > on the OMAP4 SoC. Also provide the binding information. > > Signed-off-by: Roger Quadros > --- > .../devicetree/bindings/clock/omap4-clock.txt | 32 ++ > arch/arm/boot/dts/omap4.

Re: [PATCH v5 0/6] Generic PHY Framework

2013-04-03 Thread Stephen Warren
On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: > Added a generic PHY framework that provides a set of APIs for the PHY drivers > to create/destroy a PHY and APIs for the PHY users to obtain a reference to > the PHY with or without using phandle. To obtain a reference to the PHY > without usi

[PATCH] xhci: prevent from potential null pointer dereference on failed init

2013-04-03 Thread Sergio Aguirre
It is possible that we fail on xhci_mem_init, just before doing the INIT_LIST_HEAD, and calling xhci_mem_cleanup. Problem is that, the list_for_each_entry_safe macro, dereferences next assuming is not NULL (which is the case for a uninitialized list). Let's protect from that. Signed-off-by: Serg

[PATCH v3 1/1] usb: chipidea: AR933x platform support for the chipidea driver

2013-04-03 Thread Svetoslav Neykov
Support host and device usb modes for the chipidea controller in AR933x. The controller doesn't support OTG functionality so the platform code forces one of the modes based on the state of GPIO13 pin at startup. Signed-off-by: Svetoslav Neykov --- arch/mips/ath79/dev-usb.c |

[PATCH v3 0/1] Chipidea driver support for the AR933x platform

2013-04-03 Thread Svetoslav Neykov
Add support for the usb controller in AR933x platform. The controller supports both host or device mode (defined at startup) but not OTG. The patches are tested on WR703n router running OpenWRT in device mode. Changes since v2: Removed the glue driver, now dev-usb.c directly registers ci_hdrc. C

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Sylwester Nawrocki
On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-bindings.txt @@ -0,0 +1,67 @@ +This document explains only the dt data binding. For general information about s/dt data/device tree ? +PHY subsystem refer Documentation/phy.txt

[PATCH v2] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-03 Thread Thierry Reding
The cleanup path checks whether the transceiver was properly initialized using IS_ERR(). However it can also happen that the cleanup path is run before the transceiver was initialized (or the operating mode isn't set to TEGRA_USB_OTG) and is therefore NULL. Add a separate label for error unwinding

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-04-03 Thread Stephen Warren
On 03/19/2013 01:51 PM, Stephen Warren wrote: > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >> As part of this series, apart from patch containing changes to register TEGRA >> USB PHY driver as platform driver, prepared below patches: >> 1. Re-arranging & adding new DT properties. >> 2. Getting

Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-04-03 Thread Stephen Warren
On 03/19/2013 01:53 PM, Stephen Warren wrote: > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >> This patch updates all Tegra board files so that they contain all the >> properties required by the updated USB DT binding. Note that this patch >> only adds the new properties and does not yet remove

Re: [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up.

2013-04-03 Thread Stephen Warren
On 04/03/2013 02:41 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. checkpatch fails: > WARNING: line over 80 characters > #27: FILE: drivers/usb/phy/phy-tegra-usb.c:547: > + dev

Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-04-03 Thread Stephen Warren
On 03/19/2013 02:10 PM, Stephen Warren wrote: > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >> Check return values from all GPIO APIs and handle errors accordingly. > >> Remove clk_disable_unprepare which is no more needed. > > The call to clk_disable_unprepare is incorrect in the current code

Re: Odp: Re: Odp: Re: kernel 3.9-rc5 - system does not show information about the new drive.

2013-04-03 Thread Greg KH
On Wed, Apr 03, 2013 at 09:02:50PM +0200, Tomasz Miś wrote: > Dnia Środa, 3 Kwietnia 2013 20:26 Greg KH napisał(a) > > > > A: No. > > Q: Should I include quotations after my reply? > > > > http://daringfireball.net/2007/07/on_top > > > > On Wed, Apr 03, 2013 at 08:16:47PM +0200, Tomasz Miś

Re: [PATCH v2 2/7] ARM: tegra: update device trees for USB binding rework

2013-04-03 Thread Stephen Warren
On 04/03/2013 02:41 AM, Venu Byravarasu wrote: > This patch updates all Tegra board files so that they contain all the > properties required by the updated USB DT binding. Note that this patch > only adds the new properties and does not yet remove the old properties, > in order to maintain bisectab

libusbx v1.0.15-rc2 is now available for testing

2013-04-03 Thread Pete Batard
Hi, The 2nd release candidate for libusbx v1.0.15 is now available at http://sourceforge.net/projects/libusbx/files/releases/1.0.15/source/ This version brings the following improvements: * Improve tranfer cancellation and avoid short read failures on broken descriptors * Filter out 8-bit ch

Re: [PATCH v2 2/7] ARM: tegra: update device trees for USB binding rework

2013-04-03 Thread Stephen Warren
On 04/03/2013 02:41 AM, Venu Byravarasu wrote: > This patch updates all Tegra board files so that they contain all the > properties required by the updated USB DT binding. Note that this patch > only adds the new properties and does not yet remove the old properties, > in order to maintain bisectab

Re: [PATCH v2 1/7] ARM: tegra: finalize USB EHCI and PHY bindings

2013-04-03 Thread Stephen Warren
On 04/03/2013 02:41 AM, Venu Byravarasu wrote: > The existing Tegra USB bindings have a few issues: ... > This patch fixes the binding definition to resolve these issues. > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt > b/Documentation/devicetree/bindings/usb/nvid

Odp: Re: Odp: Re: kernel 3.9-rc5 - system does not show information about the new drive.

2013-04-03 Thread Tomasz Miś
Dnia Środa, 3 Kwietnia 2013 20:26 Greg KH napisał(a) > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Wed, Apr 03, 2013 at 08:16:47PM +0200, Tomasz Miś wrote: > > Welcome. Yes You're right. However, I reported that at this point

Re: Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode) causing crashes

2013-04-03 Thread Christopher Waid
On 03/20/2013 05:45 PM, Christopher Waid wrote: On 03/20/2013 02:57 PM, Gustavo Padovan wrote: * Christopher Waid [2013-03-20 14:13:14 -0400]: On 03/18/2013 03:13 PM, Greg KH wrote: On Mon, Mar 18, 2013 at 02:57:43PM -0400, Christopher Waid wrote: Bus 001 Device 007: ID 0a12:0001 Cambridge

Re: [PATCH v9 0/2] usb: chipidea: udc: bugfixes

2013-04-03 Thread Michael Grzeschik
On Wed, Apr 03, 2013 at 05:10:48PM +0300, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > Hi Felipe, > > > > On Thu, Mar 28, 2013 at 11:52:38AM +0100, Michael Grzeschik wrote: > >> Hi, > >> > >> this series solves some memroy issues with the chipidea udc > >> > >> The series is base

Re: [PATCH] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-03 Thread Greg KH
On Tue, Apr 02, 2013 at 10:40:50PM +0200, Thierry Reding wrote: > The cleanup path checks whether the transceiver was properly initialized > using IS_ERR(). However it can also happen that the cleanup path is run > before the transceiver was initialized (or the operating mode isn't set > to TEGRA_U

Re: [PATCH v2] EHCI: Quirk flag for port power handling on overcurrent.

2013-04-03 Thread Greg KH
On Wed, Apr 03, 2013 at 02:09:23PM -0400, Alan Stern wrote: > On Wed, 3 Apr 2013, Christian Engelmayer wrote: > > > Commit 756aa6b3d536afe85e151138cb03a293998887b3 (ehci-hub: improved > > over-current recovery) added port power cycling on overcurrent indications > > as > > needed by the MPC8349 U

Re: Odp: Re: kernel 3.9-rc5 - system does not show information about the new drive.

2013-04-03 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Apr 03, 2013 at 08:16:47PM +0200, Tomasz Miś wrote: > Welcome. Yes You're right. However, I reported that at this point, > because of the effects it causes. You can not see absolutely no > nega

Re: [PATCH v4 2/3] usb: gadget: introduce gadget state tracking

2013-04-03 Thread Alan Stern
On Wed, 3 Apr 2013, Felipe Balbi wrote: > Hi, > > On Sun, Mar 17, 2013 at 05:59:00PM +0100, Sebastian Andrzej Siewior wrote: > > >diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c > > >index 40b1d88..8a1eeb2 100644 > > >--- a/drivers/usb/gadget/udc-core.c > > >+++ b/drive

Odp: Re: kernel 3.9-rc5 - system does not show information about the new drive.

2013-04-03 Thread Tomasz Miś
Welcome. Yes You're right. However, I reported that at this point, because of the effects it causes. You can not see absolutely no negative side effects of network solutions. However, there are "effects" about which I wrote on the USB drive. Established "symptoms" appear both in my kernels [pur

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Alan Stern
On Wed, 3 Apr 2013, Felipe Balbi wrote: > > Lets suppose DWC3 enables runtime_pm on USB 2 type phy, > > it will try to go into suspend state and thereby call runtime_suspend(), if > > any. > > And PHY will come to active state only when its consumer wakes it up, > > and this consumer is operation

Re: [PATCH] usb: gadget: nokia: include f_ecm.c

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 09:03:18PM +0300, Felipe Balbi wrote: > recent changes to gadget framework have > exposed a flaw in nokia.c where it uses > f_ecm.c but it wasn't including it like > other gadget drivers. > > This is a temporary patch until all other > function drivers are converted to new

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-03 Thread Alan Stern
On Wed, 3 Apr 2013, Felipe Balbi wrote: > On Wed, Apr 03, 2013 at 02:18:20PM +0200, Florian Fainelli wrote: > > Le 04/03/13 14:15, Felipe Balbi a �crit : > > >On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: > > >>Le 04/02/13 20:06, Alan Stern a �crit : > > >>>On Tue, 2 Apr 2013,

Re: [PATCH v2] EHCI: Quirk flag for port power handling on overcurrent.

2013-04-03 Thread Alan Stern
On Wed, 3 Apr 2013, Christian Engelmayer wrote: > Commit 756aa6b3d536afe85e151138cb03a293998887b3 (ehci-hub: improved > over-current recovery) added port power cycling on overcurrent indications as > needed by the MPC8349 USB controller after resolving of the overcurrent > situation in order to ha

[PATCH] usb: gadget: nokia: include f_ecm.c

2013-04-03 Thread Felipe Balbi
recent changes to gadget framework have exposed a flaw in nokia.c where it uses f_ecm.c but it wasn't including it like other gadget drivers. This is a temporary patch until all other function drivers are converted to new API where each function driver becomes a module and binding is done through

Re: Linux USB file storage gadget with new UDC

2013-04-03 Thread Alan Stern
On Wed, 3 Apr 2013, victor yeo wrote: > > the parameter is file=/dev/mmcblk0p1 Perhaps you have already realized this... mmcblk0p1 is the first partition of the mmcblk0 device. Block 0 of the partition is the boot sector, not the MBR. The MBR is block 0 of the mmcblk0 device. So perhaps yo

Re: [PATCH] xhci - clarify compliance mode debug messages

2013-04-03 Thread Tony Camuso
On 04/03/2013 01:23 PM, Sarah Sharp wrote: Hmm, actually, this patch doesn't apply any more. Sorry for not getting to it sooner. Can you resend this against Greg's latest usb-next branch? Sarah Sharp Yes, will do. On Wed, Apr 03, 2013 at 10:21:56AM -0700, Sarah Sharp wrote: Hi Tony, Jus

Re: [PATCH v3 00/11] usb: dwc3/xhci/phy: Enable runtime power management

2013-04-03 Thread Sarah Sharp
Question: Do you still need this patch for 3.10? http://marc.info/?l=linux-usb&m=136057666911621&w=2 Does this patchset build on top of that? I'm really behind on my patches for 3.10, sorry. Sarah Sharp On Mon, Apr 01, 2013 at 07:23:59PM +0530, Vivek Gautam wrote: > This patch-series enables r

Re: [PATCH] xhci - clarify compliance mode debug messages

2013-04-03 Thread Sarah Sharp
Hmm, actually, this patch doesn't apply any more. Sorry for not getting to it sooner. Can you resend this against Greg's latest usb-next branch? Sarah Sharp On Wed, Apr 03, 2013 at 10:21:56AM -0700, Sarah Sharp wrote: > Hi Tony, > > Just a note that I'm queuing this patch to Greg for 3.10. I'

Re: [PATCH] xhci - clarify compliance mode debug messages

2013-04-03 Thread Sarah Sharp
Hi Tony, Just a note that I'm queuing this patch to Greg for 3.10. I'm working on a bug fix patch for 3.9 that includes turning off runtime PM, and should fix the issue with the compliance timer causing list corruption on resume. Sarah Sharp On Tue, Feb 19, 2013 at 08:59:35AM -0500, Tony Camuso

Re: [PATCH v2] EHCI: Quirk flag for port power handling on overcurrent.

2013-04-03 Thread Sergei Shtylyov
Hello. On 04/03/2013 02:18 PM, Christian Engelmayer wrote: Commit 756aa6b3d536afe85e151138cb03a293998887b3 (ehci-hub: improved over-current recovery) added port power cycling on overcurrent indications as needed by the MPC8349 USB controller after resolving of the overcurrent situation in order

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-03 Thread David Miller
From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 12:05:30 +0530 > This patch series is about drivers/phy which will be used for now by > usb, sata and maybe some video PHY's. Network itself has a > comprehensive PHY in drivers/net/phy which we'd like to merge it with > drivers/phy so that we ha

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 02:55:47PM +, Arnd Bergmann wrote: > On Wednesday 03 April 2013, Felipe Balbi wrote: > > const ? Maybe provide a: > > > > #define DEFINE_PHY_OPS(name)\ > > const struct phy_ops #name_phy_ops = { > > > > macro ? This will force people to add the const keyword :

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote: > + ret = -EINVAL; > + goto err0; > + } > + > + if (!phy_class) > + phy_core_init(); > >>> > >>>why don't you setup the class on module_init ? Then this would be a > >>>terri

Re: [PATCH 0/3] check regulator_enable() return value

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 07:22:38AM -0700, Greg KH wrote: > On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > > > While testing your 'next' branch merged with today's next I got some new > > > warning

Re: [alsa-devel] Asynchronous audio USB chips: choppy playback since 3.8-rc7

2013-04-03 Thread Daniel Mack
On 03.04.2013 17:19, Michael Trimarchi wrote: > Hi Daniel > > On 03/04/13 17:00, Daniel Mack wrote: >> Hi Michael, >> >> On 03.04.2013 16:11, Michael Trimarchi wrote: >>> On 03/04/13 15:55, Michael Trimarchi wrote: On 03/04/13 12:23, Daniel Mack wrote: > Hi David, > > On 03.04.201

Re: [PATCH 2/3] usb: phy: twl4030-usb: check regulator_enable return value

2013-04-03 Thread Kalle Jokiniemi
On Wed, 2013-04-03 at 16:02 +0200, Fabio Baltieri wrote: > Since regulator_enable() is going to be marked as __must_check in the > next merge window, always check regulator_enable() return value and > print a warning if it fails. Could go bananas with this and all kinds of recovery schemes, but na

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Arnd Bergmann
On Wednesday 03 April 2013, Felipe Balbi wrote: > const ? Maybe provide a: > > #define DEFINE_PHY_OPS(name)\ > const struct phy_ops #name_phy_ops = { > > macro ? This will force people to add the const keyword :-) Forcing people to use const structures is good, but I think it would be better

Re: [PATCH v4 01/21] usb: phy: nop: Add some parameters to platform data

2013-04-03 Thread Roger Quadros
On 04/02/2013 08:21 PM, Tony Lindgren wrote: > * Felipe Balbi [130320 09:24]: >> On Wed, Mar 20, 2013 at 09:13:24AM -0700, Tony Lindgren wrote: >>> * Felipe Balbi [130320 09:00]: On Wed, Mar 20, 2013 at 05:44:40PM +0200, Roger Quadros wrote: > Add clk_rate parameter to platform data. If

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Vivek Gautam
On Wed, Apr 3, 2013 at 7:48 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 07:40:44PM +0530, Vivek Gautam wrote: >> >> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x) >> >> > >> >> +{ >> >> > >> >> + if (!x || !x->dev) { >> >> > >> >> + dev_err(x

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 07:57 PM, Felipe Balbi wrote: hi, On Wed, Apr 03, 2013 at 07:48:42PM +0530, Kishon Vijay Abraham I wrote: +struct phy *of_phy_xlate(struct phy *phy, struct of_phandle_args *args) +{ + return phy; +} +EXPORT_SYMBOL_GPL(of_phy_xlate); so you get a PHY and j

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Felipe Balbi
hi, On Wed, Apr 03, 2013 at 07:48:42PM +0530, Kishon Vijay Abraham I wrote: > >>+struct phy *of_phy_xlate(struct phy *phy, struct of_phandle_args *args) > >>+{ > >>+ return phy; > >>+} > >>+EXPORT_SYMBOL_GPL(of_phy_xlate); > > > >so you get a PHY and just return it ? What gives ?? (maybe I skipp

Re: [PATCH 0/3] check regulator_enable() return value

2013-04-03 Thread Greg KH
On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > > While testing your 'next' branch merged with today's next I got some new > > warnings, caused by a recently introduced __must_check in: > > > > c8801a8 regul

Re: [PATCH v9 0/2] usb: chipidea: udc: bugfixes

2013-04-03 Thread Greg KH
On Wed, Apr 03, 2013 at 05:10:48PM +0300, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > Hi Felipe, > > > > On Thu, Mar 28, 2013 at 11:52:38AM +0100, Michael Grzeschik wrote: > >> Hi, > >> > >> this series solves some memroy issues with the chipidea udc > >> > >> The series is base

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 07:12 PM, Felipe Balbi wrote: On Wed, Apr 03, 2013 at 06:23:49PM +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without u

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 07:40:44PM +0530, Vivek Gautam wrote: > >> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x) > >> > >> >> +{ > >> > >> >> + if (!x || !x->dev) { > >> > >> >> + dev_err(x->dev, "no PHY or attached device > >> > >> >> available\n");

Re: Cannot open two tyyACMs at a time when using 2514b USB hub

2013-04-03 Thread Matthijs Kooijman
Hi Arshad, > Did you manage to find a fix for the problem. Could you please share it. What driver does the USB controller in your TI board use? This problem sounds familiar to a problem I have observed in an Ralink RT3052 board, which uses the dwc_otg / dwc2 driver. Here, the problem was that the

Re: [PATCH 0/3] check regulator_enable() return value

2013-04-03 Thread Fabio Baltieri
Hi Felipe, On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > > While testing your 'next' branch merged with today's next I got some new > > warnings, caused by a recently introduced __must_check in: > > > > c

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Vivek Gautam
Hi, On Wed, Apr 3, 2013 at 7:26 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 04:54:14PM +0300, Felipe Balbi wrote: >> > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x) >> > >> >> +{ >> > >> >> + if (!x || !x->dev) { >> > >> >> + dev_err(x->dev,

Re: [PATCH v9 0/2] usb: chipidea: udc: bugfixes

2013-04-03 Thread Alexander Shishkin
Michael Grzeschik writes: > Hi Felipe, > > On Thu, Mar 28, 2013 at 11:52:38AM +0100, Michael Grzeschik wrote: >> Hi, >> >> this series solves some memroy issues with the chipidea udc >> >> The series is based on v3.9-rc4. >> >> Thanks, >> Michael >> >> Michael Grzeschik (2): >> usb: chipide

Re: kernel 3.9-rc5 - system does not show information about the new drive.

2013-04-03 Thread Greg KH
On Wed, Apr 03, 2013 at 10:46:46AM +0200, Tomasz Miś wrote: > Kernel 3.9-rc5 has trouble with USB [under 3.9-rc4 is ok]. System > [Kubuntu 12.10] does not mount properly the USB drives ... or more > precisely can be mounted, but for example, KDE does not show > information about the new drive ... a

Re: [PATCH 0/3] check regulator_enable() return value

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote: > While testing your 'next' branch merged with today's next I got some new > warnings, caused by a recently introduced __must_check in: > > c8801a8 regulator: core: Mark all get and enable calls as __must_check > > These patches

[PATCH 0/3] check regulator_enable() return value

2013-04-03 Thread Fabio Baltieri
Hello Felipe, While testing your 'next' branch merged with today's next I got some new warnings, caused by a recently introduced __must_check in: c8801a8 regulator: core: Mark all get and enable calls as __must_check These patches introduces a check for regulator_enable() return value in all thr

[PATCH 3/3] usb: phy: twl6030-usb: check regulator_enable return value

2013-04-03 Thread Fabio Baltieri
Since regulator_enable() is going to be marked as __must_check in the next merge window, always check regulator_enable() return value and print a warning if it fails. Cc: Hema HK Signed-off-by: Fabio Baltieri --- drivers/usb/phy/phy-twl6030-usb.c | 11 +-- 1 file changed, 9 insertions(+

[PATCH 2/3] usb: phy: twl4030-usb: check regulator_enable return value

2013-04-03 Thread Fabio Baltieri
Since regulator_enable() is going to be marked as __must_check in the next merge window, always check regulator_enable() return value and print a warning if it fails. Cc: Kalle Jokiniemi Signed-off-by: Fabio Baltieri --- drivers/usb/phy/phy-twl4030-usb.c | 18 +++--- 1 file changed,

[PATCH 1/3] usb: phy: ab8500-usb: check regulator_enable return value

2013-04-03 Thread Fabio Baltieri
Since regulator_enable() is going to be marked as __must_check in the next merge window, always check regulator_enable() return value and print a warning if it fails. Cc: Linus Walleij Signed-off-by: Fabio Baltieri --- drivers/usb/phy/phy-ab8500-usb.c | 12 +--- 1 file changed, 9 insert

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 04:54:14PM +0300, Felipe Balbi wrote: > > >> >> +static inline void usb_phy_autopm_enable(struct usb_phy *x) > > >> >> +{ > > >> >> + if (!x || !x->dev) { > > >> >> + dev_err(x->dev, "no PHY or attached device > > >> >> available\n"); > > >> >> +

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Felipe Balbi
HI, On Wed, Apr 03, 2013 at 06:42:48PM +0530, Vivek Gautam wrote: > >> >> Adding APIs to handle runtime power management on PHY > >> >> devices. PHY consumers may need to wake-up/suspend PHYs > >> >> when they work across autosuspend. > >> >> > >> >> Signed-off-by: Vivek Gautam > >> >> --- > >>

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 06:23:50PM +0530, Kishon Vijay Abraham I wrote: > Used the generic PHY framework API to create the PHY. omap_usb2_suspend > is split into omap_usb_suspend and omap_usb_resume in order to align > with the new framework. > > However using the old USB PHY library cannot be com

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 03:16:05PM +0200, Daniel Mack wrote: > On 03.04.2013 15:12, Koen Kooi wrote: > > > > Op 3 apr. 2013, om 15:09 heeft Felipe Balbi het > > volgende geschreven: > > > >> Hi, > >> > >> On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: > >>> On 03.04.2013 14:0

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 03:12:11PM +0200, Koen Kooi wrote: > > On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: > >> On 03.04.2013 14:04, Felipe Balbi wrote: > >>> On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: > >> > Felipe, could you explain the background on

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 06:23:49PM +0530, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. To obtain a reference to the PHY without > us

Re: Cannot open two tyyACMs at a time when using 2514b USB hub

2013-04-03 Thread Arshad
Hi Jan, all, Did you manage to find a fix for the problem. Could you please share it. Thanks in Advance Arshad -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Daniel Mack
On 03.04.2013 15:12, Koen Kooi wrote: > > Op 3 apr. 2013, om 15:09 heeft Felipe Balbi het > volgende geschreven: > >> Hi, >> >> On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: >>> On 03.04.2013 14:04, Felipe Balbi wrote: On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wr

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-03 Thread Vivek Gautam
Hi Felipe, On Wed, Apr 3, 2013 at 1:45 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 11:48:39AM +0530, Vivek Gautam wrote: >> >> Adding APIs to handle runtime power management on PHY >> >> devices. PHY consumers may need to wake-up/suspend PHYs >> >> when they work across autosuspen

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Koen Kooi
Op 3 apr. 2013, om 15:09 heeft Felipe Balbi het volgende geschreven: > Hi, > > On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: >> On 03.04.2013 14:04, Felipe Balbi wrote: >>> On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: >> Felipe, could you explain the backgr

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: > On 03.04.2013 14:04, Felipe Balbi wrote: > > On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: > > >> Felipe, could you explain the background on how the dsps driver is > >> supposed to work in host mode at boot time wi

[PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. omap_usb2_suspend is split into omap_usb_suspend and omap_usb_resume in order to align with the new framework. However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framewor

[PATCH v5 5/6] ARM: dts: omap: update usb_otg_hs data

2013-04-03 Thread Kishon Vijay Abraham I
Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. The PHY binding information can be found at Documentation/devicetree/bindings/phy/phy-bindings

[PATCH v5 3/6] usb: otg: twl4030: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Used the generic PHY framework API to create the PHY. twl4030_usb_suspend and twl4030_usb_resume is added to phy_ops in order to align with the new framework. However using the old USB PHY library cannot be completely removed because OTG is intertwined with PHY and moving to the new framework comp

[PATCH v5 6/6] usb: musb: omap2430: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Use the generic PHY framework API to get the PHY. The usb_phy_set_suspend and usb_phy_set_resume is replaced with phy_suspend and phy_resume to align with the new PHY framework. musb->xceiv can't be removed as of now because musb core uses xceiv.state and xceiv.otg. Once there is a separate state

[PATCH v5 4/6] ARM: OMAP: USB: Add phy binding information

2013-04-03 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information should be added in the platform specific initialization code using phy_bind. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |7 ++- 1 file changed, 6 insertions(+), 1 deletio

[PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without using phandle, the platform specfic intialization code (say from board file) shoul

[PATCH v5 0/6] Generic PHY Framework

2013-04-03 Thread Kishon Vijay Abraham I
Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without using phandle, the platform specfic intialization code (say from

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Daniel Mack
On 03.04.2013 14:04, Felipe Balbi wrote: > On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: >> Felipe, could you explain the background on how the dsps driver is >> supposed to work in host mode at boot time with the rework of the driver >> you did for 3.7? It might just be me not unde

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 02:18:20PM +0200, Florian Fainelli wrote: > Le 04/03/13 14:15, Felipe Balbi a écrit : > >On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: > >>Le 04/02/13 20:06, Alan Stern a écrit : > >>>On Tue, 2 Apr 2013, Florian Fainelli wrote: > >>> > This patch remo

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-03 Thread Florian Fainelli
Le 04/03/13 14:15, Felipe Balbi a écrit : On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: Le 04/02/13 20:06, Alan Stern a écrit : On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: > Le 04/02/13 20:06, Alan Stern a écrit : > >On Tue, 2 Apr 2013, Florian Fainelli wrote: > > > >>This patch removes the depends on USB from all config symbols in > >>drivers/usb/host/Kconfig and replace that with an if USB / endif bl

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-03 Thread Florian Fainelli
Le 04/02/13 20:06, Alan Stern a écrit : On Tue, 2 Apr 2013, Florian Fainelli wrote: This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffle

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Daniel Mack
Hi Felipe, On 03.04.2013 14:04, Felipe Balbi wrote: > (sorry, being really busy lately) > > On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: >>> >> I know this patch reintroduces bits that have been intentionally >>> >> removed before, in particular by 032ec49f53 ("usb: musb: drop >

RE: [PATCH 0/9] Towards configfs in mass storage

2013-04-03 Thread Andrzej Pietrasiewicz
Hi, On Wednesday, April 03, 2013 1:50 PM Felipe Balbi wrote: > > > > > > > > Sebastian's email address was also broken, I fixed it all up now. > > > > Will run a few tests. > > > > > > There is one patch which you didn't add your SoB, should I add it ? > > > > > > commit 0d24ccd4e2bc70662537742d

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Felipe Balbi
Hi, (sorry, being really busy lately) On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: > > >> I know this patch reintroduces bits that have been intentionally > > >> removed before, in particular by 032ec49f53 ("usb: musb: drop > > >> useless board_mode usage"), but I don't know ho

Re: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread Daniel Mack
On 19.03.2013 14:27, Peter Korsgaard wrote: >> "Daniel" == Daniel Mack writes: > > Hi, > > >> I know this patch reintroduces bits that have been intentionally > >> removed before, in particular by 032ec49f53 ("usb: musb: drop > >> useless board_mode usage"), but I don't know how this usb

RE: [PATCH] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-03 Thread Venu Byravarasu
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Thierry Reding > Sent: Wednesday, April 03, 2013 2:11 AM > To: Felipe Balbi > Cc: Stephen Warren; Alan Stern; linux-te...@vger.kernel.org; linux- > u...@vger.kernel.org > Su

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-03 Thread Florian Fainelli
Le 04/02/13 20:19, ba...@ti.com a écrit : Hi, On Tue, Apr 02, 2013 at 07:10:22PM +0200, Florian Fainelli wrote: diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 05e5143..ab5a3b9 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@ -6,7 +6,6 @@ # (M)HDR

  1   2   >