RE: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

2013-03-18 Thread Venu Byravarasu
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Sergei Shtylyov > Sent: Monday, March 18, 2013 6:32 PM > To: Venu Byravarasu > Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; > ba...@ti.com; linux-usb@vger.kern

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-18 Thread Peter Chen
On Mon, Mar 18, 2013 at 08:48:15AM -0700, Sarah Sharp wrote: > > > > - /* Port status change events always have a successful completion code */ > > - if (GET_COMP_CODE(le32_to_cpu(event->generic.field[2])) != > > COMP_SUCCESS) { > > - xhci_warn(xhci, "WARN: xHC returned failed port

Re: [PATCH 3/5] usb: chipidea: udc: add the define TD_COUNT and fix all users

2013-03-18 Thread Peter Chen
On Mon, Mar 18, 2013 at 03:28:26PM +0100, Michael Grzeschik wrote: > On Fri, Mar 08, 2013 at 05:54:37PM +0200, Alexander Shishkin wrote: > > Michael Grzeschik writes: > > > > > A static count of transfer descriptors was used everywhere in the driver > > > with the fixed number 4. This patch adds

[PATCH] usb: gadget: mv_u3d: make mv_u3d_pm_ops static

2013-03-18 Thread Jingoo Han
Make mv_u3d_pm_ops static because mv_u3d_pm_ops is not exported. Also, CONFIG_PM_SLEEP is used to remove unnecessary ifdefs. Signed-off-by: Jingoo Han --- drivers/usb/gadget/mv_u3d_core.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/mv_u3d_co

Re: [PATCH] usb: Make USB persist default configurable

2013-03-18 Thread Julius Werner
> What drivers/devices don't work with persist? We need to know that now, > otherwise all other distros and users have problems, right? We have seen a problem with the LTE modem in the Chromebook Pixel using the usb/serial/option.c driver, but we are not quite sure of the root cause yet. It occas

Re: [PATCH] usb: Make USB persist default configurable

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 05:02:19PM -0700, Julius Werner wrote: > > Why can't you just revert this in userspace? Isn't that easier than > > doing a kernel patch and providing an option that we need to now > > maintain for pretty much forever? > > I could solve it in userspace, but that really feel

Re: [PATCH] usb: Make USB persist default configurable

2013-03-18 Thread Julius Werner
> Why can't you just revert this in userspace? Isn't that easier than > doing a kernel patch and providing an option that we need to now > maintain for pretty much forever? I could solve it in userspace, but that really feels like a hacky workaround and not a long term solution. It would mean tha

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-18 Thread Greg Kroah-Hartman
On Thu, Mar 07, 2013 at 03:55:47PM +0100, Johan Hovold wrote: > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > close. all now applied, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ker

Re: [PATCH] usb: Make USB persist default configurable

2013-03-18 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2013 at 03:57:31PM -0700, Julius Werner wrote: > Commit 9214d1d8 set the USB persist flag as a default for all devices. > This might be desirable for some distributions, but it certainly has its > trade-offs... most importantly, it can significantly increase system > resume time, be

Re: [PATCH 5/11] USB: EHCI: changes related to qh_refresh()

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 12:05:54PM -0400, Alan Stern wrote: > This patch (as1638) makes several changes to the ehci-hcd driver, all > related to the qh_refresh() function. This function must be called > whenever an idle QH gets linked back into either the async or the > periodic schedule. > >

Re: [Pull Request v2] xHCI bug fix for 3.9

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 03:06:20PM -0700, Sarah Sharp wrote: > (Actually pushed the git tag this time: for-usb-linus-2013-03-18) > > The following changes since commit 2a40f324541ee61c22146214349c2ce9f5c30bcf: > > USB: EHCI: fix regression during bus resume (2013-03-15 12:07:53 -0700) > > are

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Yinghai Lu
On Mon, Mar 18, 2013 at 3:05 PM, Jiri Kosina wrote: > On Mon, 18 Mar 2013, Yinghai Lu wrote: > >> > Yes, switching from MSI to IO-APIC-fasteoi makes the report about lost >> > interrupts go away. >> > >> > My understanding from the other mail is that DAniel Vetter already has an >> > idea what mig

Re: [PATCH] xhci: Don't warn on empty ring for suspended devices.

2013-03-18 Thread Sarah Sharp
On Mon, Mar 18, 2013 at 02:26:39PM -0700, Stephen Hemminger wrote: > On Mon, 18 Mar 2013 10:25:10 -0700 > Sarah Sharp wrote: > > > When a device attached to the roothub is suspended, the endpoint rings > > are stopped. The host may generate a completion event with the > > completion code set to

[Pull Request v2] xHCI bug fix for 3.9

2013-03-18 Thread Sarah Sharp
(Actually pushed the git tag this time: for-usb-linus-2013-03-18) The following changes since commit 2a40f324541ee61c22146214349c2ce9f5c30bcf: USB: EHCI: fix regression during bus resume (2013-03-15 12:07:53 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/k

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Yinghai Lu wrote: > > Yes, switching from MSI to IO-APIC-fasteoi makes the report about lost > > interrupts go away. > > > > My understanding from the other mail is that DAniel Vetter already has an > > idea what might be going wrong with IRQ acking on GM45 chipsets; hopefully

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Daniel Vetter wrote: > Yep, there's a big comment in the irq handler for that chipset that we > have a gaping race with when using MSI interrupts. Although the comment > bodly claims that the race is small enough to avoid the dreaded "nobody > cared" message. Looks like gmbus

[Pull Request] xHCI bug fix for 3.9

2013-03-18 Thread Sarah Sharp
The following changes since commit 2a40f324541ee61c22146214349c2ce9f5c30bcf: USB: EHCI: fix regression during bus resume (2013-03-15 12:07:53 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git for-usb-linus for you to fetch changes up

[PATCH 1/1] USB: xhci - fix bit definitions for IMAN register

2013-03-18 Thread Sarah Sharp
From: Dmitry Torokhov According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bit 1 of IMAN register. Previously their definitions were reversed. Even though there are no ill effects being observed from the swapped definitions (because IMAN_IP is RW1C and in legacy PCI case we come i

Re: PROBLEM: USB device registered on OHCI instead of EHCI

2013-03-18 Thread Bruce Guenter
On Mon, Mar 11, 2013 at 02:48:50PM -0400, Alan Stern wrote: > Okay; if it happens again, collect the information and we'll go on from > there. Well, it's happened again, but it's obviously not a boot issue. Something happens after boot that is causing some errors. Complete dmesg attached. -- Br

Re: [PATCH] xhci: Don't warn on empty ring for suspended devices.

2013-03-18 Thread Stephen Hemminger
On Mon, 18 Mar 2013 10:25:10 -0700 Sarah Sharp wrote: > When a device attached to the roothub is suspended, the endpoint rings > are stopped. The host may generate a completion event with the > completion code set to 'Stopped' or 'Stopped Invalid' when the ring is > halted. The current xHCI cod

Re: [PATCH] xhci: Don't warn on empty ring for suspended devices.

2013-03-18 Thread Stephen Hemminger
On Mon, 18 Mar 2013 10:25:10 -0700 Sarah Sharp wrote: > When a device attached to the roothub is suspended, the endpoint rings > are stopped. The host may generate a completion event with the > completion code set to 'Stopped' or 'Stopped Invalid' when the ring is > halted. The current xHCI cod

Re: UHCI/EHCI interrupt storm after resume from S3

2013-03-18 Thread Waskiewicz Jr, Peter P
On 3/18/2013 1:35 PM, Greg KH wrote: On Mon, Mar 18, 2013 at 01:30:47PM -0700, Waskiewicz Jr, Peter P wrote: I have an Atom-based machine (N450) with an ICH8 running Ubuntu LTS 12.04.2. This has the latest updates installed, kernel 3.5.0-23.35. I put the machine into S3, then woke it from the n

Re: UHCI/EHCI interrupt storm after resume from S3

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 01:30:47PM -0700, Waskiewicz Jr, Peter P wrote: > I have an Atom-based machine (N450) with an ICH8 running Ubuntu LTS > 12.04.2. This has the latest updates installed, kernel 3.5.0-23.35. > I put the machine into S3, then woke it from the network. After > resume, the uhci_

UHCI/EHCI interrupt storm after resume from S3

2013-03-18 Thread Waskiewicz Jr, Peter P
I have an Atom-based machine (N450) with an ICH8 running Ubuntu LTS 12.04.2. This has the latest updates installed, kernel 3.5.0-23.35. I put the machine into S3, then woke it from the network. After resume, the uhci_hcd and ehci_hcd devices (sharing an interrupt) start flooding interrupts.

Reboot/shutdown failure due to "USB: EHCI: work around silicon bug in Intel's EHCI"

2013-03-18 Thread Stephen Warren
Alan, In v3.9-rc3, I find that "reboot" and "shutdown" hang on Tegra. I bisected it to commit 6402c79 "USB: EHCI: work around silicon bug in Intel's EHCI controllers", and confirmed that running v3.9-rc3 with just that one patch reverted does solve the problem. Do you have any idea what the probl

Re: 3.8.2: xhci port is dead until pcieport PME# goes to disabled

2013-03-18 Thread Sarah Sharp
On Mon, Mar 18, 2013 at 07:52:10PM +0100, Martin Mokrejs wrote: > Sarah Sharp wrote: > > On Mon, Mar 18, 2013 at 06:20:12PM +0100, Martin Mokrejs wrote: > >> Hi Sarah, > >> in this particular thread, the USB3 socket of the laptop works once > >> I plugin a device. When I unplug it and insert same

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Chris Wilson
On Mon, Mar 18, 2013 at 08:19:03PM +0100, Daniel Vetter wrote: > On Mon, Mar 18, 2013 at 10:12:49AM +0100, Jiri Kosina wrote: > > On Fri, 15 Mar 2013, Yinghai Lu wrote: > > > > > > Just a datapoint -- I have put a trivial debugging patch in place, and > > > > it > > > > reveals that "nobody cared

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Daniel Vetter
On Mon, Mar 18, 2013 at 04:56:02PM +0100, Jiri Kosina wrote: > Okay, so I think that for 3.9 we want the patch below, and if eventually > hardware root cause / workaround is found for GM45, we can have it merged > later. I'd prefer if we dig into this for a bit more. I've been traveling last wee

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Daniel Vetter
On Mon, Mar 18, 2013 at 10:12:49AM +0100, Jiri Kosina wrote: > On Fri, 15 Mar 2013, Yinghai Lu wrote: > > > > Just a datapoint -- I have put a trivial debugging patch in place, and it > > > reveals that "nobody cared" for irq 16 happens long after last > > > > > > I915_WRITE(GMBUS4 + reg_o

Re: Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode) causing crashes

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 02:57:43PM -0400, Christopher Waid wrote: > > Bus 001 Device 007: ID 0a12:0001 Cambridge Silicon Radio, Ltd > Bluetooth Dongle (HCI mode) > > Code for a CSR bluetooth chipset appears broken in recent kernel > releases. After a device is paired the kernel panics. This has b

Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode) causing crashes

2013-03-18 Thread Christopher Waid
Bus 001 Device 007: ID 0a12:0001 Cambridge Silicon Radio, Ltd Bluetooth Dongle (HCI mode) Code for a CSR bluetooth chipset appears broken in recent kernel releases. After a device is paired the kernel panics. This has been tested with a dozen USB dongles / systems and is consistently a probl

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Yinghai Lu
On Mon, Mar 18, 2013 at 2:12 AM, Jiri Kosina wrote: > On Fri, 15 Mar 2013, Yinghai Lu wrote: > >> > Just a datapoint -- I have put a trivial debugging patch in place, and it >> > reveals that "nobody cared" for irq 16 happens long after last >> > >> > I915_WRITE(GMBUS4 + reg_offset, 0); >>

Re: 3.8.2: xhci port is dead until pcieport PME# goes to disabled

2013-03-18 Thread Martin Mokrejs
Sarah Sharp wrote: > On Mon, Mar 18, 2013 at 06:20:12PM +0100, Martin Mokrejs wrote: >> Hi Sarah, >> in this particular thread, the USB3 socket of the laptop works once >> I plugin a device. When I unplug it and insert same or another device it >> appears >> to be dead until I use 'lsusb -vvv'.

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Alan Stern
On Mon, 18 Mar 2013, Felipe Balbi wrote: > Hi, > > On Mon, Mar 18, 2013 at 10:16:56AM -0400, Alan Stern wrote: > > > > it would cause copious modification and duplication of ehci hcd > > > > driver. For example, there is no "configured_flag" register in > > > > fusbh200 controller, yet, ehci hcd

Re: Fwd: a usb regression in kernel 2.6.37 and upper

2013-03-18 Thread Sarah Sharp
On Mon, Mar 18, 2013 at 10:31:28AM -0700, Sarah Sharp wrote: > On Mon, Mar 11, 2013 at 10:21:57PM -0400, Alan Stern wrote: > > On Mon, 11 Mar 2013, Sarah Sharp wrote: > > > > > On Mon, Mar 11, 2013 at 02:50:57PM +0800, Joshua wrote: > > > > ... > > > > > > Recently, I read the EHCI 1.1 addendum

Re: 3.8.2: xhci port is dead until pcieport PME# goes to disabled

2013-03-18 Thread Sarah Sharp
On Mon, Mar 18, 2013 at 06:20:12PM +0100, Martin Mokrejs wrote: > Hi Sarah, > in this particular thread, the USB3 socket of the laptop works once > I plugin a device. When I unplug it and insert same or another device it > appears > to be dead until I use 'lsusb -vvv'. After that, I see in dmesg

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Felipe Balbi
Hi, On Mon, Mar 18, 2013 at 10:16:56AM -0400, Alan Stern wrote: > > > it would cause copious modification and duplication of ehci hcd > > > driver. For example, there is no "configured_flag" register in > > > fusbh200 controller, yet, ehci hcd driver accesses "configured_flag" > > > in function eh

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Arnd Bergmann
On Monday 18 March 2013, Arnaud Patard wrote: > Arnd Bergmann writes: > > Sure, it's your decision. I just don't want to be accused of abandoning the > > issue that I caused. It's not strictly a regression because no configuration > > that was working in 3.8 is broken in 3.9, and embedded systems

Re: Fwd: a usb regression in kernel 2.6.37 and upper

2013-03-18 Thread Sarah Sharp
On Mon, Mar 11, 2013 at 10:21:57PM -0400, Alan Stern wrote: > On Mon, 11 Mar 2013, Sarah Sharp wrote: > > > On Mon, Mar 11, 2013 at 02:50:57PM +0800, Joshua wrote: > > ... > > > > Recently, I read the EHCI 1.1 addendum specification. I noticed there > > > are some implementations in kernel for t

[PATCH] xhci: Don't warn on empty ring for suspended devices.

2013-03-18 Thread Sarah Sharp
When a device attached to the roothub is suspended, the endpoint rings are stopped. The host may generate a completion event with the completion code set to 'Stopped' or 'Stopped Invalid' when the ring is halted. The current xHCI code prints a warning in that case, which can be really annoying if

Re: 3.8.2: xhci port is dead until pcieport PME# goes to disabled

2013-03-18 Thread Martin Mokrejs
Hi Sarah, in this particular thread, the USB3 socket of the laptop works once I plugin a device. When I unplug it and insert same or another device it appears to be dead until I use 'lsusb -vvv'. After that, I see in dmesg the two lines: [ 1445.597641] pcieport :00:1c.4: PME# disabled [ 1445

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Chris Wilson
On Mon, Mar 18, 2013 at 04:56:02PM +0100, Jiri Kosina wrote: > Okay, so I think that for 3.9 we want the patch below, and if eventually > hardware root cause / workaround is found for GM45, we can have it merged > later. > > > > From: Jiri Kosina > Subject: [PATCH] drm/i915: stop using GMBUS

Re: 3.8.2: xhci port is dead until pcieport PME# goes to disabled

2013-03-18 Thread Sarah Sharp
Hi Martin, I'm really having trouble following you here. Please don't try to tell me what you think the root cause of the issue is. Just tell me exactly (in a paragraph or less) what your symptoms are. Sending lots of log files and lsusb output at me isn't helpful if I don't know what your issu

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Rtp
Arnd Bergmann writes: Hi, > On Saturday 16 March 2013, Greg Kroah-Hartman wrote: >> On Fri, Mar 15, 2013 at 09:13:52PM +, Arnd Bergmann wrote: >> > On Friday 15 March 2013, Greg Kroah-Hartman wrote: >> > > > Unless something is changed, this patch won't get into 3.9-final. >> > > > Do you

Re: Isochronous transfer error on USB3

2013-03-18 Thread Sarah Sharp
On Wed, Mar 13, 2013 at 03:34:15PM +0100, jean-philippe francois wrote: > 2013/3/12 jean-philippe francois : > > 2013/3/12 jean-philippe francois : > >> 2013/3/12 Sarah Sharp : > >>> On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote: > USB3 host is an asmedia ASM1042. >

Re: Isochronous transfer error on USB3

2013-03-18 Thread Sarah Sharp
On Tue, Mar 12, 2013 at 10:57:22AM +0100, jean-philippe francois wrote: > 2013/3/12 jean-philippe francois : > > 2013/3/12 Sarah Sharp : > >> On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote: > >>> Hi, > >>> > >>> The company I work for is doing USB cameras, for which I wrote

Re: [PATCH v3 0/4] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-18 Thread Tony Lindgren
* Roger Quadros [130318 05:55]: > Hi Tony, > > I've revised the patches based on your comments. For now I've just > adapted Panda and Beagleboard. > If this looks OK then I can adapt the other boards as well. Thanks yes looks good to me now. Regards, Tony -- To unsubscribe from this list: send

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-18 Thread Sarah Sharp
On Mon, Mar 18, 2013 at 11:33:24AM -0400, Alan Stern wrote: > On Mon, 18 Mar 2013, Peter Chen wrote: > > > On Fri, Mar 15, 2013 at 10:47:50AM -0400, Alan Stern wrote: > > > On Fri, 15 Mar 2013, Peter Chen wrote: > > > > > > > On Thu, Mar 14, 2013 at 10:59:45AM -0400, Alan Stern wrote: > > > > > O

Re: [PATCH 8/9] usb: host: ehci-tegra: fix PHY error handling

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 10:02:45AM +0200, Felipe Balbi wrote: > Hi, > > On Fri, Mar 15, 2013 at 03:12:08PM -0600, Stephen Warren wrote: > > On 03/15/2013 03:12 AM, Felipe Balbi wrote: > > > PHY layer no longer returns NULL, we must > > > switch from IS_ERR_OR_NULL() to IS_ERR(). > > > > This chan

[PATCH 11/11] USB: EHCI: remove unused variable in unlink_empty_async()

2013-03-18 Thread Alan Stern
This patch (as1669) removes the check_unlinks_later flag in ehci-hcd's unlink_empty_async(). It wasn't being used for anything and should have been removed in an earlier patch, but I forgot about it. Signed-off-by: Alan Stern --- drivers/usb/host/ehci-q.c |5 + 1 file changed, 1 inser

[PATCH 9/11] USB: EHCI: convert singly-linked lists to list_heads

2013-03-18 Thread Alan Stern
This patch (as1664) converts ehci-hcd's async_unlink, async_iaa, and intr_unlink from singly-linked lists to standard doubly-linked list_heads. Originally it didn't seem necessary to use list_heads, because items are always added to and removed from these lists in FIFO order. But now with more li

[PATCH 10/11] USB: EHCI: improve end_unlink_async()

2013-03-18 Thread Alan Stern
This patch (as1665) changes the way ehci-hcd's end_unlink_async() routine works in order to avoid recursive execution and to be more efficient: Now when an IAA cycle ends, a new one gets started up right away (if it is needed) instead of waiting until the just-unlinked QH h

[PATCH 8/11] USB: EHCI: consolidate code in ehci_urb_dequeue()

2013-03-18 Thread Alan Stern
This patch (as1663) consolidates two nearly identical code paths in ehci_urb_dequeue(). The test for !qh can be removed because it will never succeed; the fact that usb_hcd_check_unlink_urb() returned 0 means that urb must be queued and therefore urb->hcpriv must point to a QH. Signed-off-by: Ala

[PATCH 7/11] USB: EHCI: split needs_rescan into two flags

2013-03-18 Thread Alan Stern
This patch (as1662) does some more QH-related cleanup in ehci-hcd. The qh->needs_rescan flag is currently used for two different purposes; the patch replaces it with two separate flags for greater clarity: qh->dequeue_during_giveback indicates that a completion handler dequeued an URB (implying tha

[PATCH 6/11] USB: EHCI: change return value of qh_completions()

2013-03-18 Thread Alan Stern
This patch (as1658) cleans up the usage of qh_completions() in ehci-hcd. Currently the function's return value indicates whether any URBs were given back; the idea was that the caller can scan the QH over again to handle any URBs that were dequeued by a completion handler. This is not necessary;

[PATCH 5/11] USB: EHCI: changes related to qh_refresh()

2013-03-18 Thread Alan Stern
This patch (as1638) makes several changes to the ehci-hcd driver, all related to the qh_refresh() function. This function must be called whenever an idle QH gets linked back into either the async or the periodic schedule. Change a BUG_ON() in the qh_update routine to a WARN_ON().

[PATCH 4/11] USB: EHCI: don't turn on PORT_SUSPEND during port resume

2013-03-18 Thread Alan Stern
This patch (as1637) cleans up the way ehci-hcd handles end-of-resume port signalling. When the PORT_RESUME bit in the port's status and control register is cleared, we shouldn't be setting the PORT_SUSPEND bit at the same time. Not doing this doesn't seem to have hurt so far, but we might as well

[PATCH 3/11] USB: EHCI: reorganize ehci_iaa_watchdog()

2013-03-18 Thread Alan Stern
This patch (as1635) rearranges the control-flow logic in ehci_iaa_watchdog() slightly to agree better with the comments. It also changes a verbose-debug message to a regular debug message. Expiration of the IAA watchdog is an unusual event and can lead to problems; we need to know about it if it h

[PATCH 2/11] USB: EHCI: improve use of per-port status-change bits

2013-03-18 Thread Alan Stern
This patch (as1634) simplifies some of the code associated with the per-port change bits added in EHCI-1.1, and in particular it fixes a bug in the logic of ehci_hub_status_data(). Even if the change bit doesn't indicate anything happened on a particular port, we still have to notify the core abou

[PATCH 1/11] USB: EHCI: decrease schedule-status poll timeout

2013-03-18 Thread Alan Stern
This patch (as1657) decreases the timeout used by ehci-hcd for polling the async and periodic schedule statuses. The timeout is currently set to 20 ms, which is much too high. Controllers should always update the schedule status within one or two ms of being told to do so; if they don't then some

[PATCH 0/11] EHCI: minor fixes and improvements

2013-03-18 Thread Alan Stern
The following series of patches includes a bunch of fixes for obscure bugs and relatively minor improvements to the code in ehci-hcd. No big reorganizations, major bug fixes, or anything like that. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Alan Stern
On Fri, 15 Mar 2013, Arnd Bergmann wrote: > > Instead of adding these tests for non-NULL pdata all over the place, > > you could define a static structure with default settings and store a > > pointer to it if pdata wasn't set initially. > > Yes, good idea. Here is a new version. Maybe Alexey o

Re: [PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Josh Boyer wrote: > > > This keyboard backlight device causes a 10 second delay to boot. Add it > > > to the quirk list with HID_QUIRK_NO_INIT_REPORTS. > > > > Applied, thanks. > > Ugh. Typo in this patch that prevents it from building. I shall hang > my head in shame and

[PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Jiri Kosina
Okay, so I think that for 3.9 we want the patch below, and if eventually hardware root cause / workaround is found for GM45, we can have it merged later. From: Jiri Kosina Subject: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips Commit 28c70f162 ("drm/i915: use the gmbus irq for waits"

[PATCH v2] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Arnd Bergmann
A number of ARM platforms were changed in linux-3.9 so they can be enabled at a single kernel configuration. Unfortunately, the necessary changes for the EHCI driver were not ready in time and the first attempt to split out the EHCI bus glues into separate modules had to get reverted before the mer

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-18 Thread Sarah Sharp
On Mon, Mar 18, 2013 at 09:34:51AM +0800, Peter Chen wrote: > I agree with you. How about below version: > > drivers/usb/host/xhci-ring.c | 39 --- > 1 files changed, 20 insertions(+), 19 deletions(-) > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/u

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Arnd Bergmann
On Saturday 16 March 2013, Greg Kroah-Hartman wrote: > On Fri, Mar 15, 2013 at 09:13:52PM +, Arnd Bergmann wrote: > > On Friday 15 March 2013, Greg Kroah-Hartman wrote: > > > > Unless something is changed, this patch won't get into 3.9-final. > > > > Do you want Greg to move it to his usb-lin

[PATCH v2] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Josh Boyer
This keyboard backlight device causes a 10 second delay to boot. Add it to the quirk list with HID_QUIRK_NO_INIT_REPORTS. This fixes Red Hat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=907221 Signed-off-by: Josh Boyer --- v2: Fix typo in vendor define drivers/hid/hid-ids.h

Re: [PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Josh Boyer
On Mon, Mar 18, 2013 at 02:54:58PM +0100, Jiri Kosina wrote: > On Mon, 18 Mar 2013, Josh Boyer wrote: > > > This keyboard backlight device causes a 10 second delay to boot. Add it > > to the quirk list with HID_QUIRK_NO_INIT_REPORTS. > > Applied, thanks. Ugh. Typo in this patch that prevents i

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-18 Thread Alan Stern
On Mon, 18 Mar 2013, Peter Chen wrote: > On Fri, Mar 15, 2013 at 10:47:50AM -0400, Alan Stern wrote: > > On Fri, 15 Mar 2013, Peter Chen wrote: > > > > > On Thu, Mar 14, 2013 at 10:59:45AM -0400, Alan Stern wrote: > > > > On Thu, 14 Mar 2013, Peter Chen wrote: > > > > > > > > > /home/b29397/work

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-18 Thread Alan Stern
On Sat, 16 Mar 2013, Alan Stern wrote: > On Sat, 16 Mar 2013, Jenya Y wrote: > > > Alan, looks like we are not quite there yet, just tried a fresh 3.8.3 > > build with both of your patches and here is what I have - > > > > [7.797975] usb 1-2.2: can't set config #1, error -19 > > [7.79833

RE: [PATCH v4 00/46] Towards configfs - usb functions conversion to the new interface

2013-03-18 Thread Andrzej Pietrasiewicz
On Monday, March 18, 2013 12:52 PM Felipe Balbi wrote: > Hi, > > On Mon, Mar 18, 2013 at 10:23:32AM +0100, Andrzej Pietrasiewicz wrote: > > > The prerequisite for providing the configfs interface for USB > > > gadgets and all their users is converting them to the new function > > > interface from

Re: [PATCH 8/9] usb: host: ehci-tegra: fix PHY error handling

2013-03-18 Thread Stephen Warren
On 03/18/2013 02:02 AM, Felipe Balbi wrote: > Hi, > > On Fri, Mar 15, 2013 at 03:12:08PM -0600, Stephen Warren wrote: >> On 03/15/2013 03:12 AM, Felipe Balbi wrote: >>> PHY layer no longer returns NULL, we must switch from >>> IS_ERR_OR_NULL() to IS_ERR(). >> >> This change will definitely confli

Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-18 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2013 at 09:28:07AM +0100, oskar.and...@sonymobile.com wrote: > On 21:16 Fri 08 Mar , Greg Kroah-Hartman wrote: > > On Fri, Mar 08, 2013 at 11:56:26PM +0400, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 08-03-2013 16:53, oskar.and...@sonymobile.com wrote: > > > > > > >Fro

Re: Testing for hardware bug in EHCI controllers

2013-03-18 Thread Alan Stern
On Mon, 18 Mar 2013, Noone Nowhere wrote: > > I can't fix the block count issue. That's not a bug in the program; > > it's a bug somewhere else. > > Who can fix it? Should we test another stick? That depends on where the bug is. If it is in the stick then testing a different brand of flash dr

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-18 Thread Du Xing
From: Du Xing duxing2...@gmail.com In skel_read,the reader blocked in wait_for_completion before submit bulk in urb. Using processed_urb is for retaining the completion in the case that previous interruptible wait in skel_read was interrupted and complete before next skel_read. Replacing complet

Re: [PATCH 3/5] usb: chipidea: udc: add the define TD_COUNT and fix all users

2013-03-18 Thread Michael Grzeschik
On Fri, Mar 08, 2013 at 05:54:37PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > A static count of transfer descriptors was used everywhere in the driver > > with the fixed number 4. This patch adds a define, named TD_COUNT, and > > replaces all users of this value. This way

Re: [PATCH] HID: usbhid: quirk for Realtek Multi-card reader

2013-03-18 Thread Josh Boyer
On Mon, Mar 18, 2013 at 02:52:32PM +0100, Jiri Kosina wrote: > On Mon, 18 Mar 2013, Josh Boyer wrote: > > > This device has an odd HID entry > > I can't really say I understand this portion of the changelog. I just took it from what Hans said in the bug. I believe I might have misunderstood.

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Alan Stern
On Mon, 18 Mar 2013, Felipe Balbi wrote: > On Mon, Mar 18, 2013 at 06:06:18PM +0800, Yuan-Hsin Chen wrote: > > Hi, > > > > I tried to modify fusbh200 hcd driver following ehci-platform.c. > > However, the register definition of fusbh200 is partially incompatible > > to ehci. For fusbh200, only th

Re: [PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Josh Boyer wrote: > This keyboard backlight device causes a 10 second delay to boot. Add it > to the quirk list with HID_QUIRK_NO_INIT_REPORTS. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH] HID: usbhid: quirk for Realtek Multi-card reader

2013-03-18 Thread Jiri Kosina
On Mon, 18 Mar 2013, Josh Boyer wrote: > This device has an odd HID entry I can't really say I understand this portion of the changelog. I will rephrase it a little bit and apply, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the b

Re: [PATCH v2] usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed

2013-03-18 Thread Michal Nazarewicz
On Mon, Mar 18 2013, UCHINO Satoshi wrote: > Without this memory barrier, the file-storage thread may fail to > escape from the following while loop, because it may observe new > common->thread_wakeup_needed and old bh->state which are updated by > the callback functions. > > /* Wait for the

Re: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-18 Thread Vivek Gautam
Hi, On Fri, Mar 15, 2013 at 8:58 AM, Jingoo Han wrote: > On Friday, March 15, 2013 12:16 PM, Doug Anderson wrote: >> >> The ehci_vbus_gpio is requested but never freed. This can cause >> problems with deferred probes and would cause problems if >> s5p_ehci_remove was ever called. Use devm to f

[PATCH] HID: usbhid: quirk for MSI GX680R led panel

2013-03-18 Thread Josh Boyer
This keyboard backlight device causes a 10 second delay to boot. Add it to the quirk list with HID_QUIRK_NO_INIT_REPORTS. This fixes Red Hat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=907221 Signed-off-by: Josh Boyer --- drivers/hid/hid-ids.h | 3 +++ drivers/hid/usbhid/hid

[PATCH] HID: usbhid: quirk for Realtek Multi-card reader

2013-03-18 Thread Josh Boyer
This device has an odd HID entry and causes a 10 second delay in boot. Add this device to the quirks list with HID_QUIRK_NO_INIT_REPORTS. This fixes Red Hat bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=806587 Signed-off-by: Josh Boyer --- drivers/hid/hid-ids.h | 3 +++ drivers

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-18 Thread Michael Grzeschik
On Thu, Mar 07, 2013 at 11:54:03PM +0100, Michael Grzeschik wrote: > Hey Alex, > > On Thu, Jan 24, 2013 at 11:42:53AM +0200, Alexander Shishkin wrote: > > Peter Chen writes: > > > > > On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote: > > >> Nearly every SoC from Freescale has th

Re: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

2013-03-18 Thread Sergei Shtylyov
Hello. On 18-03-2013 16:29, Venu Byravarasu wrote: As GPIO information is avail through DT, used it to get Tegra ULPI reset GPIO number. Added a new member to tegra_usb_phy structure to store this number. Signed-off-by: Venu Byravarasu --- drivers/usb/phy/tegra_usb_phy.c | 25

[PATCH v3 1/4] usb: phy: nop: Add some parameters to platform data

2013-03-18 Thread Roger Quadros
Add clk_rate parameter to platform data. If supplied, the NOP phy driver will program the clock to that rate during probe. Also add 2 flags, needs_vcc and needs_reset. If the flag is set and the regulator couldn't be found then the driver will bail out with -EPROBE_DEFER. Signed-off-by: Roger Qua

[PATCH v3 3/4] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes

2013-03-18 Thread Roger Quadros
Use usbhs_init_phys() to register the PHY's VCC and RESET regulators and the NOP PHY device. Get rid of managing the PHY clock as it will be done by the PHY driver. For that to work we create a clock alias that links the PHY clock name to the PHY device name. Signed-off-by: Roger Quadros --- ar

[PATCH v3 0/4] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-18 Thread Roger Quadros
Hi Tony, I've revised the patches based on your comments. For now I've just adapted Panda and Beagleboard. If this looks OK then I can adapt the other boards as well. cheers, -roger Roger Quadros (4): usb: phy: nop: Add some parameters to platform data ARM: OMAP2+: omap-usb-host: Add usbhs_i

[PATCH v3 2/4] ARM: OMAP2+: omap-usb-host: Add usbhs_init_phys()

2013-03-18 Thread Roger Quadros
This helper allows board support code to add the PHY's VCC and RESET regulators which are GPIO controlled as well as the NOP PHY device. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/usb-host.c | 177 +++- arch/arm/mach-omap2/usb.h |9 ++ 2 fi

[PATCH v3 4/4] ARM: OMAP3: Beagle: Adapt to ehci-omap changes

2013-03-18 Thread Roger Quadros
Use usbhs_init_phys() to register the PHY's VCC and RESET regulators and the NOP PHY device. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3beagle.c | 32 +- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/board-

Re: [PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-03-18 Thread Roger Quadros
On 03/15/2013 06:12 PM, Tony Lindgren wrote: > Hi, > > I think you can get rid of quite a bit more of the repeated data for > most boards, see below. > > * Roger Quadros [130315 08:21]: >> Add 2 platform devices for 'nop-usb-xceiv'. These will be used >> as PHYs for HS USB ports 1 and 2 so provi

[PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-18 Thread Venu Byravarasu
As part of this series, apart from patch containing changes to register TEGRA USB PHY driver as platform driver, prepared below patches: 1. Re-arranging & adding new DT properties. 2. Getting various params from DT properties added. 3. code clean up. Venu Byravarasu (7): ARM: tegra: finalize USB

[PATCH 4/7] usb: phy: tegra: Return correct error value provided by clk_get_sys

2013-03-18 Thread Venu Byravarasu
In case if clk_get_sys fails, return correct error value provided by the API. Signed-off-by: Venu Byravarasu --- drivers/usb/phy/tegra_usb_phy.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c index 93ab

[PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-03-18 Thread Venu Byravarasu
Check return values from all GPIO APIs and handle errors accordingly. Remove clk_disable_unprepare which is no more needed. Signed-off-by: Venu Byravarasu --- drivers/usb/phy/tegra_usb_phy.c | 50 ++ 1 files changed, 39 insertions(+), 11 deletions(-) diff -

[PATCH 3/7] usb: phy: tegra: Get PHY mode using DT

2013-03-18 Thread Venu Byravarasu
Added a new PHY mode to support OTG. Obtained Tegra USB PHY mode using DT property. Signed-off-by: Venu Byravarasu --- drivers/usb/host/ehci-tegra.c |3 +-- drivers/usb/phy/tegra_usb_phy.c | 13 +++-- include/linux/usb/tegra_usb_phy.h |3 ++- 3 files changed, 14 insertion

[PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-03-18 Thread Venu Byravarasu
This patch updates all Tegra board files so that they contain all the properties required by the updated USB DT binding. Note that this patch only adds the new properties and does not yet remove the old properties, in order to maintain bisectability. The old properties will be removed once the driv

[PATCH 7/7] usb: phy: registering tegra USB PHY as platform driver

2013-03-18 Thread Venu Byravarasu
Registered tegra USB PHY as a separate platform driver. To synchronize host controller and PHY initialization, used deferred probe mechanism. As PHY should be initialized before EHCI starts running, deferred probe of Tegra EHCI driver till PHY probe gets completed. Got rid of instance number base

[PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

2013-03-18 Thread Venu Byravarasu
As GPIO information is avail through DT, used it to get Tegra ULPI reset GPIO number. Added a new member to tegra_usb_phy structure to store this number. Signed-off-by: Venu Byravarasu --- drivers/usb/phy/tegra_usb_phy.c | 25 +++-- include/linux/usb/tegra_usb_phy.h |

  1   2   >