On Thu, Mar 14, 2013 at 12:31:38PM +0200, Alexander Shishkin wrote:
> Peter Chen writes:
>
> > Hi Alex and all,
> >
> > Currently, we have two problems to block chipidea driver coming
> > development.
> >
> > As there are so many chipidea versions, we impossible to collect
> > all to make a decis
On Thu, Mar 14, 2013 at 12:12:47PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 05:38:03PM +0800, Peter Chen wrote:
> > > > > @@ -160,6 +163,24 @@ usb_phy_shutdown(struct usb_phy *x)
> > > > > x->shutdown(x);
> > > > > }
> > > > >
> > > > > +static inline int
> > >
On Thu, Mar 14, 2013 at 12:19:04PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 05:24:39PM +0800, Peter Chen wrote:
> > > > @@ -278,7 +278,10 @@ static int udc_bind_to_driver(struct usb_udc *udc,
> > > > struct usb_gadget_driver *dri
> > > > driver->unbind(gadget);
Hi,
On Thu, Mar 14, 2013 at 4:23 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 04:14:58PM +0530, Vivek Gautam wrote:
>> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
>> calls as required by common clock framework.
>>
>> Signed-off-by: Vivek Gautam
>> CC:
Hi,
For bulk transfer, the new UDC driver has one problem. When SCSI
Inquiry command is received, the UDC driver interrupt routine will
receive it first. However, the queue function is not yet called, and
queue buffer is not yet added. Thus, interrupt routine is not able to
store the SCSI Inquiry
Hi Felipe,
On Thursday 14 March 2013 09:34 PM, Felipe Balbi wrote:
in cases where PHY layer isn't enabled, we want
to still return an error code (actually an error
pointer) so that our users don't need to cope with
either error pointer of NULL.
This will simplify users as below:
- return
On Thu, 2013-03-14 at 12:05 +0100, Bjørn Mork wrote:
> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
> introduced a new policy, preferring MBIM for dual NCM/MBIM functions if
> the cdc_mbim driver was enabled. This caused a regression for users
> wanting to use NCM.
>
If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch doesn't recover device under this situation.
Also add comments on this case.
Acked-by: David S. Miller
Cc: Steve Glendinning
Signed-off-by: Ming Lei
---
dri
If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch doesn't recover device under this situation.
Also add comments on the case.
Acked-by: David S. Miller
Cc: Steve Glendinning
Signed-off-by: Ming Lei
---
driv
If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch comments on the case and requires that both
usbnet_suspend() and subdriver->suspend() MUST return 0 in
system sleep context.
Acked-by: David S. Miller
Acked-by:
If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch comments on the case and requires that both
usbnet_suspend() and subdriver->suspend() MUST return 0 in
system sleep context.
Acked-by: David S. Miller
Acked-by:
If suspend callback fails in system sleep context, usb core will
ignore the failure and let the system sleep go ahead further, so this
patch doesn't recover device under this situation, otherwise
may cause resume() confused.
Acked-by: Jiri Kosina
Signed-off-by: Ming Lei
---
drivers/hid/usbhid/h
If suspend callback fails in system sleep context, usb core will
ignore the failure and let system sleep go ahead further, so
this patch comments on the case and requires that serial->type->suspend()
MUST return 0 in system sleep context.
Cc: Johan Hovold
Signed-off-by: Ming Lei
---
drivers/usb
This patch adds comments on interface driver suspend callback
to emphasize that the failure return value is ignored by
USB core in system sleep context, so do not try to recover
device for this case and let resume/reset_resume callback
handle the suspend failure if needed.
Also kerneldoc for usb_s
Hi,
This patch adds comments on interface driver suspend callback
to emphasize that the failure return value is ignored by
USB core in system sleep context, so do not try to recover
device for this case, otherwise the recovery things may confuse
resume().
Also fixes USB HID and several usbnet dri
On Friday, March 15, 2013 12:16 PM, Doug Anderson wrote:
>
> The ehci_vbus_gpio is requested but never freed. This can cause
> problems with deferred probes and would cause problems if
> s5p_ehci_remove was ever called. Use devm to fix this.
>
> Signed-off-by: Doug Anderson
Acked-by: Jingoo H
Jingoo,
On Thu, Mar 14, 2013 at 5:30 PM, Jingoo Han wrote:
> Would you replace other '&pdev->dev' with 'dev' in s5p_setup_vbus_gpio()
> as below? It seems to be better for readability.
Yes, of course. That was silly of me not to add the "dev" local and
not update the other places... Thanks for
The ehci_vbus_gpio is requested but never freed. This can cause
problems with deferred probes and would cause problems if
s5p_ehci_remove was ever called. Use devm to fix this.
Signed-off-by: Doug Anderson
---
Changes in v2:
- &pdev->dev => dev elsewhere in s5p_setup_vbus_gpio()
drivers/usb/h
On Thu, Mar 14, 2013 at 7:10 PM, Johan Hovold wrote:
> On Fri, Mar 08, 2013 at 12:15:19AM +0800, Ming Lei wrote:
>> This patch kills traffic even though type->suspend returns
>> failure inside usb_serial_suspend from system sleep context
>> because USB core ignores the failiure and lets system sle
On Thu, Mar 14, 2013 at 10:59:45AM -0400, Alan Stern wrote:
> On Thu, 14 Mar 2013, Peter Chen wrote:
>
> > /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c: In
> > function ‘handle_port_status’:
> > /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c:158
于 2013年03月14日 23:07, Alan Stern 写道:
> I have a net2280. Which patch do you want me to test? The two of you
> have come up with two different versions.
thank Alan very much, thank Felipe, too.
:-)
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscri
Without this memory barrier, the file-storage thread may fail to
escape from the following while loop, because it may observe new
common->thread_wakeup_needed and old bh->state which are updated by
the callback functions.
/* Wait for the CBW to arrive */
while (bh->state != BUF_STA
On Wednesday, March 13, 2013 4:03 AM, Doug Anderson wrote:
>
> The ehci_vbus_gpio is requested but never freed. This can cause
> problems with deferred probes and would cause problems if
> s5p_ehci_remove was ever called. Use devm to fix this.
>
> Signed-off-by: Doug Anderson
> ---
> drivers/
Hi Sergei
> 0x ===
> EHCI
> --
> 0x0094 PHY
> 0x009C PHY
> --
> EHCI
> 0x0400 ==
> ...
> 0x0800 --
>
On 14.03.2013 22:33, Alan Stern wrote:
On Thu, 14 Mar 2013, Soeren Moch wrote:
If the memory really is being leaked here in some sort of systematic
way, we may be able to see it in your debugging output after a few
seconds.
OK, here are the first seconds of the log. But the buffer exhaustion
The ehci_vbus_gpio is requested but never freed. This can cause
problems with deferred probes and would cause problems if
s5p_ehci_remove was ever called. Use devm to fix this.
Signed-off-by: Doug Anderson
---
drivers/usb/host/ehci-s5p.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
FYI, I just applied this patch to my staging and USB trees, hopefully
this makes some people here happy.
From: Greg Kroah-Hartman
Date: Thu, 14 Mar 2013 15:22:40 -0700
Subject: Staging: ccg: remove it from the build
This driver has been nothing but trouble, and no o
On Sat, Mar 09, 2013 at 12:22:42PM +0100, Bjørn Mork wrote:
> Loic Domaigne writes:
>
> > + /* The Nokia N60x,70x (productId 0x1419) needs:
> > +* - Jumbo Frame (MTU 8kB)
> > +* - Disable TX batching to improve latency
> > +
Hello.
On 15-03-2013 2:09, Felipe Balbi wrote:
From: Mikhail Kshevetskiy
Commit 032ec49f5351e9cb242b1a1c367d14415043ab95 (usb: musb: drop useless
board_mode usage) introduced a typo that breaks the build.
There were no replies on my first mail, so I would like to draw your attention
to
On Thu, Mar 14, 2013 at 09:49:08PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 14-03-2013 13:18, Michael Riesch wrote:
>
> >From: Mikhail Kshevetskiy
>
> >Commit 032ec49f5351e9cb242b1a1c367d14415043ab95 (usb: musb: drop useless
> >board_mode usage) introduced a typo that breaks the build.
>
Hi Sarah,
On 3/11/2013 5:20 PM, Sarah Sharp wrote:
> On Mon, Mar 11, 2013 at 05:33:26PM +, Cortes, Alexis wrote:
>> Hi Sarah,
>>
>> Sorry for my delayed response, I was investigating this. By 'Inactive' state
>> you mean the Compliance mode? since SS.Inactive and Compliance are not the
>> sa
On Thu, 14 Mar 2013, Soeren Moch wrote:
> > If the memory really is being leaked here in some sort of systematic
> > way, we may be able to see it in your debugging output after a few
> > seconds.
> >
>
> OK, here are the first seconds of the log. But the buffer exhaustion
> usually occurs after
On 14.03.2013 21:32, Alan Stern wrote:
On Thu, 14 Mar 2013, Soeren Moch wrote:
I added a debug message to
drivers/usb/host/ehci-sched.c:itd_urb_transaction() to log the
allocation flags, see log below.
But it looks like you didn't add a message to end_free_itds(), so we
don't know when the me
On Thu, 14 Mar 2013, Soeren Moch wrote:
> >> I added a debug message to
> >> drivers/usb/host/ehci-sched.c:itd_urb_transaction() to log the
> >> allocation flags, see log below.
> >
> > But it looks like you didn't add a message to end_free_itds(), so we
> > don't know when the memory gets dealloc
On 14.03.2013 19:48, Soeren Moch wrote:
On 10.03.2013 21:59, Alan Stern wrote:
On Sun, 10 Mar 2013, Soeren Moch wrote:
On Wed, 20 Feb 2013, Soeren Moch wrote:
Ok. I use 2 em2840-based usb sticks (em28xx driver) attached to a
Marvell Kirkwood-SoC with a orion-ehci usb controller. These usb
sti
On Thu, 14 Mar 2013, Felipe Balbi wrote:
> Here's the diff which needs testing:
Can't test the net2272 part.
> diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
> index 691cc65..d23c1b8 100644
> --- a/drivers/usb/gadget/net2280.c
> +++ b/drivers/usb/gadget/net2280.c
> @@ -
> I've got a minor update to this patch. Could you please test it? This
> is the version I want to submit.
>
Ok. Now patched into a 3.8.2 kernel. A number of suspend/resume cycles have
been run and no problems have so far been encountered. Will run with it and
report any issues.
Adrian Basse
On Thu, Mar 14, 2013 at 10:30:02PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 14-03-2013 19:24, Johan Hovold wrote:
>
> > Always try to disable the uart on close.
>
> > Since the switch to tty ports, close will be called as part of shutdown
> > before disconnect returns. Hence there is no nee
On 10.03.2013 21:59, Alan Stern wrote:
On Sun, 10 Mar 2013, Soeren Moch wrote:
On Wed, 20 Feb 2013, Soeren Moch wrote:
Ok. I use 2 em2840-based usb sticks (em28xx driver) attached to a
Marvell Kirkwood-SoC with a orion-ehci usb controller. These usb sticks
stream dvb data (digital TV) employin
On Wed, Mar 13, 2013 at 2:35 PM, Jiri Kosina wrote:
> OK, this is a "me too", on Thinkpad x200s.
>
> [4.116847] irq 16: nobody cared (try booting with the "irqpoll" option)
> [4.116849] Pid: 1, comm: systemd Not tainted 3.9.0-rc2-00188-g6c23cbb #186
> [4.116850] Call Trace:
> [4.11
On 13-03-14 12:12 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 11:17:21AM -0400, Paul Gortmaker wrote:
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 65217a5..40b8463 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
>
On Thu, Mar 14, 2013 at 01:39:39PM -0400, Peter Hurley wrote:
> On Thu, 2013-03-14 at 16:23 +0100, Johan Hovold wrote:
> > Make sure to unregister the tty-device before calling subdriver
> > port_remove.
> >
> > This way remove will reverse probe, and specifically any port data
> > released in por
Hello.
On 14-03-2013 19:24, Johan Hovold wrote:
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
MUSB controller cannot work in DMA mode with misaligned buffers,
switching in PIO mode.
HCD core has hooks that allow to override the default DMA
mapping and unmapping routines for host controllers that have
special DMA requirements, such as alignment contraints.
It is observed that work in PIO m
Hi guys,
This is a resend of my patch:
http://permalink.gmane.org/gmane.linux.usb.general/67238
At this moment it has been successfully tested and
used on top of 3.0 and 3.4 kernels on omap4 devices
so it would be great to have it in upstream too.
Regards,
Ruslan
Ruslan Bilovol (1):
usb: mus
Hello.
On 14-03-2013 13:18, Michael Riesch wrote:
From: Mikhail Kshevetskiy
Commit 032ec49f5351e9cb242b1a1c367d14415043ab95 (usb: musb: drop useless
board_mode usage) introduced a typo that breaks the build.
There were no replies on my first mail, so I would like to draw your attention
On Thu, 2013-03-14 at 16:23 +0100, Johan Hovold wrote:
> Make sure to unregister the tty-device before calling subdriver
> port_remove.
>
> This way remove will reverse probe, and specifically any port data
> released in port_remove will be available throughout tty unregister.
>
> Note that the o
[resend, no dmesg attached]
Hi,
happened to me again that I plugged in some devcie into my USB3 socket
in my laptop (usually use an external HUB). Don't believe this is a new
issue as a whole, I am facing this time to time since 3.3 time when I bought
the laptop.
But now, I realized the first
On Thu, 2013-03-14 at 18:22 +0100, Rafael J. Wysocki wrote:
> On Thursday, March 14, 2013 01:06:04 PM Peter Hurley wrote:
> > On Thu, 2013-03-14 at 17:46 +0100, Rafael J. Wysocki wrote:
> > > On Thursday, March 14, 2013 05:09:59 PM Jiri Kosina wrote:
> > > > On Thu, 14 Mar 2013, Jiri Kosina wrote:
On Thursday, March 14, 2013 01:06:04 PM Peter Hurley wrote:
> On Thu, 2013-03-14 at 17:46 +0100, Rafael J. Wysocki wrote:
> > On Thursday, March 14, 2013 05:09:59 PM Jiri Kosina wrote:
> > > On Thu, 14 Mar 2013, Jiri Kosina wrote:
> > >
> > > > > > I don't think I have seen this message on rc1+ (8
On Thu, 2013-03-14 at 17:46 +0100, Rafael J. Wysocki wrote:
> On Thursday, March 14, 2013 05:09:59 PM Jiri Kosina wrote:
> > On Thu, 14 Mar 2013, Jiri Kosina wrote:
> >
> > > > > I don't think I have seen this message on rc1+ (8343bce, to be
> > > > > precise),
> > > > > but I have definitely se
* Roger Quadros [130314 08:45]:
>
> OK. Let me know how the below patch looks. After that, the board code
> will look like.
>
> static struct usbhs_phy_data phy_data[] = {
> {
> .reset_gpio = 147,
> .vcc_gpio = 148
> .vcc_polarity = 1,
>
On Friday 15 March 2013 00:19:00 Du Xing wrote:
> Ming Lei
> Below is the Patch v2 according to your solutions.is there any
> misunderstanding?
The problem is that I needed to work around the counting nature of completions.
If you go to a waitqueue the need is removed. Your original patch togethe
On Thu, 2013-03-14 at 17:09 +0100, Jiri Kosina wrote:
> On Thu, 14 Mar 2013, Jiri Kosina wrote:
>
> > > > I don't think I have seen this message on rc1+ (8343bce, to be
> > > > precise),
> > > > but I have definitely seen sluggish system response on that kernel as
> > > > well.
> > > >
> > > >
On Thursday, March 14, 2013 05:09:59 PM Jiri Kosina wrote:
> On Thu, 14 Mar 2013, Jiri Kosina wrote:
>
> > > > I don't think I have seen this message on rc1+ (8343bce, to be
> > > > precise),
> > > > but I have definitely seen sluggish system response on that kernel as
> > > > well.
> > > >
>
On Thu, Mar 14, 2013 at 06:04:53PM +0200, Felipe Balbi wrote:
> in cases where PHY layer isn't enabled, we want
> to still return an error code (actually an error
> pointer) so that our users don't need to cope with
> either error pointer of NULL.
>
> This will simplify users as below:
>
> -
On Thursday, March 14, 2013 06:35 PM, Ming Lei wrote:
> On Thu, Mar 14, 2013 at 6:19 PM, Oliver Neukum wrote:
>> On Thursday 14 March 2013 18:07:29 Ming Lei wrote:
But then it makes no sense and you'd be better of with a waitqueue
instead of a completion.
>>>
>>> Maybe we can do it in a
On Thu, 14 Mar 2013, Jiri Kosina wrote:
> > There have been only three significant changes to uhci-hcd since last
> > summer, and two of them appear to be completely unrelated to this
> > issue. The three commits are
> >
> > 3171fcabb169 USB: uhci: beautify source code
> > 13996ca7afd
Hi,
On Thu, Mar 14, 2013 at 11:17:21AM -0400, Paul Gortmaker wrote:
> >>> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> >>> index 65217a5..40b8463 100644
> >>> --- a/drivers/usb/phy/Kconfig
> >>> +++ b/drivers/usb/phy/Kconfig
> >>> @@ -17,6 +17,7 @@ config OMAP_USB2
> >>>
> >>
On Thu, 14 Mar 2013, Jiri Kosina wrote:
> I have reverted all three commits, and the "nobody cared" is still there.
>
> > If you revert all three and still see the problem then it must be
> > caused by changes outside of the USB stack. Differences in interrupt
> > routing could be a result of c
On Thu, 14 Mar 2013, Jiri Kosina wrote:
> > > I don't think I have seen this message on rc1+ (8343bce, to be precise),
> > > but I have definitely seen sluggish system response on that kernel as
> > > well.
> > >
> > > Attaching lspci, /proc/interrupts and dmesg.
> >
> > Can you try to do a g
On Thu, Mar 14, 2013 at 03:50:57PM +0100, Paul Bolle wrote:
> On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote:
> > On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > > index 5a0c541..c65b5e2 100644
> > > -
in cases where PHY layer isn't enabled, we want
to still return an error code (actually an error
pointer) so that our users don't need to cope with
either error pointer of NULL.
This will simplify users as below:
- return IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV;
+ return PTR_ERR(phy);
R
On Thu, Mar 14, 2013 at 11:07:33AM -0400, Alan Stern wrote:
> On Thu, 14 Mar 2013, Felipe Balbi wrote:
>
> > Hi Alan,
> >
> > On Wed, Mar 13, 2013 at 05:53:04PM +0800, Chen Gang wrote:
> > > Hello Felipe Balbi:
> > >
> > > I have communicate with related member of net2272 and net2280.
> > >
On 03/14/2013 12:41 PM, Ruslan Bilovol wrote:
> These flags and structures are deprecated and there is
> no anymore users of them, so it's safe to remove them.
>
> Signed-off-by: Ruslan Bilovol
Acked-by: Roger Quadros
Tony,
Do you prefer to take this directly or want me to queue it up for you
On Thu, Mar 14, 2013 at 11:53:59AM +0530, Kishon Vijay Abraham I wrote:
> Having twl4030_usb_phy_init() (detects if a cable is connected before
> twl4030 is probed) in twl4030 probe makes cable connect events to be
> missed by musb glue, since it gets loaded after twl4030. Having
> twl4030_usb_phy_
On Thu, Mar 14, 2013 at 11:53:57AM +0530, Kishon Vijay Abraham I wrote:
> Used devres APIs devm_request_threaded_irq and devm_regulator_get for
> requesting irq and for getting regulator respectively.
>
> Signed-off-by: Kishon Vijay Abraham I
please refresh this on top of my testing branch, you
On Thu, 14 Mar 2013, Jiri Kosina wrote:
> > Is occurrence of the "nobody cared" connected with any particular
> > device? Somebody reported a similar problem not long ago (although IIRC
> > it was for OHCI rather than UHCI) which appeared to be related to
> > activity on the built-in webcam.
>
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Remove the now empty generic disconnect callback and make the disconnect
callback non-mandatory.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c| 6 --
drivers/usb/serial/usb-serial.c | 4 ++--
include/linux/usb/serial.h | 1 -
3 files changed, 2 insertions(+), 9 deleti
Make sure the interrupt urb submitted in port_probe is killed in
port_remove.
The interrupt-urb completion handler references the port and may get
called after port_remove has returned and the port has been
unregistered (although this is currently prevented by usb-serial core as
we are using a non
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 55 +
1 file changed, 15 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index adbca36
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mct_u232.c | 40
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index ebf9b89
Failed allocations already get an OOM message and a stack dump.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 37 +
1 file changed, 9 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-seri
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Simplify urb killing, and remove some related debug and dead code while
at it.
Signed-off-by: Johan Hovold
---
drivers/usb/serial
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Rename port_release so that all usb_serial_port functions have a common
prefix.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index 2c32f84.
Pass usb-serial port rather than usb device to set_control_lines, and
make sure port device is used for all port related debugging.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl230
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 39 ++-
1 file changed, 2 insertions(+), 37 deletions(-)
Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 4
1 file changed, 4 deleti
We should not call kill_traffic (and usb_kill_urb) once disconnect
returns. Any pending urbs are killed at disconnect and new submissions
are prevented by usb_unbind_interface (and usb_disable_interface).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 7 ---
1 file changed
On Wed, 13 Mar 2013, Adrian Bassett wrote:
> > Any issues in the last couple of days? If not, I'd like to go ahead
> > and submit this for inclusion in the next round of stable kernels.
>
> No, all's been well. Besides a vanilla 3.8.2 with just your latest
> patch I have also been using a kern
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb_wwan.c | 25 -
1 file changed, 12 insertions(+), 13
Use the port-data icount for interrupt counters.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index cbe439c..e3133e8
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/f81232.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
Make sure to unregister the tty-device before calling subdriver
port_remove.
This way remove will reverse probe, and specifically any port data
released in port_remove will be available throughout tty unregister.
Note that the order currently does not matter as the tty-layer can make
callbacks al
The calls to usb_poison_urb and usb_unpoison_urb are expected to be
balanced. However, if an urb that has not yet been submitted is
poisoned, its reject counter will not be increased as its ep-field is
NULL. A consecutive call to unpoison will thus in fact poison the urb
as its reject counter will
Use usb_poison_urb to reliably kill all urbs on disconnect and suspend.
This way there will be no question that the urbs cannot be resubmitted
by buggy subdrivers.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 55 +++--
1 file changed, 37
Remove bogus (and unnecessary) test for serial->dev being NULL in
cleanup.
The device is never cleared, and cleanup is never called after a
completed disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 24 ++--
1 file changed, 10 insertions(+),
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 48 ++--
1 file changed, 2 insertions(+), 46 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index bdf57d
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ti_usb_3410_5052.c | 44 ++-
1 file changed, 7 insertions(+), 37 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_
Pass usb-serial port to the control functions for uart status and work
mode.
Use port device for debugging and use dev_err to report errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 54 +++-
1 file changed, 28 insertions(+), 26 delet
Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 5 -
1 file changed, 5 dele
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Remove broken get_icount and TIOCMIWAIT support.
The driver has an icount structure but it is never been updated which
makes get_icount rather pointless and causes TIOCMIWAIT to always return
-EIO.
Note that the TIOCMIWAIT implementation has always been broken and would
not work even if icount su
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cyberjack.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 39 ---
1 file changed
Remove bogus disconnect test for serial device being NULL in read bulk
callback. This can never happen as the port read urb is killed (and
poisoned) at close, which in turn is guaranteed to be called before the
last tty reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovol
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 30 ++
1 file changed, 2 insertions(+), 28 deletions(-)
diff --g
1 - 100 of 229 matches
Mail list logo
