Dear Peter Chen,
[...]
> +
> +#define CI_VBUS_STABLE_TIMEOUT 500
Shall we not change this to static const int instead ?
[...]
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1371,6 +1371,7 @@ static int ci13xxx_vbus_session(struct usb_gadget
> *_gadget, int is_active
- For host, the vbus should always be on.
- For otg, the vbus is off defaultly, the vbus needs to be
turned on/off when usb role switches.
Signed-off-by: Peter Chen
---
Changes for v3:
- Add return value check for regulator_enable/regulator_disable
- typo error
drivers/usb/chipidea/ci.h
(change CI13XXX to CI13 to avoid junk email check)
Now, we have handled vbus session in core driver when the
vbus interrupt occurs, so our pullup operations are all
according to vbus.
Of cource, the software can still call .pullup when device connects
to host if it wants to connect/disconnect with
- During the connect/disconnect host, we need to pullup
and pulldown dp
- Make sure the dp is not pullup until the vbus is on when
flag CI13XXX_PULLUP_ON_VBUS is set
- Using hw_device_state when set run/stop bit
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/udc.c | 10 --
1 files
- Create init/destroy API for probe and remove
- start/stop API are only used otg id switch process
- Create the gadget at ci_hdrc_probe if the gadget is supported
at that port, the main purpose for this is to avoid gadget module
load fail at init.rc
Signed-off-by: Peter Chen
---
Changes for v4:
The main design flow is the same with msm otg driver, that is the id and
vbus interrupt are handled at core driver, others are handled by
individual drivers.
- At former design, when switch usb role from device->host, it will call
udc_stop, it will remove the gadget driver, so when switch role
fro
vbus register is at otgsc, and vbus detect does not belong
to device function. Revert this patch, and will move
vbus detect function to drivers/usb/chipidea/udc.c
This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208.
Signed-off-by: Peter Chen
---
Changes for v3:
Add Signed-off-by: Peter
Implement struct usb_otg, In that way, calling otg_set_peripheral
will not be failed at udc.c.
Signed-off-by: Peter Chen
---
Changes for v4:
- Some tiny changes, like delete unused header files
drivers/usb/chipidea/Makefile |2 +-
drivers/usb/chipidea/ci.h |2 +
drivers/usb/chipidea
(Sorry for update slowly due to long time business trip)
Changes for v4 mainly for 2/7, 3/7, 4/7, see individual
patch commit for detail.
This patchset adds fully tested otg id switch function and
vbus connect/disconnect detection for chipidea driver.
The mainly design of id/vbus handling follows
On Wed, 26 Dec 2012, Larry Finger wrote:
> On 12/26/2012 10:45 AM, Alan Stern wrote:
> >
> > I see. Do you happen to have CONFIG_USB_EHCI_HCD=y and
> > CONFIG_USB_EHCI_PCI=m in your .config? If you do, try changing
> > EHCI_PCI to y.
>
> One additional data point: When the EHCI and HCD paramete
On Wed, Dec 26, 2012 at 05:58:32PM +0530, Vivek Gautam wrote:
> + if (!ret)
> + sphy->phyctrl_pmureg = ioremap(reg[0], reg[1]);
> +
> + of_node_put(usbphy_pmu);
> +
> + if (IS_ERR_OR_NULL(sphy->phyctrl_pmureg)) {
No. Learn what the error return values are from functions.
Hi,
On 12/26/2012 02:56 PM, Vivek Gautam wrote:
On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautam wrote:
Adding support to parse device node data in order to get
required properties to set pmu isolation for usb-phy.
Signed-off-by: Vivek Gautam
---
Hope these changes align with what architectura
On 12/24/2012 09:13 AM, Vivek Gautam wrote:
These two changes look good to me. For both of them:
Reviewed-by: Doug Anderson
Well, I have another idea. Yes, I know, specific chip name should be used.
But
you know the specific chip name in compatible can cause another confusion
on other SoC w
On 12/26/2012 01:28 PM, Vivek Gautam wrote:
Adding support to parse device node data in order to get
required properties to set pmu isolation for usb-phy.
Signed-off-by: Vivek Gautam
---
.../devicetree/bindings/usb/samsung-usbphy.txt | 31
drivers/usb/phy/samsung-usbphy.c
Hello.
On 12/26/2012 09:42 PM, Dongjin Kim wrote:
> This patch support to get interrupt resource from device tree as well as
> platform device if ehci node is defined in device tree and it's irq is
> described.
> Signed-off-by: Dongjin Kim
> ---
> drivers/usb/host/ehci-s5p.c |8 +++-
>
On 12/26/2012 10:45 AM, Alan Stern wrote:
I see. Do you happen to have CONFIG_USB_EHCI_HCD=y and
CONFIG_USB_EHCI_PCI=m in your .config? If you do, try changing
EHCI_PCI to y.
One additional data point: When the EHCI and HCD parameters are set to y rather
than m as in the list that follows,
On Wed, 26 Dec 2012 09:21:03 -0800, Frank Schäfer
wrote:
Am 24.12.2012 20:23, schrieb Alan Stern:
On Fri, 21 Dec 2012, Frank Schäfer wrote:
Anyway, system still wakes up from S3 immediately.
It just occurred to me that not too long ago we learned about a BIOS
bug in ASUS systems that affect
This patch support to get interrupt resource from device tree as well as
platform device if ehci node is defined in device tree and it's irq is
described.
Signed-off-by: Dongjin Kim
---
drivers/usb/host/ehci-s5p.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/driv
On 12/26/2012 10:45 AM, Alan Stern wrote:
I see. Do you happen to have CONFIG_USB_EHCI_HCD=y and
CONFIG_USB_EHCI_PCI=m in your .config? If you do, try changing
EHCI_PCI to y.
No, they are both "m". My configuration parameters with EHCI in them are
CONFIG_USB_ARCH_HAS_EHCI=y
CONFIG_USB_EHCI_
Am 24.12.2012 20:23, schrieb Alan Stern:
> On Fri, 21 Dec 2012, Frank Schäfer wrote:
>
>> Anyway, system still wakes up from S3 immediately.
> It just occurred to me that not too long ago we learned about a BIOS
> bug in ASUS systems that affects EHCI controllers during system suspend
> (the workar
Am 21.12.2012 18:02, schrieb Alan Stern:
> On Fri, 21 Dec 2012, Frank Schäfer wrote:
>
>> 00:02.0 USB controller: NVIDIA Corporation MCP61 USB 1.1 Controller (rev
>> a2) (prog-if 10 [OHCI])
>> Subsystem: ASUSTeK Computer Inc. Device 8234
>> Control: I/O+ Mem+ BusMaster- SpecCycle-
On Wed, 26 Dec 2012, Fabio Coatti wrote:
> Hi all,
> I'm experiencing some usb-related issues with recent kernels (3.6.7
> and 3.7.1 at least.)
> Basically I have a V500 epson scanner that worked just fine with older
> kernels; since last time I used it I've changed several kernels and
> now the o
On Tue, 25 Dec 2012, Larry Finger wrote:
> On 12/25/2012 10:26 AM, Alan Stern wrote:
> > On Mon, 24 Dec 2012, Larry Finger wrote:
> >
> >> The problem has been bisected to commit adfa79d entitled "USB: EHCI: make
> >> ehci-pci a separate driver". The symptom is that my NVIDIA controller again
> >>
On Wednesday 26 December 2012 18:29:44 Den Ladin wrote:
> From: Denis N Ladin
>
> Adding support "PSC Scanning, Magellan 800i" in cdc-acm
> Signed-off-by: Denis N Ladin
Acked-by: Oliver Neukum
> ---
> Very simple, but very necessary.
> Suitable for all versions of the kernel > 2.6
--
To unsubs
Hi Sylwester,
On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautam wrote:
> Adding support to parse device node data in order to get
> required properties to set pmu isolation for usb-phy.
>
> Signed-off-by: Vivek Gautam
> ---
Hope these changes align with what architectural changes you had suggested
From: Denis N Ladin
Adding support "PSC Scanning, Magellan 800i" in cdc-acm
Signed-off-by: Denis N Ladin
---
Very simple, but very necessary.
Suitable for all versions of the kernel > 2.6
patch-3.7.1-magellan-800i
Description: Binary data
Adding support to parse device node data in order to get
required properties to set pmu isolation for usb-phy.
Signed-off-by: Vivek Gautam
---
.../devicetree/bindings/usb/samsung-usbphy.txt | 31
drivers/usb/phy/samsung-usbphy.c | 145 +---
2 files c
Changes form v3:
- Removing the hostphy_en_mas since this gets used in forthcoming patches
only when host phy support is added.
- Resolving few nits:
- using 'const' specifier for driver data structures.
- using ARRAY_SIZE() instead of giving magic number
for of_prope
Hi Doug,
On Fri, Dec 21, 2012 at 10:35 PM, Doug Anderson wrote:
> Vivek,
>
> Nothing really serious below and things look good to me, but figured
> I'd put a few nits in (sorry!).
>
>
> On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam
> wrote:
>> diff --git a/Documentation/devicetree/bindings/us
On Mon, Dec 24, 2012 at 12:41:14PM +0500, Den Ladin wrote:
> Adding support "PSC Scanning, Magellan 800i" in cdc-acm
>
> Very simple, but very necessary.
> Suitable for all versions of the kernel > 2.6
Please submit your patch (the latest one against v3.7.1) as an inline
attachment. You also need
Forgot to CC: possibly interested people, sorry.
-- Forwarded message --
From: Fabio Coatti
Date: 2012/12/24
Subject: usb issues with 3.6.X and 3.7.X
To: linux-ker...@vger.kernel.org
Hi all,
I'm experiencing some usb-related issues with recent kernels (3.6.7
and 3.7.1 at least.
31 matches
Mail list logo
