Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-09 Thread Lan Tianyu
On 2012年12月07日 23:22, Alan Stern wrote: > On Fri, 7 Dec 2012, Lan Tianyu wrote: > >>> Maybe you really need two flags. Do whatever is best; I'm sure you can >>> figure out a good scheme. >> Yeah. Two flags maybe good. In this situation, it should be call >> "power_is_on", right? power_is_on can b

[PATCH] usb: renesas_usbhs: mod_host: fixup usbhsh_ureq_free() timing

2012-12-09 Thread Kuninori Morimoto
usbhsh_ureq_free() free ureq which includes ubshs_pkt. But current driver used usbhs_pkt after freed ureq. This patch fixup this bug. Special thanks to Chen Reported-by: Chen Gang Signed-off-by: Kuninori Morimoto --- drivers/usb/renesas_usbhs/mod_host.c |3 ++- 1 file changed, 2 insertions(

[PATCH] usb: imx21-hcd: Include missing linux/module.h

2012-12-09 Thread Fabio Estevam
From: Fabio Estevam Include , so that the following errors are fixed: drivers/usb/host/imx21-hcd.c:1929:20: error: expected declaration specifiers or '...' before string constant drivers/usb/host/imx21-hcd.c:1930:15: error: expected declaration specifiers or '...' before string constant driver

Re: usb bus monitoring

2012-12-09 Thread Alan Stern
On Mon, 10 Dec 2012, Tilman wrote: > Hello > > I am in the process of writing firmware for an USB device based on an 8051 > core. > I am testing it against linux kernel driver. > > I am submitting an urb to the device via a linux kernel modul, and I get no > response. The urb eventually times

Re: usb bus monitoring

2012-12-09 Thread Peter Stuge
Tilman wrote: > I am in the process of writing firmware for an USB device based on > an 8051 core. What device is that? Is it a Cypress FX2 or an SiLabs C8051? > I am testing it against linux kernel driver. Depending on the device it may be worth exploring also the libusb alternative, allowing

Re: [Suggestion] drivers/usb/renesas_usbhs: pkt is still in use, after it was already free.

2012-12-09 Thread Chen Gang
于 2012年12月10日 08:21, Kuninori Morimoto 写道: > > Hi Chen > >> Hello Greg Kroah-Hartman: >> >> in drivers/usb/renesas_usbhs/mod_host.c, in function usbhsh_queue_done: >> >> get ureq from pkt, by using the macro usbhsh_pkt_to_ureq (at line 637) >> pkt is the sub-object of ureq (line 73..7

Re: [Suggestion] drivers/usb/renesas_usbhs: pkt is still in use, after it was already free.

2012-12-09 Thread Kuninori Morimoto
Hi Chen > Hello Greg Kroah-Hartman: > > in drivers/usb/renesas_usbhs/mod_host.c, in function usbhsh_queue_done: > > get ureq from pkt, by using the macro usbhsh_pkt_to_ureq (at line 637) > pkt is the sub-object of ureq (line 73..76, line 157..158) > > free ureq, by calling func

usb bus monitoring

2012-12-09 Thread Tilman
Hello I am in the process of writing firmware for an USB device based on an 8051 core. I am testing it against linux kernel driver. I am submitting an urb to the device via a linux kernel modul, and I get no response. The urb eventually times out. Via debug FS I can see that the urb is indeed su