Re: [PATCH v3 6/7] usb: chipidea: usbmisc: add mx53 support

2012-11-22 Thread Sascha Hauer
On Fri, Nov 23, 2012 at 02:53:41PM +0800, Peter Chen wrote: > On Wed, Nov 21, 2012 at 03:06:32PM +0100, Michael Grzeschik wrote: > > This adds mx53 as the next user of the usbmisc driver and makes it > > possible to disable the overcurrent-detection of the internal phy. > > > > Signed-off-by: Mich

Re: [PATCH v3 3/7] usb: chipidea: usbmisc: fix a potential race condition

2012-11-22 Thread Sascha Hauer
On Fri, Nov 23, 2012 at 01:36:36PM +0800, Peter Chen wrote: > On Wed, Nov 21, 2012 at 03:06:29PM +0100, Michael Grzeschik wrote: > > From: Marc Kleine-Budde > > > > This fixes a potential race condition where the ci13xxx_imx glue code > > could be fast enough to call one of the usbmisc_ops before

Re: [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV

2012-11-22 Thread Peter Chen
On Thu, Nov 22, 2012 at 10:11:31AM +0100, Lothar Waßmann wrote: > > Signed-off-by: Lothar Waßmann > --- > drivers/usb/chipidea/core.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index b726c49..bd6e7a

Re: [PATCH v3 7/7] usb: chipidea: usbmisc: add post handling and errata fix for mx25

2012-11-22 Thread Peter Chen
On Wed, Nov 21, 2012 at 03:06:33PM +0100, Michael Grzeschik wrote: > This adds a post handling routine which is called after > ci13xxx_add_device was called. The first user is the mx25, which has to > disable the external-vbus-divider after the ude has started. udc has started? > > > +static int

Re: [PATCH v3 6/7] usb: chipidea: usbmisc: add mx53 support

2012-11-22 Thread Peter Chen
On Wed, Nov 21, 2012 at 03:06:32PM +0100, Michael Grzeschik wrote: > This adds mx53 as the next user of the usbmisc driver and makes it > possible to disable the overcurrent-detection of the internal phy. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > Changes sin

Re: [PATCH v3 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-22 Thread Peter Chen
On Wed, Nov 21, 2012 at 03:06:31PM +0100, Michael Grzeschik wrote: > From: Marc Kleine-Budde > > This patch adds support for a second and third clock to the usbmisc driver. On > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks > ("ahb", > "ipg" and "per") must be enabled i

[PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV

2012-11-22 Thread Lothar Waßmann
Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/core.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index b726c49..bd6e7a4 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@

[BUGFIX PATCH] USB: chipidea: fix use after free bug

2012-11-22 Thread Lothar Waßmann
The pointer to a platform_device struct must not be dereferenced after the device has been unregistered. This bug produces a crash when unloading the ci13xxx kernel module compiled with CONFIG_PAGE_POISONING enabled. Signed-off-by: Lothar Waßmann --- drivers/usb/chipidea/core.c |3 ++- 1 fi

Re: [PATCH v3 3/7] usb: chipidea: usbmisc: fix a potential race condition

2012-11-22 Thread Peter Chen
On Wed, Nov 21, 2012 at 03:06:29PM +0100, Michael Grzeschik wrote: > From: Marc Kleine-Budde > > This fixes a potential race condition where the ci13xxx_imx glue code > could be fast enough to call one of the usbmisc_ops before he got a > valid value on the static usbmisc pointer. To fix that we

Re: [PATCH v8 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-11-22 Thread Praveen Paneri
Hi Tomasz, On Thu, Nov 22, 2012 at 1:36 AM, Tomasz Figa wrote: > Hi Praveen, > > See some minor comments inline. Thanks for your comments > > On Wednesday 14 of November 2012 15:57:15 Praveen Paneri wrote: >> This driver uses usb_phy interface to interact with s3c-hsotg. Supports >> phy_init and

Re: [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support

2012-11-22 Thread Praveen Paneri
On Thu, Nov 22, 2012 at 1:41 AM, Tomasz Figa wrote: > Hi Praveen, > > On Wednesday 14 of November 2012 15:57:16 Praveen Paneri wrote: >> Adding the transceiver to hsotg driver. Keeping the platform data >> for continuing the smooth operation for boards which still uses it >> >> Signed-off-by: Prav

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Alan Stern
On Thu, 22 Nov 2012, Felipe Balbi wrote: > > The latter, more or less. For example, maybe we can tell usbcore > > somehow that regulator X is in control of a device attached to host > > controller Y (not sure how we would express X and Y though). Then when > > usb_add_hcd() sees that the host co

Mouse and keyboard freeze Ivy-bridge

2012-11-22 Thread Chris Holland
https://bugzilla.kernel.org/show_bug.cgi?id=50821 Summary: Mouse and keyboard freeze Ivy-bridge I have been having the problem of the mouse and keyboard freezing since upgrading my system in May 2012 GIGABYTE GA-Z77X-UD5H LGA 1155 Intel Z77 HDMI SATA Intel Core i5-3550 Ivy Bridge Mouse and key

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Andy Green
On 11/23/12 01:36, the mail apparently from Alan Stern included: On Thu, 22 Nov 2012, Felipe Balbi wrote: Hi - If you mean change the regulator managing code from living in omap-hsusb to ehci-hcd, it sounds like a good idea. I mean that drivers/usb/core/hub.c should manage it, since that's

Re: [PATCH 2/2] input: usb: hid: Add quirk for Freescale i.MX28 ROM recovery

2012-11-22 Thread Marek Vasut
Dear Jiri Kosina, > On Wed, 21 Nov 2012, Marek Vasut wrote: > > > > > diff --git a/drivers/hid/usbhid/hid-quirks.c > > > > > b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644 > > > > > --- a/drivers/hid/usbhid/hid-quirks.c > > > > > +++ b/drivers/hid/usbhid/hid-quirks.c > > > > > @@

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 12:36:43PM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Felipe Balbi wrote: > > > > If you mean change the regulator managing code from living in > > > omap-hsusb to ehci-hcd, it sounds like a good idea. > > > > I mean that drivers/usb/core/hub.c should manage it,

Re: [PATCH 2/2] input: usb: hid: Add quirk for Freescale i.MX28 ROM recovery

2012-11-22 Thread Jiri Kosina
On Wed, 21 Nov 2012, Marek Vasut wrote: > > > > diff --git a/drivers/hid/usbhid/hid-quirks.c > > > > b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644 > > > > --- a/drivers/hid/usbhid/hid-quirks.c > > > > +++ b/drivers/hid/usbhid/hid-quirks.c > > > > @@ -101,6 +101,7 @@ static const

Re: [PATCH] USB: add support to novatec wireless mouse

2012-11-22 Thread Jiri Kosina
On Thu, 22 Nov 2012, Marco Biscaro wrote: > This patch adds support to Novatec wireless mouse (device ID 0603:1602). > Fixes bug https://bugzilla.kernel.org/show_bug.cgi?id=47031 > > Signed-off-by: Marco Biscaro I am taking this one, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from thi

[PATCH] USB: add support to novatec wireless mouse

2012-11-22 Thread Marco Biscaro
This patch adds support to Novatec wireless mouse (device ID 0603:1602). Fixes bug https://bugzilla.kernel.org/show_bug.cgi?id=47031 Signed-off-by: Marco Biscaro --- diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 9d7a428..b40632e 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/

[PATCH 26/29] usb: otg: mv_otg: add device tree support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- drivers/usb/otg/mv_otg.c | 127 + drivers/usb/otg/mv_otg.h |6 +- 2 files changed, 107 insertions(+), 26 deletions(-) diff --git a/drivers/usb/otg/mv_otg.c b/drivers/usb/otg/mv_otg.c index bd6369c..8870

[PATCH 27/29] usb: ehci: ehci-mv: add device tree support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- drivers/usb/host/ehci-mv.c | 104 +--- 1 files changed, 79 insertions(+), 25 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index 171e145..0e99dac 100644 --- a/drivers/usb/hos

[PATCH 25/29] usb: gadget: mv_udc: add device tree support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- drivers/usb/gadget/mv_udc.h |5 +- drivers/usb/gadget/mv_udc_core.c | 105 ++ 2 files changed, 85 insertions(+), 25 deletions(-) diff --git a/drivers/usb/gadget/mv_udc.h b/drivers/usb/gadget/mv_udc.h index

[PATCH 24/29] arm: mmp: add extern chip support for ttc_dkb

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- arch/arm/mach-mmp/ttc_dkb.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index 0962791..eb34608 100644 --- a/arch/arm/mach-mmp/ttc_dkb.c +++ b/arch/arm/mach-mmp/ttc_

[PATCH 21/29] usb: ehci: ehci-mv: add extern chip support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- drivers/usb/host/ehci-mv.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index be504fd..171e145 100644 --- a/drivers/usb/host/ehci-mv.c +++ b/drivers/usb/host

[PATCH 19/29] usb: phy: mv_usb2_phy: add externel chip support

2012-11-22 Thread Chao Xie
From: Chao Xie For the vbus and idpin detection. It may be completed by some external chip. The controller need clock on and PHY enabled to detect the vbus/idpin. It will increase the power. So using the external chip to detect the vbus and idpin can save the power. Signed-off-by: Chao Xie ---

[PATCH 22/29] usb: otg: mv_otg: add extern chip support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- drivers/usb/otg/mv_otg.c | 63 - drivers/usb/otg/mv_otg.h |3 ++ 2 files changed, 31 insertions(+), 35 deletions(-) diff --git a/drivers/usb/otg/mv_otg.c b/drivers/usb/otg/mv_otg.c index 344f246..bd636

[PATCH 13/29] arm: mmp2: change the defintion of usb devices

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- arch/arm/mach-mmp/include/mach/mmp2.h |4 arch/arm/mach-mmp/mmp2.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h b/arch/arm/mach-mmp/include/mach/mmp2.h index c4

[PATCH 20/29] usb: gadget: mv_udc: add extern chip support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- drivers/usb/gadget/mv_udc.h |3 ++ drivers/usb/gadget/mv_udc_core.c | 45 ++--- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/drivers/usb/gadget/mv_udc.h b/drivers/usb/gadget/mv_udc.h index

[PATCH 18/29] arm: mmp: remove usb devices from pxa168

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- arch/arm/mach-mmp/pxa168.c | 42 -- 1 files changed, 0 insertions(+), 42 deletions(-) diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c index b7f074f..dd3a68b 100644 --- a/arch/arm/mach-mmp/

[PATCH 29/29] arm: mmp: devicetree: add usb support for pxa910_dkb

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- arch/arm/boot/dts/pxa910.dtsi | 30 ++ arch/arm/mach-mmp/mmp-dt.c|5 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/pxa910.dtsi b/arch/arm/boot/dts/pxa910.dtsi index 825aaca

[PATCH 28/29] arm: mmp: devicetree: add usb support for mmp2

2012-11-22 Thread Chao Xie
From: Chao Xie Enable usb devices for mmp2 device tree. Signed-off-by: Chao Xie --- arch/arm/boot/dts/mmp2.dtsi | 30 ++ arch/arm/mach-mmp/mmp2-dt.c |4 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm

Re: [PATCH v3 0/7] support other fsl SoCs with usbmisc + small fixes

2012-11-22 Thread Peter Chen
On Thu, Nov 22, 2012 at 11:24:44AM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > Nearly every SoC from Freescale has this non-core usb registers. This series > > adds support for more users of this driver. > > > > This series is based on Peter Chen's work. Its needed to merge

Re: [RFCv4 PATCH 13/13] usb: gadget: ufg: add Mass Storage Gadget adapter to UFG

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > +#define _FSG_MODULE_PARAM_ARRAY(prefix, params, name, type, desc)\ > + module_param_array_named(prefix ## name, params.name, type, \ > + &prefix ## params.name ## _count, \ > +

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Roger Quadros
On 11/22/2012 03:56 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote: >>> Again it sounds like something that should be done at the hub driver >>> level. I mean using the GPIO (for reset) and Power Regulator. >>> >>> not implementing the regulator part i

Re: [RFCv4 PATCH 12/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: use new function registration framework

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > +static void fsg_free(struct usb_function *f) > +{ > + struct fsg_dev *fsg = fsg_from_func(f); > + > kfree(fsg); > } kfree(fsg_from_func(f)); if you ask me, but feel free to ignore me. > > @@ -2970,22 +2981,65 @@ a

[PATCH 1/1 v2] asix: use ramdom hw addr if the one read is not valid

2012-11-22 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: linux-usb@vger.kernel.org Cc: net...@vger.kernel.org --- v2: introduce asix_set_netdev_dev_addr Best Regards, J. drivers/net/usb/asix_devices.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/

Re: [PATCH v6] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-11-22 Thread Greg KH
On Thu, Nov 22, 2012 at 04:01:49PM +0100, Olivier Sobrie wrote: > Hi linux-usb folks, > > Is there someone who can help me to fix the following errors? > > smatch warnings: > > + drivers/net/can/usb/kvaser_usb.c:431 kvaser_usb_send_simple_msg() error: > doing > +dma on the stack ((null)) > + dr

[PATCH] ezusb: add dependency to USB

2012-11-22 Thread Rene Buergel
This fixes an error during modpost, when ezusb is built into the kernel while USB is built as module. Signed-off-by: René Bürgel -- diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index a8f0523..fecde69 100644 --- a/drivers/usb/misc/Kconfig +++ b/drivers/usb/misc/Kconfig @@ -246

Re: [RFCv4 PATCH 04/13] usb: gadget: example port of mass storage to UFG: storage common: change struct device to configfs entities

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > @@ -45,10 +46,9 @@ > #define VLDBG(lun, fmt, args...) do { } while (0) > #endif /* VERBOSE_DEBUG */ > > -#define LDBG(lun, fmt, args...) dev_dbg (&(lun)->dev, fmt, ## args) > -#define LERROR(lun, fmt, args...) dev_err (&(lun)->dev, fmt, ## a

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-22 Thread Sebastian Andrzej Siewior
On Thu, Nov 22, 2012 at 07:56:44AM +0200, Felipe Balbi wrote: > > > /* dma address for sync dma */ > > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > > if (!mem) { > > > pr_debug("no sync dma resource?\n"); > > > ret = -ENODEV; >

Re: [RFCv4 PATCH 11/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: add configfs type

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park > --- > drivers/usb/gadget/f_mass_storage.c | 225 > +++ > 1 files changed, 225 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/gad

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > mount -t configfs none /cfg > mkdir -p /cfg/usb-function-gadget/G1/C1/F1 > echo 0x > /cfg/usb-function-gadget/G1/idVendor > echo 0x > /cfg/usb-function-gadget/G1/idProduct > echo 0x > /cfg/usb-function-gadget/G1/bcdDevice > echo > /cfg/usb-functi

[PATCH 1/2] USB: musb: fix failure path

2012-11-22 Thread Ming Lei
In the fail1~fail5 failure path, pm_runtime_disable() should be called to avoid 'Unbalanced pm_runtime_enable' error in next probe() which may be triggered by defer probe or next 'modprobe musb_hdrc'. Cc: Sebastian Andrzej Siewior Cc: Felipe Balbi Signed-off-by: Ming Lei --- drivers/usb/musb/m

Re: [BUGFIX PATCH] USB: chipidea: fix use after free bug

2012-11-22 Thread Alexander Shishkin
Lothar Waßmann writes: > The pointer to a platform_device struct must not be dereferenced after > the device has been unregistered. > > This bug produces a crash when unloading the ci13xxx kernel module > compiled with CONFIG_PAGE_POISONING enabled. > > Signed-off-by: Lothar Waßmann Good one, t

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Michal Nazarewicz
> * Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: >> Using configfs to create/configure a usb gadget requires >> providing a method to create config group for a usb function >> and a wrapper for usb_add_function. >> >> Signed-off-by: Andrzej Pietrasiewicz >> Signed-off-by: Kyungmin Park O

[PATCH] usb: ftdi_sio: fixup BeagleBone A5+ quirk

2012-11-22 Thread Peter Korsgaard
BeagleBone A5+ devices ended up getting shipped with the 'BeagleBone/XDS100V2' product string, and not XDS100 like it was agreed, so adjust the quirk to match. For details, see the thread on the beagle list: https://groups.google.com/forum/#!msg/beagleboard/zrFPew9_Wvo/ibWr1-eE8JwJ Signed-off-by

Re: [PATCH] UVC: use GFP_ATOMIC under spin lock.

2012-11-22 Thread Laurent Pinchart
On Thursday 22 November 2012 14:22:23 Felipe Balbi wrote: > On Thu, Nov 22, 2012 at 09:09:57AM +0100, walter harms wrote: > > Am 19.11.2012 22:34, schrieb Cyril Roelandt: > > > Found using the following semantic patch: > > > > > > @@ > > > @@ > > > spin_lock_irqsave(...); > > > ... when != spin_un

[RFC 6/8] USB: Ignore USB 3.0 port state until reset completes.

2012-11-22 Thread Sarah Sharp
The port reset code bails out early if the current connect status is cleared (device disconnected). If we're issuing a hot reset, it may also look at the link state before the reset is finished. Section 10.14.2.6 of the USB 3.0 spec says that when a port enters the Error state or Resetting state,

Re: [PATCH 02/16] mfd: omap-usb-tll: Clean up clock handling

2012-11-22 Thread Roger Quadros
On 11/21/2012 09:39 PM, Felipe Balbi wrote: > Hi, > > On Wed, Nov 21, 2012 at 05:39:57PM +0200, Roger Quadros wrote: >> On 11/21/2012 04:03 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Wed, Nov 21, 2012 at 02:36:48PM +0200, Roger Quadros wrote: >> break; >> default:

Re: [PATCH v6] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-11-22 Thread Olivier Sobrie
Hi linux-usb folks, Is there someone who can help me to fix the following errors? smatch warnings: + drivers/net/can/usb/kvaser_usb.c:431 kvaser_usb_send_simple_msg() error: doing +dma on the stack ((null)) + drivers/net/can/usb/kvaser_usb.c:1073 kvaser_usb_set_opt_mode() error: doing +dma on th

[RFC 2/8] USB: Ignore xHCI Reset Device status.

2012-11-22 Thread Sarah Sharp
A device may need to be reset several times during enumeration, and this causes a disconnect between the USB core's device state and the xHC's device state. For example, usb_reset_and_verify_device calls into hub_port_init in a loop. Say that on the first call into hub_port_init, the device is su

[RFC 3/8] xHCI: Clear all USB 2.0 change bits on port disable.

2012-11-22 Thread Sarah Sharp
The USB core disables the USB 2.0 ports in several different error cases. It expects that all USB hubs will act like external hubs, and always return an interrupt event if a port change bit is set. External USB 2.0 and USB 3.0 hubs are level-triggered, so this works for them. However, xHCI rooth

[RFC 8/8] USB: Fix connected device switch to Inactive state.

2012-11-22 Thread Sarah Sharp
A USB 3.0 device can transition to the Inactive state if a U1 or U2 exit transition fails. The current code in hub_events simply issues a warm reset, but does not call any pre-reset or post-reset driver methods (or unbind/rebind drivers without them). Therefore the drivers won't know their device

[RFC 0/8] USB core reset changes

2012-11-22 Thread Sarah Sharp
Hi Alan, Can you take a look over this patchset to improve reset support under xHCI roothubs? There's a lot of changes here, but I tried to break it up into easily verifiable chunks. I'd like to backport all the patches except the last one to stable trees, so I would really appreciate your revie

Re: [RFCv4 PATCH 08/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: remove unused operations

2012-11-22 Thread Michal Nazarewicz
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote: > pre_eject and post_eject are not used by anyone. Removing them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz As far as I'm concerned, this can get merged regardless of the other patches.

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Michal Nazarewicz
> * Andrzej Pietrasiewicz | 2012-11-22 13:06:56 [+0100]: >> echo .img > >> /cfg/usb-function-gadget/G1/C1/F1/MassStorage/lun0/file >> >> Do the similar thing to other functions, then >> >> echo 1 > /cfg/usb-function-gadget/G1/ready On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote: > One thing

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 01:32:25PM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Felipe Balbi wrote: > > > Hi, > > Hello. > > > > This is an interesting problem. How should we handle devices which > > > live on a discoverable bus but whose power is controlled by an > > > undiscoverable p

[RFC 4/8] USB: Allow USB 3.0 ports to be disabled.

2012-11-22 Thread Sarah Sharp
If hot and warm reset fails, or a port remains in the Compliance Mode, the USB core needs to be able to disable a USB 3.0 port. Unlike USB 2.0 ports, once the port is placed into the Disabled link state, it will not report any new device connects. To get device connect notifications, we need to p

[RFCv4 PATCH 03/13] usb: gadget: example port of mass storage to UFG: create storage_common.h and factor out code from storage_common.c

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/storage_common.c | 39 +-- drivers/usb/gadget/storage_common.h | 43 +++ 2 files changed, 44 insertions(+), 38 deletions(-) create mode 100644

[RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Andrzej Pietrasiewicz
Using configfs to create/configure a usb gadget requires providing a method to create config group for a usb function and a wrapper for usb_add_function. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- include/linux/usb/composite.h |6 ++ 1 files changed, 6 inserti

[RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Andrzej Pietrasiewicz
Demonstrate a USB gadget configured entirely through configfs. This is a work in progress. In order to integrate configfs into gadget's code there must be some place to store the code which does configfs-based binding/unbinding. It is not intended to create yet another gadget. But there must be so

[RFCv4 PATCH 13/13] usb: gadget: ufg: add Mass Storage Gadget adapter to UFG

2012-11-22 Thread Andrzej Pietrasiewicz
This is an example of how to create an adapter module for an old-style gadget. It provides the legacy interface while internally operates on configfs. Usage is like g_mass_storage.ko, but instead the user needs to do e.g.: insmod libcomposite.ko insmod f_mass_storage.ko (not required if request_

[RFCv4 PATCH 11/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: add configfs type

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 225 +++ 1 files changed, 225 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index

[RFCv4 PATCH 04/13] usb: gadget: example port of mass storage to UFG: storage common: change struct device to configfs entities

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/storage_common.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c index 29b9ddd..b5da774

[RFCv4 PATCH 12/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: use new function registration framework

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |4 ++ drivers/usb/gadget/Makefile |3 + drivers/usb/gadget/f_mass_storage.c | 80 +-- 3 files changed, 74 insertions(+), 13 deletions(-) d

[RFCv4 PATCH 08/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: remove unused operations

2012-11-22 Thread Andrzej Pietrasiewicz
pre_eject and post_eject are not used by anyone. Removing them. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 15 +-- drivers/usb/gadget/f_mass_storage.h | 14 -- 2 files changed, 1 insertions(+), 28 delet

[RFCv4 PATCH 09/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: change array of fsg_lun to config_group

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 60 -- drivers/usb/gadget/f_mass_storage.h |4 ++- 2 files changed, 52 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/f_mass_storage.

[RFCv4 PATCH 05/13] usb: gadget: example port of mass storage to UFG: storage common: add configfs type

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/storage_common.c | 122 +++--- 1 files changed, 97 insertions(+), 25 deletions(-) diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c index b

[RFCv4 PATCH 06/13] usb: gadget: example port of mass storage to UFG: create f_mass_storage.h and factor out code from f_mass_storage.c

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 215 +- drivers/usb/gadget/f_mass_storage.h | 110 ++ 2 files changed, 117 insertions(+), 208 deletions(-) create mode 100644 drivers/usb

[RFCv4 PATCH 10/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: split fsg_common_init

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 135 +++ drivers/usb/gadget/f_mass_storage.h |4 +- 2 files changed, 58 insertions(+), 81 deletions(-) diff --git a/drivers/usb/gadget/f_mass_storage.

[RFCv4 PATCH 07/13] usb: gadget: example port of mass storage to UFG: f_mass_storage: remove sysfs handling

2012-11-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_mass_storage.c | 112 --- 1 files changed, 0 insertions(+), 112 deletions(-) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index

[RFCv4 PATCH 00/13] Configfs integration

2012-11-22 Thread Andrzej Pietrasiewicz
Dear All, this is the fourth version of RFC regarding configfs integration into the usb gadget. This is still a work in progress. It is rebased onto 3.7-rc5 merged with Greg's latest usb-next and Felipe's latest gadget branches. It is not meant for merging yet, but rather to be discussed. The USB

Re: [PATCH] Add Product/Vendor ID for Virtenio Preon32 to cp210x USB serial driver.

2012-11-22 Thread Greg KH
On Thu, Nov 22, 2012 at 09:41:23AM +0100, Markus Becker wrote: > Hi, > > since I could not find a maintainer for cp210x in the MAINTAINERS file and > the original author did not reply/include the device ID, I am sending this > path to the linux-usb > mailing list. Thanks. In the future, you c

Re: [RFCv4 PATCH 00/13] Configfs integration

2012-11-22 Thread Michal Nazarewicz
> * Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]: >>During its lifetime, the mass storage can require creating >>lunX directories for its luns. And again, with usbf_option On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote: > You have first to detach the gadget because you can't update wh

Re: Thoughts about bandwidth management

2012-11-22 Thread Alan Stern
On Wed, 21 Nov 2012, Sarah Sharp wrote: > > The USB spec already provides for this, to some extent. Altsetting 0 > > is not supposed to contain any isochronous endpoints and should have > > minimal bandwidth requirements. Drivers ought to switch back to > > altsetting 0 when they are not using t

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Andy Green
On 11/22/12 03:54, the mail apparently from Felipe Balbi included: Hi, On Wed, Nov 21, 2012 at 06:07:57PM +0200, Roger Quadros wrote: On 11/21/2012 05:32 PM, Alan Stern wrote: On Wed, 21 Nov 2012, Roger Quadros wrote: On 11/21/2012 04:52 PM, Alan Stern wrote: On Wed, 21 Nov 2012, Felipe Bal

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-22 Thread Ming Lei
On Thu, Nov 22, 2012 at 12:51 AM, Sebastian Andrzej Siewior wrote: > On Wed, Nov 21, 2012 at 10:36:37PM +0800, Ming Lei wrote: >> On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote: >> >> status = musb_platform_init(musb); >> >> - if (status < 0) >> >> + if (status < 0) { >> >> +

[PATCH] Add Product/Vendor ID for Virtenio Preon32 to cp210x USB serial driver.

2012-11-22 Thread Markus Becker
Hi, since I could not find a maintainer for cp210x in the MAINTAINERS file and the original author did not reply/include the device ID, I am sending this path to the linux-usb mailing list. -- Markus Signed-off-by: Markus Becker --- drivers/usb/serial/cp210x.c |1 + 1 file changed, 1 in

Re: USB issue with kernel 3.6

2012-11-22 Thread Piergiorgio Sartor
On Tue, Nov 20, 2012 at 03:40:44PM -0500, Alan Stern wrote: > On Tue, 20 Nov 2012, Piergiorgio Sartor wrote: > > > This is the output of usbmod just when the problem happened: > > > > 8801232fd6c0 815566692 C Co:1:012:0 -2 0 > > 880130cd9000 815566767 S Co:1:012:0 s 23 03 0004 0001 0

Re: USB 2.0: No giveback comes for one submitted URB

2012-11-22 Thread Alan Stern
On Thu, 22 Nov 2012, naveen yadav wrote: > Hi, > > we are using 3.2.2 version of kernel. > > When Bluetooth(connected to USB 2.0) is suspended, urb->use_count > value does not become zero and eventually there is a continuous wait > in wait_event() of usb_kill_urb(). > wait_event(usb_ki

[PATCH] usb: gadget: s3c-hsotg: Fix invalid free of devm_ allocated data

2012-11-22 Thread Tushar Behera
Since hsotg object is allocated using devm_kzalloc() API, there is no need to free this explicitly. But we need to keep the release API to prevent warnings. Signed-off-by: Tushar Behera --- drivers/usb/gadget/s3c-hsotg.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] UVC: use GFP_ATOMIC under spin lock.

2012-11-22 Thread walter harms
Am 19.11.2012 22:34, schrieb Cyril Roelandt: > Found using the following semantic patch: > > @@ > @@ > spin_lock_irqsave(...); > ... when != spin_unlock_irqrestore(...); > * GFP_KERNEL > > > Signed-off-by: Cyril Roelandt > --- > drivers/usb/gadget/uvc_video.c |2 +- > 1 file changed, 1 i

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Andy Green
On 11/22/12 20:21, the mail apparently from Felipe Balbi included: Hi, On Thu, Nov 22, 2012 at 09:13:16AM +0800, Andy Green wrote: On 11/22/12 03:54, the mail apparently from Felipe Balbi included: Hi, On Wed, Nov 21, 2012 at 06:07:57PM +0200, Roger Quadros wrote: On 11/21/2012 05:32 PM, Ala

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-22 Thread Felipe Balbi
On Thu, Nov 22, 2012 at 10:20:02AM +0100, Sebastian Andrzej Siewior wrote: > On Thu, Nov 22, 2012 at 07:56:44AM +0200, Felipe Balbi wrote: > > > > /* dma address for sync dma */ > > > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > > > if (!mem) { > > > >

RE: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Andrzej Pietrasiewicz
On Thursday, November 22, 2012 3:55 PM Sebastian Andrzej Siewior wrote: > * Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: > > >Using configfs to create/configure a usb gadget requires > >providing a method to create config group for a usb function > >and a wrapper for usb_add_function. > >

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-22 Thread Felipe Balbi
Hi, On Thu, Nov 22, 2012 at 09:13:16AM +0800, Andy Green wrote: > On 11/22/12 03:54, the mail apparently from Felipe Balbi included: > >Hi, > > > >On Wed, Nov 21, 2012 at 06:07:57PM +0200, Roger Quadros wrote: > >>On 11/21/2012 05:32 PM, Alan Stern wrote: > >>>On Wed, 21 Nov 2012, Roger Quadros wr

[RFC 5/8] USB: Increase reset timeout.

2012-11-22 Thread Sarah Sharp
John's NEC 0.96 xHCI host controller needs a longer timeout for a warm reset to complete. The logs show it takes 650ms to complete the warm reset, so extend the hub reset timeout to 800ms to be on the safe side. This commit should be backported to kernels as old as 3.2, that contain the commit 75

[RFC 1/8] USB: Handle auto-transition from hot to warm reset.

2012-11-22 Thread Sarah Sharp
USB 3.0 hubs and roothubs will automatically transition a failed hot reset to a warm (BH) reset. In that case, the warm reset change bit will be set, and the link state change bit may also be set. Change hub_port_finish_reset to unconditionally clear those change bits for USB 3.0 hubs. If these

[RFC 7/8] USB: Handle warm reset failure on empty port.

2012-11-22 Thread Sarah Sharp
An empty port can transition to either Inactive or Compliance Mode if a newly connected USB 3.0 device fails to link train. In that case, we issue a warm reset. Some devices, such as John's Roseweil eusb3 enclosure, slip back into Compliance Mode after the warm reset. The current warm reset code

Re: problem with Roseweil eusb3 enclosure

2012-11-22 Thread Sarah Sharp
On Fri, Nov 16, 2012 at 09:46:38AM -0800, Sarah Sharp wrote: > On Fri, Nov 16, 2012 at 03:51:29AM -0500, cov...@ccs.covici.com wrote: > > Sorry, did not do its job -- here is the log output. > > The patch did do what I expected. When the warm reset failed, it > disabled and re-enabled the port. >

Re: [PATCH v1] USB: musb: defer probe if transceiver is not ready

2012-11-22 Thread Felipe Balbi
On Thu, Nov 22, 2012 at 09:23:22AM +0800, Ming Lei wrote: > On Thu, Nov 22, 2012 at 12:51 AM, Sebastian Andrzej Siewior > wrote: > > On Wed, Nov 21, 2012 at 10:36:37PM +0800, Ming Lei wrote: > >> On Wed, Nov 21, 2012 at 10:09 PM, Felipe Balbi wrote: > >> >> status = musb_platform_init(musb)

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-11-22 13:06:56 [+0100]: >insmod libcomposite.ko >insmod g_usb_functions.ko You should use modprobe. Atleast g_usb_functions should pull in libcomposite if requried. >echo .img > /cfg/usb-function-gadget/G1/C1/F1/MassStorage/lun0/file > >Do the similar thing to othe

Re: [RFCv4 PATCH 01/13] usb: composite: add make_group and add_function operations

2012-11-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]: >Using configfs to create/configure a usb gadget requires >providing a method to create config group for a usb function >and a wrapper for usb_add_function. > >Signed-off-by: Andrzej Pietrasiewicz >Signed-off-by: Kyungmin Park Just a side n

Re: [RFCv4 PATCH 00/13] Configfs integration

2012-11-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]: >My intention is not to add new gadgets, but to promote the use of >usb function modules, e.g. f_mass_storage.ko. finally. >I don't use the usbf_option stuff, though, for the reasons I would >like to state below. Good. In the meantime we deci

Re: [RFCv4 PATCH 13/13] usb: gadget: ufg: add Mass Storage Gadget adapter to UFG

2012-11-22 Thread Sebastian Andrzej Siewior
* Andrzej Pietrasiewicz | 2012-11-22 13:07:07 [+0100]: >This is an example of how to create an adapter module for an old-style gadget. >It provides the legacy interface while internally operates on configfs. > >Usage is like g_mass_storage.ko, but instead the user needs to do e.g.: > >insmod libco

[PATCH] usb/gadget: make NCM's global variable ndp*_opts read only

2012-11-22 Thread Sebastian Andrzej Siewior
There is ndp16_opts and ndp32_opts which are both global and only one member is ever written. This patch makes the variable read-only and moves the one member that is ever written into the private struct f_ncm. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/f_ncm.c | 18 ++

Re: [PATCH v3 0/7] support other fsl SoCs with usbmisc + small fixes

2012-11-22 Thread Alexander Shishkin
Michael Grzeschik writes: > Nearly every SoC from Freescale has this non-core usb registers. This series > adds support for more users of this driver. > > This series is based on Peter Chen's work. Its needed to merge his master > branch > before applying this series: > > https://github.com/hzpe

Re: [PATCH v6] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-11-22 Thread Marc Kleine-Budde
On 11/21/2012 08:11 AM, Olivier Sobrie wrote: > This driver provides support for several Kvaser CAN/USB devices. > Such kind of devices supports up to three CAN network interfaces. > > It has been tested with a Kvaser USB Leaf Light (one network interface) > connected to a pch_can interface. > The

[PATCH 16/29] arm: ttc_dkb: add usb support

2012-11-22 Thread Chao Xie
From: Chao Xie Signed-off-by: Chao Xie --- arch/arm/mach-mmp/ttc_dkb.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index ce55fd8..0962791 100644 --- a/arch/arm/mach-mmp/ttc_dkb.

[PATCH 10/29] usb: gadget: mv_udc: use PHY driver for udc

2012-11-22 Thread Chao Xie
From: Chao Xie It will get rid of the callbacks in pdata for phy init/shutdown Signed-off-by: Chao Xie --- drivers/usb/gadget/mv_udc.h |2 +- drivers/usb/gadget/mv_udc_core.c | 23 --- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/usb/ga

  1   2   >