The occurrences were identified through the coccinelle script at
following location.
http://www.emn.fr/z-info/coccinelle/rules/find_unsigned.cocci
Signed checks for unsigned variables are removed if it is also checked
for upper error limit. For error checks, IS_ERR_VALUE() macros is used.
Tushar
No need to check whether unsigned variable is less than 0.
CC: Jiri Kosina
CC: linux-usb@vger.kernel.org
CC: linux-in...@vger.kernel.org
Signed-off-by: Tushar Behera
---
drivers/hid/usbhid/hiddev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/usbhid/hidd
commit 392142 moved event buffer allocation out of dwc3_core_init() but
event buffer allocation uses the cached copy of hwparams to determine
the number of event buffers and the caching is done in dwc3_core_init.
So moved dwc3_cache_hwparams function before dwc3_alloc_event_buffers so
that dwc3_all
On Wed, Nov 07, 2012 at 06:36:46PM +0530, Bhavik Kothari wrote:
> Hi Greg,
>
> Our host controller sets PRC and CSC bits at the time of initialization
> even though no USB device is attached. At the time of initialization,
> hub_probe() gets called and in-turn it calls hub_activate().
> hub_activa
Hi John,
I think I have a work around for you, but it involves several patches.
Can you pull from this branch:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git -b
warm-reset-stable
Send me the dmesg with the patches applied, whether it helps or not when
you boot with the d
On Thu, 15 Nov 2012, Thomas Gleixner wrote:
> > I see. The USB code does do a reasonably large amount of work in
> > interrupt context. It doesn't have to be that way; it could be in
> > process context -- but the design of the USB subsystem requires that
> > much of the work be carried out with
I am attempting to setup a new all-in-one that uses USB 3.0. Our instrument
basically consists of a high speed hub with full speed HID device and a high
speed Ethernet device.
The HID device fails to configure with a ‘Not enough bandwidth for new device
state’ message. I am currently using Ge
On Thu, Nov 15, 2012 at 10:14:15AM -0800, Tom Carroll wrote:
> USB/keyspan maintainers -
>
> The use of an incorrect type in keyspan_port_probe results in an invalid
> access. The attached patch fixes the problem.
This has already been fixed by commit f0e3e35c904 ("USB: keyspan: fix
typo causing
On Thu, 15 Nov 2012, Alan Stern wrote:
> On Thu, 15 Nov 2012, Thomas Gleixner wrote:
>
> > > > Hmmm. Doesn't that mean there would be no benefit from using threaded
> > > > interrupt handlers?
> > >
> > > Not versus the timers. Threaded interrupt handlers are handy, if you
> > > want to be able
USB/keyspan maintainers -
The use of an incorrect type in keyspan_port_probe results in an invalid
access. The attached patch fixes the problem.
~ Tom
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 7179b0c..9ad8a06 100644
--- a/drivers/usb/serial/keyspan.c
+++
On 11/15/2012 09:56 AM, Roger Quadros wrote:
The device tree node will provide the input supply name as
a string. Use that to populate the supply_name parameter of
the regulator descriptor.
Also correct the documentation to reflect the same.
Signed-off-by: Roger Quadros
CC: Laxman Dewangan
CC
On Thu, 15 Nov 2012, Thomas Gleixner wrote:
> > > Hmmm. Doesn't that mean there would be no benefit from using threaded
> > > interrupt handlers?
> >
> > Not versus the timers. Threaded interrupt handlers are handy, if you
> > want to be able to schedule or run complex code w/o hogging the
> >
On Thu, 15 Nov 2012, Thomas Gleixner wrote:
> On Thu, 15 Nov 2012, Alan Stern wrote:
> > > > To prevent the timer handler from interfering with the threaded
> > > > handler, should the threaded handler use spin_{un}lock_bh()?
> > >
> > > _irqsave() unfortunately as the hrtimer callbacks run in ha
On Thu, 15 Nov 2012, Alan Stern wrote:
> On Thu, 15 Nov 2012, Thomas Gleixner wrote:
>
> > > I guess this amounts to the same thing as asking what happens if a
> > > device interrupt occurs while the threaded handler is running. Would
> > > the kernel then schedule the threaded handler to run a
On Thu, 15 Nov 2012, Thomas Gleixner wrote:
> > I guess this amounts to the same thing as asking what happens if a
> > device interrupt occurs while the threaded handler is running. Would
> > the kernel then schedule the threaded handler to run a second time?
> > Or is it not prepared to handle
On Thu, 15 Nov 2012, Alan Stern wrote:
> On Thu, 15 Nov 2012, Thomas Gleixner wrote:
> > The main thing is that you need a real primary handler, which runs in
> > hard interrupt context, because the USB interrupts are often shared
> > and you don't want and cannot block out the other devices while
On Thu, 15 Nov 2012, Thomas Gleixner wrote:
> > This reminds me -- it might be a good idea to start migrating the USB
> > host controller drivers to use threaded interrupts. The difficulty is
> > that I'm not sure what would be required.
>
> I had some rough go at it two years ago, but hell do
The device tree node will provide the input supply name as
a string. Use that to populate the supply_name parameter of
the regulator descriptor.
Also correct the documentation to reflect the same.
Signed-off-by: Roger Quadros
CC: Laxman Dewangan
CC: Mark Brown
---
.../bindings/regulator/fixed
Get USB Host working. On Panda, two GPIOs are used, one for
HUB/PHY reset and other for Hub power. We model them as fixed
regulators. The regulator for RESET is made to depend on regulator
for Hub power so that the Hub power is enabled by the regulator
framework before RESET is removed.
Tested on
From: Keshava Munegowda
The port1 of omap4 panda board is used in ULPI PHY mode.
The pin mux of usbhs (usbb1) port 1 is configured accordingly.
Signed-off-by: Keshava Munegowda
---
arch/arm/boot/dts/omap4-panda.dts | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
d
Provides a means for the OMAP USB host subsystem to be initialized
from Device tree. This is a first step for device tree migration where
we specify only the board specific stuff. Things like I/O address space
and interrupts are not yet specified in the device tree but can be
done as a next step.
Provides a means for the OMAP USB host subsystem to be initialized
from Device tree. This is a first step for device tree migration where
we specify only the board specific stuff. Things like I/O address space
and interrupts are not yet specified in the device tree but can be
do
The port clocks are not required to access the port registers,
they are only needed when the PORT is used. So we move the port clock
handling code to omap_tll_enable/disable().
Also get of unnecessary spinlock code in probe function and check for
missing platform data.
Signed-off-by: Roger Quadro
Every channel has a functional clock that is similarly named.
It makes sense to use a for loop to manage these clocks as OMAPs
can come with upto 3 channels.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-tll.c | 130 +---
1 files changed, 74 inser
We can just hold the pointer to the platform data instead
of creating a copy of it.
Also get rid of the unnecessary missing platform data checks
in runtime_suspend/resume. We are already checking for missing
platform data in probe.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c |
There is no such clock as utmi_p1_gfclk. It is only a clock selector
bit to select th the parent of usb_host_hs_utmi_p1_clk.
So we get rid of utmi_p1_gfclk and utmi_p2_gfclk by merging them into
usb_host_hs_utmi_p1_clk and usb_host_hs_utmi_p2_clk respectively.
CC: Benoit Cousson
Signed-off-by: Ro
Instead of enabling the USB PHY clock in the board file we
provide the PHY clock details to the driver via board platform
data so that driver code can manage the clock.
Signed-off-by: Roger Quadros
---
arch/arm/mach-omap2/board-omap4panda.c | 14 +++---
1 files changed, 3 insertions(+)
Boards like Panda require an auxiliary clock to clock the PHY
that is connected to one of the USB ports. This patch enables
board support code to provide the name and the rate of such
a clock for each of the USB ports. omap-usb-host driver can
then manage the clock.
Signed-off-by: Roger Quadros
From: Andy Green
This patch changes the management of the two GPIO for
"hub reset" (actually controls enable of ULPI PHY and hub reset) and
"hub power" (controls power to hub + eth).
Because the only connection from the ULPI PHY output is to the hub+eth
chip, there is no meaning in having the UL
We don't really need a spinlock here, so get rid of it.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c | 16
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index e5ba193..4289847 100644
--
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports
that are configured in HSIC mode.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c | 56 +-
1 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/omap-usb-
OMAPs till date can have upto 3 ports. We need to initialize
the port mode in HOSTCONFIG register for all of them.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c | 31 ---
1 files changed, 12 insertions(+), 19 deletions(-)
diff --git a/drivers/mfd/oma
For some platforms e.g. OMAP5, we cannot rely on USBHOST revision
to determine the number of ports available. In such cases we have
to rely on platform data (or FDT) to give us the right number of
ports.
Signed-off-by: Roger Quadros
---
arch/arm/mach-omap2/usb-host.c|1 +
arch/arm/pl
prevents getting clocks that don't exist on the platform.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c | 47 ---
1 files changed, 35 insertions(+), 12 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
in
All ports have similarly named port clocks so we can
bunch them into a port data structure and use for loop
to enable/disable the clocks.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c | 208 +--
1 files changed, 101 insertions(+), 107 delet
The TLL module on OMAP5 has 3 channels.
HSIC mode requires the TLL channel to be in Transparent UTMI mode.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-tll.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/o
This is a handy macro to check if the port requires the
USB TLL module or not. Use it to Enable the TLL module and manage
the clocks.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-tll.c | 20
1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/m
Just a pointer to the platform data should suffice.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-tll.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 4b7757b..d1750a4 100644
--- a/drivers/mfd
Hi,
This patchset addresses the following
- Avoid addressing clocks one by one by name and use a for loop + bunch
of cleanups.
- Get number of channels/ports dynamically either from revision register
or from platform data. Avoids getting clocks that are not present.
- Add OMAP5 and HSIC mode
On Thu, Nov 15, 2012 at 4:20 AM, Christoph Hellwig wrote:
> On Wed, Nov 14, 2012 at 05:03:22PM -0500, Jason J. Herne wrote:
>> From: "Jason J. Herne"
>>
>> Force large capacity (> 0x blocks) drives to use READ/WRITE(16)
>> instead
>> of READ/WRITE(10). Some(most/all?) USB enclosures do n
On Wed, 14 Nov 2012, Alan Stern wrote:
> On Tue, 13 Nov 2012 gre...@linuxfoundation.org wrote:
>
> > From e592c5d0b7db94b485b4a2342db041a1882b7f75 Mon Sep 17 00:00:00 2001
> > From: Greg Kroah-Hartman
> > Date: Tue, 13 Nov 2012 10:52:52 -0800
> > Subject: Revert "USB/host: Cleanup unneccessary i
On 11/15/2012 02:51 PM, Martin Fuzzey wrote:
>> This is because that series is based on Peter Chen's work. I should have
>> mentioned this in the cover-letter mail. You can merge his master branch
>> before adding my series:
>
> Ok thanks for the very rapid reply.
>
> I've now built this together
> This is because that series is based on Peter Chen's work. I should have
> mentioned this in the cover-letter mail. You can merge his master branch
> before adding my series:
Ok thanks for the very rapid reply.
I've now built this together with patch 2 "ci13xxx_imx: add 2nd and
3rd clock to sup
From: Marc Kleine-Budde
This attaches the usbmisc_ops to the of_device_id data and
makes it possible to define special functions per soc.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/chipidea/usbmisc_imx.c | 11 ---
1 file changed, 8 insertions(+
This adds mx53 as the next user of the usbmisc driver and makes it
possible to disable the overcurrent-detection of the internal phy.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/usbmisc_imx.c | 28
1 file changed, 28
From: Marc Kleine-Budde
This fixes a potential race condition where the ci13xxx_imx glue code
could be fast enough to call one of the usbmisc_ops before he got a
valid value on the static usbmisc pointer. To fix that we first set
usbmisc, then call usbmisc_set_ops().
Signed-off-by: Marc Kleine-B
This adds a post handling routine which is called after
ci13xxx_add_device was called. The first user is the mx25, which has to
disable the external-vbus-divider after the udc has started.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
.../devicetree/bindings/usb/ci13xxx-
This driver will be used for every Freescale SoC which has this misc
memory layout to control the basic usb handling. So better name this
driver, function and struct names in a more generic way.
Reported-by: Fabio Estevam
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
Cha
From: Marc Kleine-Budde
This patch adds support for a second and third clock to the usbmisc driver. On
modern freescale ARM cores like the imx51, imx53 and imx6q three clocks ("ahb",
"ipg" and "per") must be enabled in order to access the USB core.
ahb - AMBA High-Performance Bus clock domain
ip
Nearly every SoC from Freescale has this non-core usb registers. This series
adds support for more users of this driver.
This series is based on Peter Chen's work. Its needed to merge his master branch
before applying this series:
https://github.com/hzpeterchen/linux-usb.git
Thanks,
Michael
Mar
From: Marc Kleine-Budde
The probe function checks usbmisc to be NULL in the beginning. Without
this patch the can only be loaded once.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
Changes since v1:
* split previous patch into two seperate.
drivers/usb/chipidea/usbmis
On Thu, Nov 15, 2012 at 11:08:15AM +0100, Martin Fuzzey wrote:
> On Wed, Nov 14, 2012 at 12:55 PM, Michael Grzeschik
> wrote:
> > @@ -213,6 +216,15 @@ static int __devinit ci13xxx_imx_probe(struct
> > platform_device *pdev)
> > goto put_np;
> > }
> >
> > + if (usbmis
Hi,
On Wed, Nov 14, 2012 at 12:55 PM, Michael Grzeschik
wrote:
> @@ -213,6 +216,15 @@ static int __devinit ci13xxx_imx_probe(struct
> platform_device *pdev)
> goto put_np;
> }
>
> + if (usbmisc_ops && usbmisc_ops->post) {
> + ret = usbmisc_ops->post(&p
dev->pdev is NULL before `dev->pdev = pdev'; use pdev instead.
Signed-off-by: Xi Wang
---
drivers/usb/gadget/amd5536udc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index ba6f2a1..f9fa4fd 100644
---
Use &dev->pdev->dev instead of NULL.
Signed-off-by: Xi Wang
Cc: Felipe Balbi
Cc: Andrew Morton
---
drivers/usb/gadget/amd5536udc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index fc0e
On Wed, Nov 14, 2012 at 05:03:22PM -0500, Jason J. Herne wrote:
> From: "Jason J. Herne"
>
> Force large capacity (> 0x blocks) drives to use READ/WRITE(16)
> instead
> of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10)
> commands
> when a large capacity drive is ins
On 2012年11月15日 04:12, Greg KH wrote:
> On Tue, Nov 13, 2012 at 04:07:17PM +0800, Lan Tianyu wrote:
>> +for (i = 1; i <= ports; i++) {
>> +if (usb_get_hub_port_connect_type(
>> +ehci_to_hcd(ehci)->self.root_hub, i)
>> +== USB_PO
with the last detached port state file remaining , usbip reports error on
attaching. So clean up the state files on detaching.
Signed-off-by: Harvey Yang
---
drivers/staging/usbip/userspace/src/usbip_detach.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drive
58 matches
Mail list logo
