[PATCH] usb: renesas_usbhs: use devm_request_irq()

2012-10-02 Thread Kuninori Morimoto
This patch uses devm_request_irq() instead of request_irq(), and removed free_irq() from driver Signed-off-by: Kuninori Morimoto --- drivers/usb/renesas_usbhs/mod.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb/renesas_usbh

RE: [PATCH] usb: phy: tegra remove include of

2012-10-02 Thread Venu Byravarasu
> -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, October 03, 2012 4:20 AM > To: Felipe Balbi > Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux- > te...@vger.kernel.org; Stephen Warren; Venu Byravarasu > Subject: [PATCH] usb: phy: tegra r

RE: [PATCH] usb: host: tegra remove include of

2012-10-02 Thread Venu Byravarasu
> -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, October 03, 2012 4:19 AM > To: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org; linux-te...@vger.kernel.org; Stephen > Warren; Venu Byravarasu > Subject: [PATCH] usb: host: tegra remove include

Re: Linux xHCI driver problems (reset ep)

2012-10-02 Thread Yuliya T
Hi Sarah, >> 2. Clear Halt of EP > > Also note that the xHCI hardware will only allow the Reset Endpoint to > complete if the endpoint was actually halted due to a stall, babble, > transfer error, etc. It won't reset the endpoint toggles or sequence > number at arbitrary points, so we can't reset

[PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare

2012-10-02 Thread Thomas Abraham
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham --- drivers/usb/host/ohci-exynos.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.

[PATCH] usb: ehci-s5p: use clk_prepare_enable and clk_disable_unprepare

2012-10-02 Thread Thomas Abraham
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham --- drivers/usb/host/ehci-s5p.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ehci-s5p.c b/dr

[PATCH] usb: phy: tegra remove include of

2012-10-02 Thread Stephen Warren
From: Stephen Warren Almost nothing from this file is used, and the file will hopefully be deleted soon. Copy the tiny portions that are used directly into tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up our USB driver, and those cleanups will remove the need for these c

[PATCH] usb: host: tegra remove include of

2012-10-02 Thread Stephen Warren
From: Stephen Warren Almost nothing from this file is used, and the file will hopefully be deleted soon. Copy the tiny portions that are used directly into ehci-tegra.c. I believe that Venu Byravarasu is working on cleaning up our USB driver, and those cleanups will remove the need for these cons

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Sarah Sharp
On Tue, Oct 02, 2012 at 05:26:48PM -0400, Don Zickus wrote: > On Tue, Oct 02, 2012 at 12:15:46PM -0700, Sarah Sharp wrote: > > Hi Don, > > > > The WD drive arrived today, but I can't reproduce your I/O errors on > > 3.6. I didn't try with 3.5 yet. However, I did notice that the device > > really

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Don Zickus
On Tue, Oct 02, 2012 at 12:15:46PM -0700, Sarah Sharp wrote: > Hi Don, > > The WD drive arrived today, but I can't reproduce your I/O errors on > 3.6. I didn't try with 3.5 yet. However, I did notice that the device > really doesn't want to enter U1, but it will enter U2. I did update the firmw

Re: [patch 2/2] target: strlen() doesn't count the terminator

2012-10-02 Thread Nicholas A. Bellinger
On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote: > We need to take the terminator into consideration here or the last > character gets silently truncated away later. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/usb/gadget/tcm_usb_gadget.c > b/drivers/usb/gadget/tcm_usb_gadge

Re: [patch 1/2] target: remove duplicate initialization

2012-10-02 Thread Nicholas A. Bellinger
On Tue, 2012-10-02 at 11:27 +0300, Dan Carpenter wrote: > We set bAlternateSetting to zero twice. I kept the second one > (.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more > descriptive. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/usb/gadget/tcm_usb_gadget.c > b/driver

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Sarah Sharp
On Tue, Oct 02, 2012 at 03:50:45PM -0400, Alan Stern wrote: > On Tue, 2 Oct 2012, Sarah Sharp wrote: > > > --- a/include/linux/usb/ch9.h > > +++ b/include/linux/usb/ch9.h > > @@ -828,7 +828,9 @@ struct usb_ss_cap_descriptor { /* Link Power > > Management */ > > #define USB_HIGH_SPEED_OP

Re: [RFC 1/2] Convert ehci-hcd to a library

2012-10-02 Thread Alan Stern
On Tue, 2 Oct 2012, Felipe Balbi wrote: > > --- usb-3.6.orig/drivers/usb/host/ehci.h > > +++ usb-3.6/drivers/usb/host/ehci.h > > @@ -761,26 +761,73 @@ static inline u32 hc32_to_cpup (const st > > > > > > /*-*/ > > > > -#

Re: [RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Alan Stern
On Tue, 2 Oct 2012, Sarah Sharp wrote: > --- a/include/linux/usb/ch9.h > +++ b/include/linux/usb/ch9.h > @@ -828,7 +828,9 @@ struct usb_ss_cap_descriptor {/* Link Power > Management */ > #define USB_HIGH_SPEED_OPERATION (1 << 2) /* High speed operation */ > #define USB_5GBPS_OPE

[RFT] usb: Fix TX errors on devices with unsupported LPM states.

2012-10-02 Thread Sarah Sharp
Hi Don, The WD drive arrived today, but I can't reproduce your I/O errors on 3.6. I didn't try with 3.5 yet. However, I did notice that the device really doesn't want to enter U1, but it will enter U2. Can you test the following patch with your device and see if it helps? If that doesn't work,

FTDI USB-to-UART converters and tcdrain()

2012-10-02 Thread Jarkko Huijts
Hello knowledgeable people, I have a question regarding tcdrain() and kernel driver drivers/usb/serial/ftdi_sio.c (for a family of USB-to-UART converter chips from FTDI). I'm using an FT232RL and kernel 2.6.38-16. (The driver code does not seem to have changed much between that version and 3.6.)

[PATCH 6/7] usb: core: reuse kbasename()

2012-10-02 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org --- drivers/usb/core/file.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/file.c b/drivers/usb/core/file.c index e5387a4..eff9af9 100644 --- a/drivers/usb/core/f

Re: [RFC 2/2] Convert ehci-pci to a separate module

2012-10-02 Thread Felipe Balbi
Hi, On Mon, Oct 01, 2012 at 04:21:37PM -0400, Alan Stern wrote: > Felipe: > > This makes ehci-pci a separate module that depends on ehci-hcd. It's > very straightforward; the only awkward thing is the way the driver > entries have to be overridden by hand. I couldn't think of any better > way o

Re: [RFC 1/2] Convert ehci-hcd to a library

2012-10-02 Thread Felipe Balbi
Hi, On Mon, Oct 01, 2012 at 04:21:31PM -0400, Alan Stern wrote: > Felipe: > > We've been talking about this for a long time. Here at last is an > initial attempt at splitting ehci-hcd up into a library module and > multiple platform driver modules. > > The first patch is just preparation. It m

Re: [PATCH] usb: serial: ftdi_sio: option to hide selected interfaces of multiple interfaces convertes

2012-10-02 Thread Robert Ryszard Paciorek
Hi, > > Couldn't you instead do an unbind of that particular interface via sysfs? > > I can unbind only full usb device not single interfaces on devices. When I > try unbind interface I get "write error: No such device" My mistake - unbinding single interface is posibbble only in /sys/bus/usb/dri

[patch] orinoco_usb: clean up some signedness issues

2012-10-02 Thread Dan Carpenter
In ezusb_read_ltv() we had a comparison "(bufsize < 0)" which was never true because bufsize was unsigned. I looked at the implications of that. If we passed a negative number to ezusb_access_ltv() then it would be used as the size parameter of the memcpy() because that function uses min_t(int, e

[patch] WUSB: remove an unnused variable

2012-10-02 Thread Dan Carpenter
The "wusb_cap_descr_default" is never used. GCC doesn't complain about it because we have that line ".bLength = sizeof(wusb_cap_descr_default)" inside the definition itself. Clang complains though. Signed-off-by: Dan Carpenter --- It could be instead that the intent was to actually use this var

[patch 1/2] target: remove duplicate initialization

2012-10-02 Thread Dan Carpenter
We set bAlternateSetting to zero twice. I kept the second one (.bAlternateSetting = USB_G_ALT_INT_BBB) because that's more descriptive. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c index 0a83801..1ad4a69 100644 --- a/driver

[patch 2/2] target: strlen() doesn't count the terminator

2012-10-02 Thread Dan Carpenter
We need to take the terminator into consideration here or the last character gets silently truncated away later. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/gadget/tcm_usb_gadget.c b/drivers/usb/gadget/tcm_usb_gadget.c index 1ad4a69..97e68b3 100644 --- a/drivers/usb/gadget/tcm_usb_gad

[PATCH v5] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-10-02 Thread Olivier Sobrie
This driver provides support for several Kvaser CAN/USB devices. Such kind of devices supports up to three CAN network interfaces. It has been tested with a Kvaser USB Leaf Light (one network interface) connected to a pch_can interface. The firmware version of the Kvaser device was 2.5.205. List

Re: [PATCH v4] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-10-02 Thread Olivier Sobrie
Hi Marc and Wolfgang, On Sat, Sep 22, 2012 at 06:02:14PM +0200, Wolfgang Grandegger wrote: > On 09/21/2012 11:54 AM, Marc Kleine-Budde wrote: > > On 09/20/2012 07:06 AM, Olivier Sobrie wrote: > >> This driver provides support for several Kvaser CAN/USB devices. > >> Such kind of devices supports u