Virtualbox/Vmware usb device is working but on installed linux not.

2012-08-24 Thread adam ?
https://bugzilla.kernel.org/show_bug.cgi?id=46411 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4 0/9] *** ARM: Update arch-vt8500 to Devicetree ***

2012-08-24 Thread Stephen Warren
On 08/23/2012 01:35 AM, Tony Prisk wrote: > This patchset updates arch-vt8500 to devicetree and removes all the old-style > code. Support for WM8650 has also been added. > > Example dts/dtsi files are given for the three currently supported models. > > Major changes: > > GPIO code has been conve

[PATCH] usb/dwc3: Fix Pedning isoc

2012-08-24 Thread Pratyush Anand
If xfernotready is received and there is no request in request_list then PENDING flag must be set, so that next request in ep queue is executed. In case of isoc transfer, if xfornotready is alreday elapsed and even first request has not been queued to request_list, then issue END TRANSFER, so that

Re: [PATCH 5/5] usb/dwc3: fix no request in request_list when start isoc

2012-08-24 Thread Pratyush Anand
On 8/24/2012 7:01 PM, Pratyush Anand wrote: On 8/24/2012 5:10 PM, Pratyush ANAND wrote: If xfernotready is received and there is no request in request_list then PENDING flag must be set, so that next request in ep queue is executed. Although, I did not encounter PENDING in isoc testing. But,

Re: USB sound card device complains about "error -28: not enough bandwidth" only on specific PC hardware, seems not kernel specific

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, David Ranch wrote: > > It depends on what version of Windows you're running. There are > > programs freely available, but I don't have a list. Try doing a web > > search for: USB snoop windows. > > Ok.. will do. I'm finding tools like the following. Recognize any of them?

Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch pushes the iManufacturer module argument from composite into > each gadget. Once the user uses the module paramter, the string is > overwritten with the final value. Why to remove the generation of the string from those gadgets and let composite hand

Re: [PATCH 14/20] usb/gadget: push iSerialNumber into gadgets

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch pushes the iSerialNumber module argument from composite into > each gadget. Each gadgets holds a dummy strings in its "struct > usb_string" to ensure that usb_string_ids_tab() allocates a valid id. > Once the user uses the module paramter, the string

Re: USB sound card device complains about "error -28: not enough bandwidth" only on specific PC hardware, seems not kernel specific

2012-08-24 Thread David Ranch
It depends on what version of Windows you're running. There are programs freely available, but I don't have a list. Try doing a web search for: USB snoop windows. Ok.. will do. I'm finding tools like the following. Recognize any of them? SniffUSB 2.0 - XP only - Seems free -

Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > After I moved the function from the header file to the c file I see: > > | $ size drivers/usb/gadget/gadget_chips.o > | textdata bss dec hex filename > | 1048 0 01048 418 drivers/usb/gadget/gadget_chips.o > > That is almost a

Re: [PATCH 09/20] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch moves the module options idVendor, idProduct and bcdDevice > from composite.c into each gadgets. This ensures compatibility with > current gadgets and removes the global variable which brings me step > closer towards composite.c in libcomposite > > Si

Re: [PATCH 10/20] usb/gadget: use usb_string_ids_tab instead multiple usb_string_id()

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > Using usb_string_ids_tab() instead multiple calls of usb_string_id() > seems to be handy. It also allows to add string without many checks. > > Signed-off-by: Sebastian Andrzej Siewior Most definitely: Acked-by: Michal Nazarewicz -- Best regards,

Re: [PATCH 05/20] staging/ccg: make composite.c function static and remove unsused

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > The next step is to move composite.c into the library. Since the Android > gadget has its composite.c copy Silly question, what branch is the patchset based on? > this make makes sure both symbols do not > clash by making the symbols static. The unused functi

Re: [PATCH 03/20] usb/gadget: move global vars from epautoconf into struct usb_gadget

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > epautoconf has two global variables which count the endpoint number of > last assigned endpoint. > This patch removes the global variable and keeps it as per (UDC) gadget. > While here, the ifdef is removed and now the in and outpoint are > enumerated unconditio

Re: [PATCH 01/20] usb/gadget: start with libcomposite

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch aims to be simple. It removes #include usbstribgs.c line from each > gadget and creates libcomposite.ko which has only one member, that is > usbstribgs.c. > > Signed-off-by: Sebastian Andrzej Siewior Acked-by: Michal Nazarewicz -- Best regards,

Re: Scanner works on USB-2 port but not on USB-3 because of usbfs claiming the interface

2012-08-24 Thread Harald Judt
Hi, A few weeks ago I sent you debugging information for the problem described below. Now I tried again using linux-3.5.1, and the problem still exists. However, I got a new mainboard now that has Intel USB3 ports and ASM1042 USB3 ports. With both chipsets and the xhci_hcd driver I get the sa

Re: USB sound card device complains about "error -28: not enough bandwidth" only on specific PC hardware, seems not kernel specific

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, David Ranch wrote: > Hello Alan, > > > Going to high speed would undoubtedly fix your problem, but we can't > > do it if we don't know how. Is there any way for you to use your > > device with Windows, force it to high speed, and record the USB > > commands that Windows us

Re: USB sound card device complains about "error -28: not enough bandwidth" only on specific PC hardware, seems not kernel specific

2012-08-24 Thread David Ranch
Hello Alan, Going to high speed would undoubtedly fix your problem, but we can't do it if we don't know how. Is there any way for you to use your device with Windows, force it to high speed, and record the USB commands that Windows uses to do this? Sure.. I can put it on the Windows machine

Re: [PATCH 7/7 really v3] usb/gadget: remove global variable composite in composite.c

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch removes the global variable composite in composite.c. > The private data which was saved there is now passed via an additional > argument to the bind() function in struct usb_gadget_driver. > > Only the "old-style" UDC drivers have to be touched here,

Re: USB sound card device complains about "error -28: not enough bandwidth" only on specific PC hardware, seems not kernel specific

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, David Ranch wrote: > Hello Alan, > > First off, thanks for the response and sorry for the delay here.. very > busy here! > > > > The problem is caused by the ehci-hcd driver's not-so-great support > > for scheduling periodic transfers to full-speed devices. That's why >

[PATCH 12/20] usb/gadget: initialize the strings in tcm_usb_gadget properly

2012-08-24 Thread Sebastian Andrzej Siewior
I have no idea what I've been thinking while I was doing this in the first place. Now the strings are initialized properly and reported by lsusb. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/tcm_usb_gadget.c | 33 - drivers/usb/gadget/tcm_usb_

[PATCH 10/20] usb/gadget: use usb_string_ids_tab instead multiple usb_string_id()

2012-08-24 Thread Sebastian Andrzej Siewior
Using usb_string_ids_tab() instead multiple calls of usb_string_id() seems to be handy. It also allows to add string without many checks. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/acm_ms.c | 12 +++- drivers/usb/gadget/audio.c | 12 +++- drivers/usb/gad

[PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-24 Thread Sebastian Andrzej Siewior
This patch pushes the iManufacturer module argument from composite into each gadget. Once the user uses the module paramter, the string is overwritten with the final value. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/acm_ms.c |4 +++- drivers/usb/gadget/audio.c

[PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
After I moved the function from the header file to the c file I see: | $ size drivers/usb/gadget/gadget_chips.o | textdata bss dec hex filename | 1048 0 01048 418 drivers/usb/gadget/gadget_chips.o That is almost a KiB which is removed from each user. As Felipe

[PATCH 20/20] usb/libcomposite: move MODULE_VERSION to composite.c

2012-08-24 Thread Sebastian Andrzej Siewior
MODULE_VERSION and AUTHOR looks better in composite.c than in usbstrings.c so I move it there. I put David Brownell as the module Author as I belive he wrote most of it. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/composite.c |3 +++ drivers/usb/gadget/usbstring.c |1

[PATCH 19/20] usb/libcomposite: move composite.c into libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
This moves composite.c into libcomposite and updates all gadgets. Finally! Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/Makefile |3 ++- drivers/usb/gadget/acm_ms.c |2 +- drivers/usb/gadget/audio.c | 11 +-- drivers/usb/gadget/cdc2.c

[PATCH 14/20] usb/gadget: push iSerialNumber into gadgets

2012-08-24 Thread Sebastian Andrzej Siewior
This patch pushes the iSerialNumber module argument from composite into each gadget. Each gadgets holds a dummy strings in its "struct usb_string" to ensure that usb_string_ids_tab() allocates a valid id. Once the user uses the module paramter, the string is overwritten with the final value. This i

[PATCH 16/20] usb/gadgets: make sure all gadgets provide an iManufacturer string

2012-08-24 Thread Sebastian Andrzej Siewior
A few gadgets provide a harcoded string in case the module parameter was not used. If nothing is provided then composite_bind() creates a string which is based on the kernel version and UDC's name. Some gadget create the exact same sting. This patch moves the creation of the string into composite_d

[PATCH 18/20] usb/gadget: push iProduct into gadgets

2012-08-24 Thread Sebastian Andrzej Siewior
This patch pushes the iProduct module argument from composite into each gadget. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/acm_ms.c |3 ++- drivers/usb/gadget/audio.c |2 ++ drivers/usb/gadget/cdc2.c |2 ++ drivers/usb/gadget/composite.

[PATCH 17/20] usb/composite: remove unsused composite_manufacturer variable

2012-08-24 Thread Sebastian Andrzej Siewior
Since the last patch composite_manufacturer is unused because all gadgets provide a iManufacturer property so remove it. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/composite.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/usb/

[PATCH 11/20] usb/gadget: make g_printer enumerate again

2012-08-24 Thread Sebastian Andrzej Siewior
This was broken in 2e87edf49 ("usb: gadget: make g_printer use composite"). The USB-strings were not setup properly and were not used. No function was added which results in an empty USB config. While fixing this, the interface number is now auto generated and not hard coded to 0. Signed-off-by: S

[PATCH 09/20] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-24 Thread Sebastian Andrzej Siewior
This patch moves the module options idVendor, idProduct and bcdDevice from composite.c into each gadgets. This ensures compatibility with current gadgets and removes the global variable which brings me step closer towards composite.c in libcomposite Signed-off-by: Sebastian Andrzej Siewior --- d

[PATCH 05/20] staging/ccg: make composite.c function static and remove unsused

2012-08-24 Thread Sebastian Andrzej Siewior
The next step is to move composite.c into the library. Since the Android gadget has its composite.c copy this make makes sure both symbols do not clash by making the symbols static. The unused functions are removed. This patch also provides a local copy of composite.h because the prototype is now d

[PATCH 08/20] usb/gadget: make composite module options readonly only

2012-08-24 Thread Sebastian Andrzej Siewior
This is a partly revert of 4fffd6e5 ("usb: gadget: composite: make module parameters accessible at runtime"). It is not possible to change the VID or other property for a gadget right now. This change has been made for Anrdoid gadget which has this functionality in its copy of the file. This functi

[PATCH 07/20] usb/gadget: remove bufsiz from struct usb_composite_dev

2012-08-24 Thread Sebastian Andrzej Siewior
there is no read user of bufsiz, its content is available via USB_COMP_EP0_BUFSIZ. Remove it. Acked-by: Michal Nazarewicz Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/composite.c |1 - include/linux/usb/composite.h |2 -- 2 files changed, 3 deletions(-) diff --git a

[PATCH 03/20] usb/gadget: move global vars from epautoconf into struct usb_gadget

2012-08-24 Thread Sebastian Andrzej Siewior
epautoconf has two global variables which count the endpoint number of last assigned endpoint. This patch removes the global variable and keeps it as per (UDC) gadget. While here, the ifdef is removed and now the in and outpoint are enumerated unconditionally. The dwc3 for instance supports 32 endp

[PATCH 04/20] usb/libcomposite: add epautoconf.c to libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
This patch adds epautoconf.c into libcomposite and updates all gadgets. Acked-by: Michal Nazarewicz Signed-off-by: Sebastian Andrzej Siewior --- drivers/staging/ccg/ccg.c |1 - drivers/usb/gadget/Makefile |2 +- drivers/usb/gadget/acm_ms.c |1 - drivers/usb

[PATCH 06/20] usb/gadget: move USB_BUFSIZ into global composite.h

2012-08-24 Thread Sebastian Andrzej Siewior
This patch moves USB_BUFSIZ into global header file as USB_COMP_EP0_BUFSIZ. There is currently only one user (f_sourcesink) besides composite which need it. Ideally f_sourcesink would have its own ep0 buffer. Lets keep it that way it was for now. Acked-by: Michal Nazarewicz Signed-off-by: Sebasti

[PATCH 02/20] usb/libcomposite: move config.c into libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
This patch moves config.c into libcomposite and updates all gadgets. Acked-by: Michal Nazarewicz Signed-off-by: Sebastian Andrzej Siewior --- drivers/staging/ccg/ccg.c |1 - drivers/usb/gadget/Makefile |2 +- drivers/usb/gadget/acm_ms.c |1 - drivers/usb/ga

[PATCH 01/20] usb/gadget: start with libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
This patch aims to be simple. It removes #include usbstribgs.c line from each gadget and creates libcomposite.ko which has only one member, that is usbstribgs.c. Signed-off-by: Sebastian Andrzej Siewior --- drivers/staging/ccg/Kconfig |1 + drivers/staging/ccg/ccg.c |1

Re: USB sound card device complains about "error -28: not enough bandwidth" only on specific PC hardware, seems not kernel specific

2012-08-24 Thread David Ranch
[re-send dropping the HTML format to work around VGER's silly plain-text-only rule] Hello Alan, First off, thanks for the response and sorry for the delay here.. very busy here! The problem is caused by the ehci-hcd driver's not-so-great support for scheduling periodic transfers to full

Re: [PATCH 0/3]: ezusb cleanup, FX2 support, firmware downloading support

2012-08-24 Thread Greg KH
On Wed, Aug 22, 2012 at 09:26:41AM +0200, Rene Buergel wrote: > > > > - Although i removed the dependency from ezusb to usb_serial, > > > ezusb.c still resides in drivers/usb/serial. > > > Can you give me a hint, where to put it instead? > > > I would like to do that with an additional patch

[PATCH 7/7 really v3] usb/gadget: remove global variable composite in composite.c

2012-08-24 Thread Sebastian Andrzej Siewior
This patch removes the global variable composite in composite.c. The private data which was saved there is now passed via an additional argument to the bind() function in struct usb_gadget_driver. Only the "old-style" UDC drivers have to be touched here, new style are doing it right because this c

Re: [PATCH 7/7 v2] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Michal Nazarewicz
>>Sebastian Andrzej Siewior writes: >>> @@ -889,6 +887,7 @@ static int lookup_string( >>> static int get_string(struct usb_composite_dev *cdev, >>> void *buf, u16 language, int id) >>> { >>> + struct usb_composite_driver *cdriver = cdev->driver; > * Michal Nazarewicz | 2012-08

Re: [PATCH 7/7 v3] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, Sebastian Andrzej Siewior wrote: > This patch removes the global variable usb_composite_driver() in > composite.c. The private data which was saved there is now passed via > an additional argument to the bind() function in struct > usb_gadget_driver. > > Only the "old-style"

Re: [PATCH 1/9] usb/gadget: start with libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
* Alan Stern | 2012-08-23 10:15:16 [-0400]: >> --- a/drivers/usb/gadget/Kconfig >> +++ b/drivers/usb/gadget/Kconfig >> @@ -507,6 +507,16 @@ config USB_GADGET_SUPERSPEED >> # >> # USB Gadget Drivers >> # >> + >> +# composite based drivers >> +config USB_LIBCOMPOSITE >> +tristate "Lib composi

Re: [PATCH 7/7 v2] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Sebastian Andrzej Siewior
* Michal Nazarewicz | 2012-08-24 19:09:06 [+0200]: >Sebastian Andrzej Siewior writes: >> This patch removes the global variable usb_composite_driver() in > >s/()//, otherwise it looks like a function name. :) fixed in v3. >> @@ -1401,7 +1401,7 @@ static int udc_wakeup(struct usb_gadget *gadget)

[PATCH] usb: gadget: get rid of USB_GADGET_{DUAL,SUPER}SPEED

2012-08-24 Thread Michal Nazarewicz
From: Michal Nazarewicz This commit removes USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED Kconfig options. Since now kernel allows many UDC drivers to be compiled, those options may turn to no longer be valid. For instance, if someone decides to build UDC that supports super speed and UDC that

[PATCH 7/7 v3] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Sebastian Andrzej Siewior
This patch removes the global variable usb_composite_driver() in composite.c. The private data which was saved there is now passed via an additional argument to the bind() function in struct usb_gadget_driver. Only the "old-style" UDC drivers have to be touched here, new style are doing it right b

Re: [PATCH 7/7 v2] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch removes the global variable usb_composite_driver() in s/()//, otherwise it looks like a function name. :) > composite.c. The private data which was saved there is now passed via > an additional argument to the bind() function in struct > usb_gadget_

USB sound issue / status

2012-08-24 Thread Dr. Ing. Dieter Jurzitza
Hi folks, regarding the problems with my sound card (ESI Phonorama) I have an update. Using kernel 3.5.2 the error messages still show, however, the sound card isn't kicked out any more, what is a plaster and helps me but does not solve the issue as such. [432106.466106] xhci_hcd :08:00.0:

Re: usb3 writes fail with transcend rdf8 + ASMedia ASM1042 woes

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, Sami Farin wrote: > On Sun, Jul 15, 2012 at 11:14:13 -0400, Alan Stern wrote: > ... > > In past years I have found that Genesys's devices tend to be rather > > buggy. This card reader continues the tradition. Basically, although > > the firmware works reasonably well at high

RE: Potential fsg->state problem at file_storage.c

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, Chen Peter-B29397 wrote: > > > > > On Wed, Aug 15, 2012 at 09:49:55AM +, Chen Peter-B29397 wrote: > > > Hi Alan, > > Hi Peter, > > > > > One of my colleagues reports a problem that the enumeration will fail > > if > > > the storage has some problems. > > > > A silghtl

Re: [PATCH 7/7 v2] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, Sebastian Andrzej Siewior wrote: > This patch removes the global variable usb_composite_driver() in > composite.c. The private data which was saved there is now passed via > an additional argument to the bind() function in struct > usb_gadget_driver. > > Only the "old-style"

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-24 Thread Alan Stern
On Fri, 24 Aug 2012, Lan Tianyu wrote: > >> But if other places got hub descriptor, they can't get DeviceRemovable > >> value since we only set DeviceRemovable in the hub_configure().(e.g lsusb). Note: This isn't true. You now set desc->u.hs.DeviceRemovable in ehci_hub_descriptor(). > > I don'

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Yann Cantin
Hi, Le 24/08/2012 13:41, Oliver Neukum a écrit : > On Friday 24 August 2012 11:37:45 Yann Cantin wrote: >> Hi, >> >> Le 23/08/2012 09:23, Oliver Neukum a écrit : >>> On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > >>> These functions are identical. You should unify them. >> >> Removed re

Re: [PATCH 5/5] usb/dwc3: fix no request in request_list when start isoc

2012-08-24 Thread Pratyush Anand
On 8/24/2012 5:10 PM, Pratyush ANAND wrote: If xfernotready is received and there is no request in request_list then PENDING flag must be set, so that next request in ep queue is executed. Although, I did not encounter PENDING in isoc testing. But, if somebody hits it, then only this patch mi

surfstick K5006-Z in 3.6.0-rc3

2012-08-24 Thread Thomas Schäfer
short status update: Confirmation: the "qmi_wwan" works as expected. (/dev/cdc-wdm0 and wwan0 work) Missing the "option" patch for /dev/ttyUSBX for at-commands/classic ppp-connections Thomas dmesg [ 110.500114] usb 1-1: new high-speed USB device number 3 using ehci_hcd [ 110.635759] usb

[PATCH 4/5] usb/dwc3: Fix skip LINK-TRB on ISOC

2012-08-24 Thread Pratyush Anand
When we reach to link trb, we just need to increase free_slot and then calculate TRB. Return is not correct, as it will cause wrong TRB DMA address to fetch in case of update transfer. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c | 13 + 1 files changed, 5 insertions

Re: usb3 writes fail with transcend rdf8 + ASMedia ASM1042 woes

2012-08-24 Thread Sami Farin
On Sun, Jul 15, 2012 at 11:14:13 -0400, Alan Stern wrote: ... > In past years I have found that Genesys's devices tend to be rather > buggy. This card reader continues the tradition. Basically, although > the firmware works reasonably well at high speed, the SuperSpeed > support is too buggy to b

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Oliver Neukum
On Friday 24 August 2012 11:37:45 Yann Cantin wrote: > Hi, > > Le 23/08/2012 09:23, Oliver Neukum a écrit : > > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: > > These functions are identical. You should unify them. > > Removed reset_resume from the driver (optional, and not needed > fo

[PATCH 5/5] usb/dwc3: fix no request in request_list when start isoc

2012-08-24 Thread Pratyush Anand
If xfernotready is received and there is no request in request_list then PENDING flag must be set, so that next request in ep queue is executed. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3/g

[PATCH 2/5] usb/dwc3: Fix missed isoc

2012-08-24 Thread Pratyush Anand
There are two reasons to generate missed isoc. 1. when the host does not poll for all the data. 2. because of application-side delays that prevent all the data from being transferred in programmed microframe. Current code was able to handle first case only. Now we take following approach to hand

[PATCH 3/5] usb/dwc3: Fix next request to handle in case of update transfer

2012-08-24 Thread Pratyush Anand
req_queued points to the first request for which completion is still to be called. request_list points to the first request which need to be queued. dwc3_prepare_trb will change HWO from 0 to 1 for the first request of request_list. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |

[PATCH 1/5] usb/dwc3:Move udelay within stop_active_transfe

2012-08-24 Thread Pratyush Anand
We need udelay(100) after every END TRANSFER, so it is better to keep it within dwc3_stop_active_transfer. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c | 42 +- 1 files changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/usb/d

[PATCH 0/5] dwc3 fixes

2012-08-24 Thread Pratyush Anand
This fixes are mainly handling missed isoc IN request. I did not need last patch in my fixing. Still , I think fix is important. Pratyush Anand (5): usb/dwc3:Move udelay within stop_active_transfe usb/dwc3: Fix missed isoc usb/dwc3: Fix next request to handle in case of update transfer usb

Re: [PATCH] usb otg: TWL4030_USB depends on USB_MUSB_OMAP2PLUS in Kconfig

2012-08-24 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 24, 2012 at 12:57 PM, Felipe Balbi wrote: > On Thu, Aug 23, 2012 at 10:38:44PM +0200, Peter Meerwald wrote: >> Signed-off-by: Peter Meerwald > > I need a commit log explaining why we need to add this extra depend ;-) > >> --- >> drivers/usb/otg/Kconfig |2 +- >> 1 file chang

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Yann Cantin
Hi, Le 23/08/2012 09:23, Oliver Neukum a écrit : > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: >> +static int ebeam_resume(struct usb_interface *intf) >> +{ >> + struct ebeam_device *ebeam = usb_get_intfdata(intf); >> + struct input_dev *input = ebeam->input; >> + int

Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.

2012-08-24 Thread Yann Cantin
Hi, Le 23/08/2012 08:54, Oliver Neukum a écrit : > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote: >> + /* input final setup */ >> + err = input_register_device(ebeam->input); >> + if (err) { >> + dev_dbg(&intf->dev, >> + "%s - input_reg

[PATCH v2] usb otg: TWL4030_USB to depend on USB_MUSB_OMAP2PLUS in Kconfig

2012-08-24 Thread Peter Meerwald
3.6-rc2 fails to compile with CONFIG_USB_MUSB_HDRC=m CONFIG_USB_MUSB_OMAP2PLUS=m CONFIG_TWL4030_USB=y LD init/built-in.o drivers/built-in.o: In function `twl4030_usb_irq': /home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:518: undefined reference to `omap_musb_mailbox' drivers/built-i

Re: [PATCH 2/4] usb: chipidea: udc: set endpoint to undefined maxpacket size on start

2012-08-24 Thread Marc Kleine-Budde
On 08/24/2012 10:31 AM, Felipe Balbi wrote: > On Fri, Aug 24, 2012 at 10:30:54AM +0200, Marc Kleine-Budde wrote: >> On 08/24/2012 09:36 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Aug 23, 2012 at 07:30:45PM +0200, Marc Kleine-Budde wrote: From: Michael Grzeschik Non control endp

Re: [PATCH 2/4] usb: chipidea: udc: set endpoint to undefined maxpacket size on start

2012-08-24 Thread Felipe Balbi
On Fri, Aug 24, 2012 at 10:30:54AM +0200, Marc Kleine-Budde wrote: > On 08/24/2012 09:36 AM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Aug 23, 2012 at 07:30:45PM +0200, Marc Kleine-Budde wrote: > >> From: Michael Grzeschik > >> > >> Non control endpoints have an undefined maxpacket size on udc

Re: [PATCH 2/4] usb: chipidea: udc: set endpoint to undefined maxpacket size on start

2012-08-24 Thread Marc Kleine-Budde
On 08/24/2012 09:36 AM, Felipe Balbi wrote: > Hi, > > On Thu, Aug 23, 2012 at 07:30:45PM +0200, Marc Kleine-Budde wrote: >> From: Michael Grzeschik >> >> Non control endpoints have an undefined maxpacket size on udc start. Some >> gadget drivers check for the maxpacket size before they enable the

Re: [PATCH 4/4] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-08-24 Thread Marc Kleine-Budde
On 08/24/2012 09:55 AM, Felipe Balbi wrote: > On Thu, Aug 23, 2012 at 07:30:47PM +0200, Marc Kleine-Budde wrote: >> From: Michael Grzeschik >> >> Add function to physicaly enable or disable of pullup connection on the >> USB-D+ >> line. The uvc gaget will fail, if this function is not implemented

Re: [PATCH 1/4] usb: chipidea: udc: fix error path in udc_start()

2012-08-24 Thread Marc Kleine-Budde
On 08/24/2012 10:14 AM, Richard Zhao wrote: > On Thu, Aug 23, 2012 at 07:30:44PM +0200, Marc Kleine-Budde wrote: >> This patch fixes the error path of udc_start(). Now NULL is used to >> unset the peripheral with otg_set_peripheral(). >> >> Signed-off-by: Marc Kleine-Budde > Reviewed-by: Richard Z

RE: Potential fsg->state problem at file_storage.c

2012-08-24 Thread Chen Peter-B29397
> > On Wed, Aug 15, 2012 at 09:49:55AM +, Chen Peter-B29397 wrote: > > Hi Alan, > Hi Peter, > > > One of my colleagues reports a problem that the enumeration will fail > if > > the storage has some problems. > > A silghtly different question: do you think you can check if this kind of > pr

Re: [PATCH 1/4] usb: chipidea: udc: fix error path in udc_start()

2012-08-24 Thread Richard Zhao
On Thu, Aug 23, 2012 at 07:30:44PM +0200, Marc Kleine-Budde wrote: > This patch fixes the error path of udc_start(). Now NULL is used to > unset the peripheral with otg_set_peripheral(). > > Signed-off-by: Marc Kleine-Budde Reviewed-by: Richard Zhao > --- > drivers/usb/chipidea/udc.c |2 +-

Re: Potential fsg->state problem at file_storage.c

2012-08-24 Thread Sebastian Andrzej Siewior
On Wed, Aug 15, 2012 at 09:49:55AM +, Chen Peter-B29397 wrote: > Hi Alan, Hi Peter, > One of my colleagues reports a problem that the enumeration will fail if > the storage has some problems. A silghtly different question: do you think you can check if this kind of problem is also in the tcm_

Re: [PATCH 2/9] usb/libcomposite: move config.c into libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
On 08/23/2012 03:10 PM, Michal Nazarewicz wrote: Sebastian Andrzej Siewior writes: This moves config.c into libcomposite and updates all gadgets. Signed-off-by: Sebastian Andrzej Siewior Acked-by: Michal Nazarewicz btw: thank you for those acks, I'm going to pick them up unless I make chan

[PATCH 7/7 v2] usb/gadget: remove global struct usb_composite_driver in composite

2012-08-24 Thread Sebastian Andrzej Siewior
This patch removes the global variable usb_composite_driver() in composite.c. The private data which was saved there is now passed via an additional argument to the bind() function in struct usb_gadget_driver. Only the "old-style" UDC drivers have to be touched here, new style are doing it right b

Re: [PATCH 4/4] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-08-24 Thread Felipe Balbi
On Thu, Aug 23, 2012 at 07:30:47PM +0200, Marc Kleine-Budde wrote: > From: Michael Grzeschik > > Add function to physicaly enable or disable of pullup connection on the USB-D+ > line. The uvc gaget will fail, if this function is not implemented. > > Signed-off-by: Michael Grzeschik > Signed-off

Re: [PATCH 2/4] usb: chipidea: udc: set endpoint to undefined maxpacket size on start

2012-08-24 Thread Felipe Balbi
Hi, On Thu, Aug 23, 2012 at 07:30:45PM +0200, Marc Kleine-Budde wrote: > From: Michael Grzeschik > > Non control endpoints have an undefined maxpacket size on udc start. Some > gadget drivers check for the maxpacket size before they enable the endpoint, > which leads to a wrong state. > > Signe

Re: chipidea driver

2012-08-24 Thread Alexander Shishkin
Richard Zhao writes: > On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: >> Hello, Hi, >> Michael and I have a bunch of updates and improvement for the chipidea >> driver. They apply to Richard's tree: >> >> https://github.com/riczhao/kernel-imx/commits/topics/usb-driver >> >

Re: [PATCH] usb otg: TWL4030_USB depends on USB_MUSB_OMAP2PLUS in Kconfig

2012-08-24 Thread Felipe Balbi
On Thu, Aug 23, 2012 at 10:38:44PM +0200, Peter Meerwald wrote: > Signed-off-by: Peter Meerwald I need a commit log explaining why we need to add this extra depend ;-) > --- > drivers/usb/otg/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/otg/Kc

Re: linux 3.6-rc2, undefined reference to omap_musb_mailbox

2012-08-24 Thread Felipe Balbi
On Thu, Aug 23, 2012 at 10:38:59PM +0200, Peter Meerwald wrote: > On Mon, 20 Aug 2012, Felipe Balbi wrote: > > > On Mon, Aug 20, 2012 at 04:37:28PM +0530, ABRAHAM, KISHON VIJAY wrote: > > > Hi, > > > > > > On Mon, Aug 20, 2012 at 3:56 PM, Felipe Balbi wrote: > > > > On Mon, Aug 20, 2012 at 03:46