Hi,
On Thu, Aug 16, 2012 at 11:34:26AM +0530, Pratyush Anand wrote:
> May be something silly, but I am not getting it :(
>
> Probe of glue logic driver such as dwc3_exynos_probe must be called
> before core driver ie dwc3_probe.
>
> Since both drivers are called through module_init, How do we in
currently, composite.c tries to make sure all
functions will start on Alternate Setting zero when
a configuration is set.
I've been considering if that's necessary and even
correct, provided f->set_alt() will, essentially,
initialize all endpoints for that particular
interface.
This will generate
After introducing the new ->reset method on
struct usb_gadget_driver, UDC drivers are
required to implement proper handling for it.
This patch adds proper ->reset handling for
musb driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_gadget.c | 13 ++---
1 file changed, 10 inse
After introducing the new ->reset method on
struct usb_gadget_driver, UDC drivers are
required to implement proper handling for it.
This patch adds proper ->reset handling for
dwc3 driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 22 --
1 file changed, 20
Some gadget drivers might benefit from having
separate ->disconnect and ->reset notifications.
For those gadget drivers which don't care, they
can implement only ->disconnect and UDC driver
is required to call ->disconnect case ->reset
isn't valid.
Signed-off-by: Felipe Balbi
---
include/linux/
Hi,
May be something silly, but I am not getting it :(
Probe of glue logic driver such as dwc3_exynos_probe must be called
before core driver ie dwc3_probe.
Since both drivers are called through module_init, How do we insure that?
Regards
Pratyush
--
To unsubscribe from this list: send the
>
> that sounds like a plan :-) Tomorrow I can send a series of patches
> starting off the split, then people can just send in more patches for
> other controllers as we go. cheers
>
I agree with this change
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb"
On Fri, Aug 03, 2012 at 05:06:27PM +0200, René Bürgel wrote:
> Hello,
>
> this is a patches-series for controllers using the ezusb-functions.
>
> ezusb: remove dependency to usb_serial interface
> euzsb: add support for Cypress FX2LP
> ezusb: add functions for firmware download
Nice series, but
Dan Williams wrote:
>At some point you should just start adding them with
>USB_DEVICE_INTERFACE_NUMBER, no? That's cleaner than the blacklisting
>stuff IMHO, even though it does require more entries in the device
>table.
Yes, probably. I am just not sure I want to be
responsible for that
On Wed, Aug 15, 2012 at 09:59:12PM +0200, Sebastian Andrzej Siewior wrote:
> The "driver" struct for a gadget driver is named *_driver. On module
> load, the gadget expects a UDC driver to be loaded and avaiable. If this
> is not the case => -ENODEV and bye bye. That means that the gadget
> driver
This pertly reverts 07a18bd7 ("usb gadget: don't save bind callback in
struct usb_composite_driver") and fixes new drivers. The section missmatch
problems was solved by whitelisting bind callback in modpost.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/ccg/ccg.c |3
The ret variable is not initialized and therefore random. I guess the
Android compiler is doing this right :P
Cc: de...@driverdev.osuosl.org
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/ccg/ccg.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
This partly reverts 07a18bd7 ("usb gadget: don't save bind callback in
struct usb_composite_driver") and fixes new drivers. The section missmatch
problems was solved by whitelisting bind callback in modpost.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c|3 ++
I'm not going to swear here. The Android gadget includes composite.c
from the main tree and overwrites functions. This would still work if I
rename it and remove the const attribute but the problem rises again
once we stop including composite.c and use it as a library function.
Cc: de...@driverdev
The direct user of the gadget driver (composite, dbgp, inode,
file_storage) keeps a global variable where it stores a pointer to
something which identifies the "current" instance from the time calling
usb_gadget_probe_driver() and later in its ->bind() callback.
This patch passes the struct usb_gad
| drivers/usb/gadget/lpc32xx_udc.c: In function ‘isp1301_udc_configure’:
| drivers/usb/gadget/lpc32xx_udc.c:606: error: implicit declaration of function
‘i2c_smbus_write_byte_data’
| drivers/usb/gadget/lpc32xx_udc.c:665: error: implicit declaration of function
‘i2c_smbus_read_word_data’
| drivers
|drivers/usb/gadget/pxa25x_udc.h: In function 'dump_state':
|drivers/usb/gadget/pxa25x_udc.h:228:20: error: invalid type argument of '->'
(have 'struct usb_ep')
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/pxa25x_udc.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
The goal of this series is to remove a few global variables within
composite.c. In the end we wouldn't #include "composite.c" anymore but use
more as library and share across all gadgets. That is a longer way up
there, this is the first step.
The series was tested with dummy-hcd & mass-storag
The "driver" struct for a gadget driver is named *_driver. On module
load, the gadget expects a UDC driver to be loaded and avaiable. If this
is not the case => -ENODEV and bye bye. That means that the gadget
driver is initialized immediately. The initialization process includes
calling ->bind() fo
It was moved to be an argument in 07a18bd716ed5 ("usb gadget: don't
save bind callback in struct usb_composite_driver"). The reason was to
avoid the section missmatch. The warning was shown because ->bind is
marked as __init becuase it is a one time init. The warning can be also
suppresed by whitel
On 08/08/2012 07:54 PM, Tony Prisk wrote:
> This patchset updates arch-vt8500 to devicetree and removes all the old-style
> code. Support for WM8650 has also been added.
Sorry for taking such a long time to re-review this.
I scanned the series looking for just the changes to the issues I raised
o
Sebastian Andrzej Siewior writes:
> On 08/15/2012 03:38 PM, Michal Nazarewicz wrote:
>> Having said that, at the moment, FFS does not support asynch IO which
>> GFS has implemented. I have it on my TODO list but never got to
>> implementing it.
>
> sendpage() & splice() would probably do more goo
On Wed, 2012-08-15 at 15:43 +0200, Bjørn Mork wrote:
> The ZTE (Vodafone) K5006-Z use the following
> interface layout:
>
> 00 DIAG
> 01 secondary
> 02 modem
> 03 networkcard
> 04 storage
>
> Ignoring interface #3 which is handled by the qmi_wwan
> driver.
At some point you should just start add
In search of my problem with my new USB-3.0-Cardreader i found this mailiglist.
I collected some more facts about the problem reading SDHC-Cards with an
USB-3.0 cardreader:
Cardreaders:
- I have the same problem with the Transcend RDF8K
- same problem on Kingston Media Reader FCR-HS3
- same probl
The new style start/stop interface was merged in 352c2dc8b0, v3.1-rc1.
The UDC was merged in 24a28e4, v3.5-rc1. We did not want old style udcs.
Is anyone going to convert it to new style start/stop?
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
On 08/15/2012 05:18 PM, Felipe Balbi wrote:
Fair enough. We will see what we can do. In the worst case scenario, we
can keep inode.c and ccg out of the rework (continue to support the
legacy mode for those two cases for a while) and, maybe, help android
folks update their code to use configfs. Ho
On Wed, Aug 15, 2012 at 07:54:35AM -0700, Greg Kroah-Hartmann wrote:
> On Wed, Aug 15, 2012 at 05:37:50PM +0300, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Aug 15, 2012 at 06:30:20AM -0700, Greg Kroah-Hartmann wrote:
> > > On Wed, Aug 15, 2012 at 10:36:14AM +0200, Sebastian Andrzej Siewior wrote:
Hi,
On Wed, Aug 15, 2012 at 11:09:51AM -0400, Alan Stern wrote:
> > FYI, dwc3 would look like this:
> >
> > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> > index e09a7c4..723a530 100644
> > --- a/drivers/usb/dwc3/gadget.c
> > +++ b/drivers/usb/dwc3/gadget.c
> > @@ -1846,6 +
On Wed, 15 Aug 2012, Felipe Balbi wrote:
> > A better solution would be to have separate gadget driver callbacks for
> > Reset and Disconnect. Then we could do the fsg_lun_fsync_sub() only
> > during disconnect, not during reset.
> >
> > Alternatively, we could keep the single existing Disconnec
On Wed, Aug 15, 2012 at 05:37:50PM +0300, Felipe Balbi wrote:
> Hi,
>
> On Wed, Aug 15, 2012 at 06:30:20AM -0700, Greg Kroah-Hartmann wrote:
> > On Wed, Aug 15, 2012 at 10:36:14AM +0200, Sebastian Andrzej Siewior wrote:
> > > On the TODO list I read convert from sysfs to configfs. Great. That
> >
On Tue, 14 Aug 2012, Laurent Bigonville wrote:
> > But does the UPS work okay when you use the parameter? If it does,
> > the quirk information can be added to a permanent table in the usbhid
> > driver.
>
> Yes it seems to work, the userspace driver can communicate with the
> device (at least I
On Wed, Aug 15, 2012 at 10:31:27AM -0400, Alan Stern wrote:
> On Wed, 15 Aug 2012, Chen Peter-B29397 wrote:
>
> > Hi Alan,
> >
> > One of my colleagues reports a problem that the enumeration will fail if
> > the storage has some problems. I can re-produce this problem if I add a
> > big delay (li
Hi,
On Wed, Aug 15, 2012 at 06:30:20AM -0700, Greg Kroah-Hartmann wrote:
> On Wed, Aug 15, 2012 at 10:36:14AM +0200, Sebastian Andrzej Siewior wrote:
> > On the TODO list I read convert from sysfs to configfs. Great. That
> > means it should become what I suggested some time ago.
> >
> > The ccg
On Tue, 14 Aug 2012, Lan Tianyu wrote:
> hi Alan:
> Thanks for your reminder. Another question is that some hcds'(e.g xhci)
> DeviceRemovable have
> been set. They may be conflict with acpi information. How should we deal with
> the conflict?
I don't know. Let's see what Sarah thinks (wh
On Tue, 14 Aug 2012, Julia Lawall wrote:
> From: Julia Lawall
>
> Convert a possibly 0 error return code to a negative one, as returned
> elsewhere in the function.
> diff --git a/drivers/usb/host/ohci-platform.c
> b/drivers/usb/host/ohci-platform.c
> index 10d85b9..e24ec9f 100644
> --- a/driv
On Tue, 14 Aug 2012, Julia Lawall wrote:
> From: Julia Lawall
>
> Convert a possibly 0 error return code to a negative one, as returned
> elsewhere in the function.
...
> diff --git a/drivers/usb/host/ehci-platform.c
> b/drivers/usb/host/ehci-platform.c
> index 91acdde..764e010 100644
> --- a
On Thu, Aug 02, 2012 at 05:42:43PM +0530, Ravi Babu wrote:
> This series of patches adds,
> a) Multi instances support in musb driver
> b) DT support for musb_dsps glue layer
> c) DT support for NOP transceiver
>
> AM33xx and TI81xx has dual musb controller and has two usb PHY of same type.
> This
On Wed, Aug 15, 2012 at 04:27:35PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/15/2012 04:19 PM, Greg Kroah-Hartmann wrote:
> >>This does not solve all problems and provides a sysfs based interface.
> >
> >That's why it is in the staging tree, but it's also there because people
> >are using and
On Wed, 15 Aug 2012, Chen Peter-B29397 wrote:
> Hi Alan,
>
> One of my colleagues reports a problem that the enumeration will fail if
> the storage has some problems. I can re-produce this problem if I add a
> big delay (like 500ms) at handle_exception, at condition FSG_STATE_DISCONNECT,
> please
On 08/15/2012 04:19 PM, Greg Kroah-Hartmann wrote:
This does not solve all problems and provides a sysfs based interface.
That's why it is in the staging tree, but it's also there because people
are using and relying on it at the moment.
The first item on the TODO list changes the user interf
On Wed, Aug 15, 2012 at 04:10:46PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/15/2012 03:30 PM, Greg Kroah-Hartmann wrote:
> >On Wed, Aug 15, 2012 at 10:36:14AM +0200, Sebastian Andrzej Siewior wrote:
> >>On the TODO list I read convert from sysfs to configfs. Great. That
> >>means it should b
On 08/15/2012 03:38 PM, Michal Nazarewicz wrote:
At this point the cleaning lady in my woke up: May I please remove
inode.c, please? We don't need two APIs for the same thing.
Like Felipe and Alan has pointed, GFS API is not compatible with FFS
API, so just deleting it could potentially break s
On 08/15/2012 03:30 PM, Greg Kroah-Hartmann wrote:
On Wed, Aug 15, 2012 at 10:36:14AM +0200, Sebastian Andrzej Siewior wrote:
On the TODO list I read convert from sysfs to configfs. Great. That
means it should become what I suggested some time ago.
The ccg code is thight on sysfs, there is hard
On Wed, Aug 15, 2012 at 11:20:09AM +0300, Felipe Balbi wrote:
> > Based on this it looks like we are stuck with this? No cleaning lady
> > here?
>
> Either that or we keep gadgetfs out of the whole configfs rewrite and
> schedule gadgetfs for removal on v4.8 or something...
I agree, we need to ke
于 2012/8/15 21:32, Greg Kroah-Hartman 写道:
On Wed, Aug 15, 2012 at 10:29:50AM +0800, Lan Tianyu wrote:
On 2012年08月15日 08:28, Greg Kroah-Hartman wrote:
On Tue, Jul 17, 2012 at 03:28:43PM -0700, Sarah Sharp wrote:
--- a/drivers/usb/core/usb.h
+++ b/drivers/usb/core/usb.h
@@ -1,5 +1,9 @@
#includ
The ZTE (Vodafone) K5006-Z use the following
interface layout:
00 DIAG
01 secondary
02 modem
03 networkcard
04 storage
Ignoring interface #3 which is handled by the qmi_wwan
driver.
Cc: Thomas Schäfer
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |2 ++
1 file changed, 2
Newer firmware versions for the Pantech UML290 use a different
subclass ID. The Windows driver match on both IDs, so we do
that as well.
The ZTE (Vodafone) K5006-Z is a new device.
Cc: Dan Williams
Cc: Thomas Schäfer
Signed-off-by: Bjørn Mork
---
I'll prepare a backport for stable-3.4 and -3.
On Wed, Aug 15, 2012 at 10:29:50AM +0800, Lan Tianyu wrote:
> On 2012年08月15日 08:28, Greg Kroah-Hartman wrote:
> > On Tue, Jul 17, 2012 at 03:28:43PM -0700, Sarah Sharp wrote:
> >> --- a/drivers/usb/core/usb.h
> >> +++ b/drivers/usb/core/usb.h
> >> @@ -1,5 +1,9 @@
> >> #include
> >>
> >> +#ifdef
Sebastian Andrzej Siewior writes:
> So gadgetfs. Its ep0 handling can be done in kernel and some requests
> can be offloded to userland. Lets assume the host sends
> USB_REQ_SET_INTERFACE and ->usermode_setup is set. That means it returns
> with 0 (aka ACKs the request), wakes up the ep0 userland
On Wed, Aug 15, 2012 at 09:58:33AM +0800, Lan Tianyu wrote:
> On 2012年08月15日 08:27, Greg Kroah-Hartman wrote:
> > On Tue, Jul 17, 2012 at 03:28:42PM -0700, Sarah Sharp wrote:
> >> From: Lan Tianyu
> >>
> >> This patch turns each USB port on a hub into a new struct device. This
> >> new device has
On Wed, Aug 15, 2012 at 10:36:14AM +0200, Sebastian Andrzej Siewior wrote:
> On the TODO list I read convert from sysfs to configfs. Great. That
> means it should become what I suggested some time ago.
>
> The ccg code is thight on sysfs, there is hardly generic code available
> which could be reu
Dear Jiri Kosina,
> On Sun, 5 Aug 2012, Marek Vasut wrote:
> > The Freescale i.MX28 BootROM USB recovery mode implements the USB HID
> > protocol, yet the global item tag report size is 128. Linux checks if
> > this is 96 as of now, see [1]. This causes Linux to refuse to communicate
> > with this
Hi Alan,
One of my colleagues reports a problem that the enumeration will fail if
the storage has some problems. I can re-produce this problem if I add a
big delay (like 500ms) at handle_exception, at condition FSG_STATE_DISCONNECT,
please see below code:
3050 case FSG_STATE_DISCONNECT:
In case some gadget driver tries to enable an endpoint
which is already enabled, we print a nice WARN so we
can track broken gadget drivers. The only problem is that
we're printing the WARN when we already changed endpoint's
name, which would result in endpoints named as:
ep1in-bulk-bulk-bulk-bulk
On Wed, Aug 15, 2012 at 11:02:37AM +0200, Jiri Kosina wrote:
> On Tue, 14 Aug 2012, Russell King wrote:
>
> > > Actually, Henrik (added to CC) has been doing some latency improvements
> > > both for input core in general, and for HID devices as well lately. I
> > > still have his patchset in my
On Tue, 14 Aug 2012, Russell King wrote:
> > Actually, Henrik (added to CC) has been doing some latency improvements
> > both for input core in general, and for HID devices as well lately. I
> > still have his patchset in my to-review queue, as I have just came back
> > from offline vacation, b
On Sun, 5 Aug 2012, Marek Vasut wrote:
> > diff --git a/drivers/hid/usbhid/hid-quirks.c
> > b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644
> > --- a/drivers/hid/usbhid/hid-quirks.c
> > +++ b/drivers/hid/usbhid/hid-quirks.c
> > @@ -101,6 +101,7 @@ static const struct hid_blacklist
On the TODO list I read convert from sysfs to configfs. Great. That
means it should become what I suggested some time ago.
The ccg code is thight on sysfs, there is hardly generic code available
which could be reused with the configfs interface.
So can we remove ccg from staging right away? I don'
On Sun, 5 Aug 2012, Marek Vasut wrote:
> The Freescale i.MX28 BootROM USB recovery mode implements the USB HID
> protocol, yet the global item tag report size is 128. Linux checks if
> this is 96 as of now, see [1]. This causes Linux to refuse to communicate
> with this device, making it impossibl
David Miller writes:
> Ok I changed my mind and applied this to 'net'.
Thanks.
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
HI,
On Wed, Aug 15, 2012 at 10:17:46AM +0200, Sebastian Andrzej Siewior wrote:
> On 08/15/2012 08:11 AM, Felipe Balbi wrote:
> >>So gadgetfs. Its ep0 handling can be done in kernel and some requests
> >>can be offloded to userland. Lets assume the host sends
> >>USB_REQ_SET_INTERFACE and ->usermod
On 08/15/2012 08:11 AM, Felipe Balbi wrote:
So gadgetfs. Its ep0 handling can be done in kernel and some requests
can be offloded to userland. Lets assume the host sends
USB_REQ_SET_INTERFACE and ->usermode_setup is set. That means it returns
with 0 (aka ACKs the request), wakes up the ep0 userla
On Tue, Jul 10, 2012 at 10:54:44AM +0200, Andrzej Pietrasiewicz wrote:
> Dear Joel,
>
> Thank you for your review.
>
> @Sebastian, Alan, Felipe: Thank you, too.
>
> On Monday, July 02, 2012 11:09 AM Joel Becker wrote:
>
>
>
> >
> > > As a prerequisite it adds an operation to configfs. The op
63 matches
Mail list logo
