Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Ming Lei
CC guys who discussed the problem in the below link in Jan. : http://marc.info/?t=13252895602&r=10&w=2 On Fri, Jul 20, 2012 at 8:33 PM, Ming Lei wrote: > The RFC patch is just for discussing if the idea of deferring > request_firmware is doable for addressing the issue of > request_fir

[PATCH 1/2] ARM: vt8500: Update vt8500-ehci driver to support device tree.

2012-07-20 Thread Tony Prisk
Signed-off-by: Tony Prisk --- .../devicetree/bindings/usb/vt8500-ehci.txt| 10 ++ drivers/usb/host/ehci-vt8500.c |9 + 2 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt dif

[PATCHv3 2/2] ARM: vt8500: Add support for UHCI companion controller

2012-07-20 Thread Tony Prisk
Add support for a generic non-pci UHCI companion controller. Existing board files for arch-vt8500 updated to include UHCI support. Signed-off-by: Tony Prisk --- V3: Added the missing commits for the board files. arch/arm/mach-vt8500/bv07.c |1 + arch/arm/mach-vt8500/devices-vt8500

[PATCH 2/2] usb/at91udc: Don't check for ep->ep.desc

2012-07-20 Thread Sebastian Andrzej Siewior
Earlier we used to check for ep->ep.desc to figure out if this ep has already been enabled and if so, abort. Ido Shayevitz removed the usb_endpoint_descriptor from private udc structure 5a6506f00 ("usb: gadget: Update at91_udc to use usb_endpoint_descriptor inside the struct usb_ep") but did not fi

[PATCH 1/2] usb/at91udc: don't overwrite driver data

2012-07-20 Thread Sebastian Andrzej Siewior
The driver was converted to the new start/stop interface in f3d8bf34c2 ("usb: gadget: at91_udc: convert to new style start/stop interface"). I overlooked that the driver is overwritting the private data which is used by the composite framework. The udc driver doesn't read it, it is only written her

Re: [RFC PATCH for v3.5 0/2] usb: gadget: at91_udc: fix oops regression

2012-07-20 Thread Sebastian Andrzej Siewior
On Thu, Jul 19, 2012 at 03:50:19PM -0700, Greg Kroah-Hartman wrote: > > Greg: Any chance to get this two bugfixes into the current release? > > It's too late for 3.5, sorry, but patches can always be backported to > stable releases if they are causing problems. As you wish. I repost them in a few

Re: Kernel tracing options with USB subsystem

2012-07-20 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Jul 20, 2012 at 10:14:57PM +0530, Balakumar wrote: > Hi Greg, > > When it comes to embedded device cases, I feel that the options are > just left with debug messages. It becomes really difficu

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-20 Thread Sarah Sharp
On Thu, Jul 19, 2012 at 09:27:55PM +0200, Oliver Neukum wrote: > On Thursday 19 July 2012 10:42:23 Alan Stern wrote: > > > > > > 1) remote wakeup is requested > > > 2) user space has blocked it via the new sysfs attribute > > > 3) USB_QUIRK_RESET_MORPHS is set > > > > The same is true for externa

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-20 Thread Sarah Sharp
On Thu, Jul 19, 2012 at 11:42:57AM +0200, Oliver Neukum wrote: > On Thursday 19 July 2012 15:42:37 Lan Tianyu wrote: > > On 2012年07月19日 14:37, Oliver Neukum wrote: > > > > But this leaves me with a question. Has anybody ever measured the > > > additional > > > power savings compared to a suspende

Re: Kernel tracing options with USB subsystem

2012-07-20 Thread Balakumar
Hi Greg, When it comes to embedded device cases, I feel that the options are just left with debug messages. It becomes really difficult to debug some SMP specific issues, thread deadlocks etc. I felt that, using trace events, we could effectively log some of those specific data without the pen

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Ming Lei
On Fri, Jul 20, 2012 at 9:54 PM, Oliver Neukum wrote: > > The approach seems to me to be less comprehensive than > it ought to be. If you defer, why not the whole probe()? Because for other failures, we don't know when the conditions for them can be satisfied. For example, we don't know when the

Re: [PATCH] isp1362-hcd.c: usb message always saved in case of underrun

2012-07-20 Thread Greg KH
On Fri, Jul 20, 2012 at 12:26:10PM +0200, Claudio Scordino wrote: > Il 20/07/2012 00:58, Greg KH ha scritto: > >On Wed, Jul 18, 2012 at 10:53:09AM +0200, Claudio Scordino wrote: > >>Il 06/07/2012 19:41, Greg KH ha scritto: > >>>On Wed, Jun 27, 2012 at 06:01:39PM +0200, Claudio Scordino wrote: > >>>

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Oliver Neukum
On Friday 20 July 2012 20:33:32 Ming Lei wrote: > The RFC patch is just for discussing if the idea of deferring > request_firmware is doable for addressing the issue of > request_firmware in resume path, which is caused by driver > unbind/rebind during resume. > > At least usb bus is involved in s

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Borislav Petkov
On Fri, Jul 20, 2012 at 09:09:10PM +0800, Ming Lei wrote: > On Fri, Jul 20, 2012 at 9:03 PM, Borislav Petkov wrote: > > This still doesn't change the fact that SYSTEM_SUSPEND or > > SYSTEM_SUSPEND_DISK is unused. IOW, both states are unused. So why > > introduce a new state instead of simply test

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Ming Lei
On Fri, Jul 20, 2012 at 9:03 PM, Borislav Petkov wrote: > This still doesn't change the fact that SYSTEM_SUSPEND or > SYSTEM_SUSPEND_DISK is unused. IOW, both states are unused. So why > introduce a new state instead of simply test != SYSTEM_RUNNING? Because system_state is still SYSTEM_RUNNING d

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Borislav Petkov
On Fri, Jul 20, 2012 at 08:57:05PM +0800, Ming Lei wrote: > On Fri, Jul 20, 2012 at 8:52 PM, Borislav Petkov wrote: > > > This new SYSTEM_SUSPEND state is declared above and only assigned here > > to system_state without being tested anywhere. AFAICT, the only test > > you're doing is system_stat

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Ming Lei
On Fri, Jul 20, 2012 at 8:52 PM, Borislav Petkov wrote: > This new SYSTEM_SUSPEND state is declared above and only assigned here > to system_state without being tested anywhere. AFAICT, the only test > you're doing is system_state != SYSTEM_RUNNING and that works without > defining a new SYSTEM_S

Re: [RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Borislav Petkov
On Fri, Jul 20, 2012 at 08:33:32PM +0800, Ming Lei wrote: > The RFC patch is just for discussing if the idea of deferring > request_firmware is doable for addressing the issue of > request_firmware in resume path, which is caused by driver > unbind/rebind during resume. > > At least usb bus is inv

[RFC] firmware load: defer request_firmware during early boot and resume

2012-07-20 Thread Ming Lei
The RFC patch is just for discussing if the idea of deferring request_firmware is doable for addressing the issue of request_firmware in resume path, which is caused by driver unbind/rebind during resume. At least usb bus is involved in such things, one driver may be unbound and rebound in resume

Re: unneeded SubClass and Protocol entries in unusual_devs.h

2012-07-20 Thread Mason
Mason wrote: > I'm testing an embedded system, which is running a somewhat dated > (May 2009) 2.6.28.10 kernel. > > When I plug this cheap 2-GB USB drive, I get the following message: > > usb-storage: This device (058f,6387,0104 S 06 P 50) has unneeded SubClass and > Protocol entries in unusual

Re: [PATCH] isp1362-hcd.c: usb message always saved in case of underrun

2012-07-20 Thread Claudio Scordino
Il 20/07/2012 00:58, Greg KH ha scritto: On Wed, Jul 18, 2012 at 10:53:09AM +0200, Claudio Scordino wrote: Il 06/07/2012 19:41, Greg KH ha scritto: On Wed, Jun 27, 2012 at 06:01:39PM +0200, Claudio Scordino wrote: Hi Olav, please find below a patch for the isp1362-hcd.c driver to alwa

unneeded SubClass and Protocol entries in unusual_devs.h

2012-07-20 Thread Mason
Hello, I'm testing an embedded system, which is running a somewhat dated (May 2009) 2.6.28.10 kernel. When I plug this cheap 2-GB USB drive, I get the following message: hub_port_init 1 Plug in USB Port3 udev->speed: 3 usb 3-1: configuration #1 chosen from 1 choice usb-storage: This device (058f

Re: [PATCH] usb: chipidea: ci13xxx-imx: remove global struct

2012-07-20 Thread Wolfram Sang
> Actually i am touching two thing at a time in this patch, removing the > static struct and setting the flags by oftree. I will resend this patch, > together with other work, and will just leave the flags as currently > set. Yup. Might be worth splitting up this patch into two, as well. -- Pen

Re: Regarding usb 2.0 synopsys otg controller status

2012-07-20 Thread Felipe Balbi
Hi, On Wed, Jul 11, 2012 at 03:55:43PM +0530, rajeev k wrote: > Resending the mail as it fails to deliver to the mailing list. > > Hello Balbi, > > I am using synopsys usb 2.0 otg driver written by Tirumala Marri < > tma...@apm.com>. > > The driver is too bulky, and it can be modified for the

Re: [PATCH 2/2 v3] USB: dwc3-exynos: Add vbus setup function to the exynos dwc3 glue layer

2012-07-20 Thread Felipe Balbi
Hi, On Mon, Jul 16, 2012 at 11:27:39AM +0530, Vivek Gautam wrote: > This patch retrieves and configures the vbus control gpio via > the device tree. The suspend/resume callbacks will be later > modified for vbus control. > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vivek Gautam > --- >

Re: linux-next: Tree for July 17 (debugobjects: bt | btusb | usb related?)

2012-07-20 Thread Sedat Dilek
On Fri, Jul 20, 2012 at 11:47 AM, Stanislaw Gruszka wrote: > On Wed, Jul 18, 2012 at 08:06:17PM +0200, Sedat Dilek wrote: >> On Tue, Jul 17, 2012 at 7:41 AM, Stephen Rothwell >> wrote: >> > Hi all, >> > >> > Changes since 20120716: >> > >> >> Not sure what the root cause of this issue is. >> >>

Re: [PATCH 1/2 v3] USB: dwc3-exynos: Add support for device tree

2012-07-20 Thread Felipe Balbi
Hi, On Mon, Jul 16, 2012 at 11:27:38AM +0530, Vivek Gautam wrote: > This patch adds support to parse probe data for > dwc3 driver for exynos using device tree > > Signed-off-by: Praveen Paneri > Signed-off-by: Vivek Gautam > --- > drivers/usb/dwc3/dwc3-exynos.c | 22 ++ >

Re: [PATCH 0/6] USBHID: fix several suspend-related bugs

2012-07-20 Thread Jiri Kosina
On Thu, 19 Jul 2012, Alan Stern wrote: > Jiri: > > This patch series fixes several major and minor bugs in the usbhid > driver related to suspend and resume, and especially autosuspend. Alan, thanks a lot for all the fixes! Amazing how many defects have gone unnoticed for quite a long time.

Re: linux-next: Tree for July 17 (debugobjects: bt | btusb | usb related?)

2012-07-20 Thread Stanislaw Gruszka
On Wed, Jul 18, 2012 at 08:06:17PM +0200, Sedat Dilek wrote: > On Tue, Jul 17, 2012 at 7:41 AM, Stephen Rothwell > wrote: > > Hi all, > > > > Changes since 20120716: > > > > Not sure what the root cause of this issue is. > > I see the following call-trace in linux-next (next-20120717). > > [

[PATCH RESEND] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-20 Thread Keshava Munegowda
This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled "Fix OMAP EHCI suspend/resume failure (i693)" is causing the usb hub and device detection fails in beagle XM causeing NFS not functional. This affects the core retention too. The same commit logic needs to be revisted adhering to hwmod and

[PATCH RESEND] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-20 Thread Keshava Munegowda
This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled "Fix OMAP EHCI suspend/resume failure (i693)" is causing the usb hub and device detection fails in beagle XM causeing NFS not functional. This affects the core retention too. The same commit logic needs to be revisted adhering to hwmod and

RE: [PATCH 2/2] usb/at91udc: Don't check for ep->ep.desc

2012-07-20 Thread Mario Jorge Isidoro
> -Original Message- > From: Sebastian Andrzej Siewior [mailto:bige...@linutronix.de] > Sent: quinta-feira, 19 de Julho de 2012 18:11 > To: Felipe Balbi > Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; Mario Jorge Isidoro; Fabio > Porcedda; sebast...@breakpoint.cc; Sebastian Andrzej S

RE: [PATCH 1/2] usb/at91udc: don't overwrite driver data

2012-07-20 Thread Mario Jorge Isidoro
> -Original Message- > From: Sebastian Andrzej Siewior [mailto:bige...@linutronix.de] > Sent: quinta-feira, 19 de Julho de 2012 18:11 > To: Felipe Balbi > Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; Mario Jorge Isidoro; Fabio > Porcedda; sebast...@breakpoint.cc; Sebastian Andrzej Sie

Re: [RFC PATCH for v3.5 0/2] usb: gadget: at91_udc: fix oops regression

2012-07-20 Thread Fabio Porcedda
On Fri, Jul 20, 2012 at 12:50 AM, Greg Kroah-Hartman wrote: > On Thu, Jul 19, 2012 at 07:16:54PM +0200, Sebastian Andrzej Siewior wrote: >> On Thu, Jul 19, 2012 at 03:50:54PM +0200, Fabio Porcedda wrote: >> > > I would prefer to fix the bug causing the oops instead of reverting >> > > patches. >>

Re: [PATCH] hid-core : optimize in case of hidraw

2012-07-20 Thread Jiri Kosina
On Thu, 28 Jun 2012, Matthieu CASTET wrote: > When using hidraw, hid buffer can be big and take lot's of > time to process (interrupt) kernel context. > Don't try to parse report if we are only interrested in hidraw. > > Also don't prepare data for debug stuff if no debugfs file > are opened. >

Re: [PATCH v2] hidraw : fix list->buffer memleak

2012-07-20 Thread Jiri Kosina
On Thu, 28 Jun 2012, Matthieu CASTET wrote: > If we don't read fast enough hidraw device, hidraw_report_event > will cycle and we will leak list->buffer. > Also list->buffer are not free on release. > After this patch, kmemleak report nothing. > > Signed-off-by: Matthieu CASTET > --- > drivers/

Re: [PATCH 2/2] usb/at91udc: Don't check for ep->ep.desc

2012-07-20 Thread Fabio Porcedda
On Thu, Jul 19, 2012 at 7:10 PM, Sebastian Andrzej Siewior wrote: > We used earlier to check for ep->ep.desc to figure out if this ep is > already enabled and if so, abort. > Ido Shayevitz removed the usb_endpoint_descriptor from private udc > structure 5a6506f00 ("usb: gadget: Update at91_udc to

Re: [PATCH 1/2] usb/at91udc: don't overwrite driver data

2012-07-20 Thread Fabio Porcedda
On Thu, Jul 19, 2012 at 7:10 PM, Sebastian Andrzej Siewior wrote: > The driver was converted to the new start/stop interface in f3d8bf34c2 > ("usb: gadget: at91_udc: convert to new style start/stop interface"). > I overlooked that the driver is overwritting the private data which is > used by the

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-20 Thread Munegowda, Keshava
On Fri, Jul 20, 2012 at 4:25 AM, Greg KH wrote: > On Thu, Jul 19, 2012 at 03:54:05PM -0700, Greg KH wrote: >> On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: >> > > This commit 354ab8567ae3107a8cbe7

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-20 Thread Marc Kleine-Budde
On 07/20/2012 12:57 AM, Greg KH wrote: [..] >> The problem is, one half of the functions comes from the USB host >> subsystem, the other half from the USB gadget subsystem.So the driver >> can only be built into the kernel (with host+udc support) if both USB >> host and USB gadget are built in. >

[PATCH v3] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-20 Thread Marc Kleine-Budde
Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", the udc part of the chipidea driver needs the generic usb gadget helper functions. If the chipidea driver with udc support is built into the kernel and usb gadget is built a module, the linking of the kernel fails with: drivers/

[patch] USB: legousbtower.c: remove a bogus NULL check

2012-07-20 Thread Dan Carpenter
"udev" can't be NULL here. The debugging printk() makes static checkers complain when we dereference it later in the function inside the call to usb_rcvctrlpipe(). Signed-off-by: Dan Carpenter diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index a2702cb..8089479