Dmitry Baryshkov wrote:
> Hi,
>
> David Brownell wrote:
>
>> Rather than resending, please come up with a new patch resolving the
>> various issues noted previously. Including not just the locking issue
>> reported to you by lockdep ...
>
> Fixed that minors and lockdep. I thought I folded the
On Tue, Feb 12, 2008 at 03:51:22PM -0500, Alan Stern wrote:
> On Sat, 2 Feb 2008, Matthew Dharm wrote:
>
> > On Sat, Feb 02, 2008 at 05:12:29PM -0500, Alan Stern wrote:
> > > IMO this indicates we shouldn't issue any clear-halts at all unless the
> > > device actually needs it. In general it's n
On Sat, 2 Feb 2008, Matthew Dharm wrote:
> On Sat, Feb 02, 2008 at 05:12:29PM -0500, Alan Stern wrote:
> > IMO this indicates we shouldn't issue any clear-halts at all unless the
> > device actually needs it. In general it's not a good idea to do a
> > clear-halt for an endpoint that isn't actu
> > > > > Some devices claim
> > > > > to be b_host even though they have an a_connector attached to it.
> > > >
> > > > Why not just fix that bug? Remember that's Linux code.
> > >
> > > The device claiming to be b_host is not linux based.
> >
> > Wrong ... the meaning of that flag is: *THIS*
On Tue, 12 Feb 2008 19:08:30 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
> if (handle_bidir(usblp) < 0) {
> + usb_autopm_put_interface(intf);
> usblp->used = 0;
Signed-Off-By: Pete Zaitcev <[EMAIL PROTECTED]>
> What happens if I ship a binary-only program that uses *either* a GPL library
> or a custom library with the same API? "If you don't have the Frobozz-Foo
> library, you'll have to supply your own work-alike"
It depends whether it is a derived work. It doesn't matter if you paint
it green, h
Hi,
if you fail in open() you must decrement the pm counter again.
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
Regards
Oliver
--- linux-2.6/drivers/usb/class/usblp.c.alt 2008-02-11 15:25:19.0
+0100
+++ linux-2.6/drivers/usb/class/usblp.c 2008-02-1
On Sun, 10 Feb 2008 05:50:17 +0100, Marcel Holtmann said:
> go ahead and create an application that uses a GPL only library. Then
> ask a lawyer if it is okay to distribute your application in binary only
> form without making the source code available (according to the GPL).
>
> http://www.gnu.o
Am Dienstag, 12. Februar 2008 18:49:14 schrieb Greg KH:
> On Tue, Feb 12, 2008 at 06:23:13PM +0100, Oliver Neukum wrote:
> > Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> > > Heh, I haven't even posted this driver for review yet, nice catches :)
> >
> > While we are at that. In close()
On Tue, Feb 12, 2008 at 06:23:13PM +0100, Oliver Neukum wrote:
> Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> > Heh, I haven't even posted this driver for review yet, nice catches :)
>
> While we are at that. In close() you take extreme pains to kill all URBs?
> What for? You don't do
Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> Heh, I haven't even posted this driver for review yet, nice catches :)
While we are at that. In close() you take extreme pains to kill all URBs?
What for? You don't do error reporting anyway.
Regards
Oliver
-
To un
Am Dienstag, 12. Februar 2008 17:05:25 schrieb Greg KH:
> On Tue, Feb 12, 2008 at 04:04:50PM +0100, Oliver Neukum wrote:
> > Hi,
> >
> > - use kzalloc
> > - no GFP_KERNEL in interrupt
> > - kfree can take NULL
> >
> > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
>
> Heh, I haven't even poste
Greg KH wrote:
On Fri, Feb 08, 2008 at 03:03:57PM -0800, David Brownell wrote:
On Tuesday 05 February 2008, Alan Nisota wrote:
And as far as getting the vendor to fix the device, I've asked, but
they've been extremely reluctant to support Linux in the past. We'll
see what they say.
Don't pre
On Tue, Feb 12, 2008 at 04:04:50PM +0100, Oliver Neukum wrote:
> Hi,
>
> - use kzalloc
> - no GFP_KERNEL in interrupt
> - kfree can take NULL
>
> Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
Heh, I haven't even posted this driver for review yet, nice catches :)
Mind if I just merge these in
On Tue, 12 Feb 2008, Jean-Christophe Dubois wrote:
> Let's ask the question: if usbcore was detecting an endpoint with a 0
> dev->maxpacket would it reject it right away or would it pass it anyway
> trusting that the specific driver would know about this problem (buggy
> hardware is everywhere)
On Tue, 12 Feb 2008, Mauro Carvalho Chehab wrote:
> > I'm inclined to believe that the USB-IF meant the 80% limit to apply as
> > stated and the tables are wrong. As a simple example, let's consider a
> > high-speed Isochronous transfer of 3072 bytes. This actually goes on
> > the wire as three
Hi,
- use kzalloc
- no GFP_KERNEL in interrupt
- kfree can take NULL
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
Regards
Oliver
--- linux-2.6/drivers/usb/serial/spcp8x5.c.alt 2008-02-12 14:53:25.0
+0100
+++ linux-2.6/drivers/usb/serial/spcp8x5.c
On Sat, 9 Feb 2008 11:34:35 -0500 (EST)
Alan Stern <[EMAIL PROTECTED]> wrote:
> On Sat, 9 Feb 2008, David Brownell wrote:
>
> > On Friday 08 February 2008, Alan Stern wrote:
> > >
> > > > There's currently an issue with isoc transfers made by em28xx driver[1]
> > > > and
> > > > ehcd_hci. If I
On Tue, Feb 12, 2008 at 05:02:47AM -0800, David Brownell wrote:
> On Tuesday 12 February 2008, Felipe Balbi wrote:
> > On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote:
> > > On Tuesday 12 February 2008, Felipe Balbi wrote:
> > > > Some devices claim
> > > > to be b_host even though t
On Tuesday 12 February 2008, Felipe Balbi wrote:
> On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote:
> > On Tuesday 12 February 2008, Felipe Balbi wrote:
> > > Some devices claim
> > > to be b_host even though they have an a_connector attached to it.
> >
> > Why not just fix that bug
On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote:
> On Tuesday 12 February 2008, Felipe Balbi wrote:
> > Some devices claim
> > to be b_host even though they have an a_connector attached to it.
>
> Why not just fix that bug? Remember that's Linux code.
The device claiming to be b_h
On Tuesday 12 February 2008, Felipe Balbi wrote:
> Some devices claim
> to be b_host even though they have an a_connector attached to it.
Why not just fix that bug? Remember that's Linux code.
-
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [EMA
Remove the check for is_b_host upon enumerating otg devices as it
can trigger some weird behaviors on otg sessions. Some devices claim
to be b_host even though they have an a_connector attached to it.
Checking b_hnp_enable flag should be secure enough or terms of
otg compliancy.
Signed-off-by: Fe
23 matches
Mail list logo
