Re: [linux-usb-devel] [PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

2008-01-22 Thread Grant Grundler
On Tue, Jan 22, 2008 at 11:55:56PM -0700, Grant Grundler wrote: ... > > http://www.phildev.net/linux/usb-unusualdevs-notes.html > > In general, a very helpful document! Thanks! ... I read the rest of the document and explains exactly my confusion. Can you please include that document into Docum

Re: [linux-usb-devel] [PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

2008-01-22 Thread Grant Grundler
On Tue, Jan 22, 2008 at 09:27:09PM -0800, Phil Dibowitz wrote: ... > Patch looks fine to me. Let me get my tree in order (sorry, been really > swamped lately so I haven't updated in a while), make sure this diff's > nicely against the latest rc's, It's not. It's against 2.6.23. But I expect it to

Re: [linux-usb-devel] [PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

2008-01-22 Thread Phil Dibowitz
Grant Grundler wrote: > On Sat, Jan 19, 2008 at 10:11:05PM -0600, James Bottomley wrote: > ... >> Add the device to drivers/usb/storage/unusual_devs.h with >> US_FL_FIX_CAPACITY. You'll need to know it's USB ids as well for this >> file. > > James, > Thanks! Patch below (for Alan) works for me.

[PATCH] [USB]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/usb/misc/iowarrior.c |2 +- drivers/usb/mon/mon_bin.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 764696f..8010705 100644 --- a/drive

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Greg KH
On Tue, Jan 22, 2008 at 07:52:57PM +, Christian Schoenebeck wrote: > Am Dienstag, 22. Januar 2008 16:26:01 schrieben Sie: > > Um, I don't think you have explained the problem fully here. > > > > If you want to just create a random char device in the kernel, use the > > misc interface. It's inf

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Christian Schoenebeck
Am Dienstag, 22. Januar 2008 16:26:01 schrieben Sie: > Um, I don't think you have explained the problem fully here. > > If you want to just create a random char device in the kernel, use the > misc interface. It's infrastructure will automatically do the proper > stuff so that udev will create a /

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Greg KH
On Tue, Jan 22, 2008 at 02:08:41AM +, Christian Schoenebeck wrote: > Hi! > > I'm currently writing a USB driver and wonder if I just hit a limitation of > the USB framework of Linux. > > I'm using usb_register_dev() to create USB character devices under /dev. As > far as I can see it howeve

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Greg KH
On Tue, Jan 22, 2008 at 12:54:45PM +, Christian Schoenebeck wrote: > Am Dienstag, 22. Januar 2008 08:28:04 schrieben Sie: > > Am Dienstag, 22. Januar 2008 03:08:41 schrieb Christian Schoenebeck: > > > I'm using usb_register_dev() to create USB character devices under /dev. > > > As far as I can

Re: USB storage device - incorrect size

2008-01-22 Thread Alan Stern
On Tue, 22 Jan 2008, Hamish Rodda wrote: > Hi, > > My girlfriend's 1gb lexar USB memory stick stopped working today, and I was > hoping someone could advise what I could do to retrieve the non-backed up > data... > > When it is plugged in, the following is written to /var/log/messages: > > us

Re: [PATCH v2] Export suspend statistics

2008-01-22 Thread Alan Stern
On Tue, 22 Jan 2008, Oliver Neukum wrote: > Am Montag, 21. Januar 2008 22:43:25 schrieb Sarah Sharp: > > +   dev->connect_time = jiffies; > > +   dev->active_duration = -jiffies; > >  #endif > > if (root_hub)   /* Root hub always ok [and always wired] */ > > dev->au

[patch]stop abuse of intfdata in cypress_m8

2008-01-22 Thread Oliver Neukum
Hi, this driver uses usb_get_intfdata() == NULL as a test for disconnect(). You must not do that as this races with probe(). By the time you test your erstwhile interface may already be somebody else's interface. This fixes the close() method of cypress_m8 to use the recently introduced flag and u

[patch]memleak in ark3116 serial driver

2008-01-22 Thread Oliver Neukum
Hi, in an error case memory already allocated must be freed again. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Regards Oliver --- linux-2.6.24/drivers/usb/serial/ark3116.c 2008-01-18 21:57:01.0 +0100 +++ linux-2.6.24-serial_intfdata/drivers/usb/seri

[patch]more serial drivers writing after disconnect

2008-01-22 Thread Oliver Neukum
Hi, this covers the rest of the obvious cases by using the flags and locks to guard against disconnect which were introduced in the earlier patch against mos7720. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> Regards Oliver --- linux-2.6.24-serial_intfdata/drive

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Oliver Neukum
Am Dienstag, 22. Januar 2008 13:54:45 schrieb Christian Schoenebeck: > Am Dienstag, 22. Januar 2008 08:28:04 schrieben Sie: > > Am Dienstag, 22. Januar 2008 03:08:41 schrieb Christian Schoenebeck: > > > I'm using usb_register_dev() to create USB character devices under /dev. > > > As far as I can s

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Christian Schoenebeck
Am Dienstag, 22. Januar 2008 08:28:04 schrieben Sie: > Am Dienstag, 22. Januar 2008 03:08:41 schrieb Christian Schoenebeck: > > I'm using usb_register_dev() to create USB character devices under /dev. > > As far as I can see it however one can only create one device for the > > same USB interface,

USB storage device - incorrect size

2008-01-22 Thread Hamish Rodda
Hi, My girlfriend's 1gb lexar USB memory stick stopped working today, and I was hoping someone could advise what I could do to retrieve the non-backed up data... When it is plugged in, the following is written to /var/log/messages: usb 5-6: new high speed USB device using ehci_hcd and address

[PATCH]kl5kusb105 don't flush to logically disconnected devices

2008-01-22 Thread Oliver Neukum
If disconnect() is called for a logical disconnect, no more IO must be done after disconnect() returns, or the old and new drivers may conflict. This patch avoids this by using the flag and lock introduced by the earlier patch for the mos7720 driver. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]

Re: [Bugme-new] [Bug 9790] New: strange USB related problem

2008-01-22 Thread Oliver Neukum
Am Dienstag, 22. Januar 2008 09:52:00 schrieb Andrew Morton: > > On Tue, 22 Jan 2008 09:29:27 +0100 Oliver Neukum <[EMAIL PROTECTED]> wrote: > > Am Dienstag, 22. Januar 2008 00:28:57 schrieb Serge Gavrilov: > > > vuescan       D c066ce00  4972 25367      1 > > >        d8adfdb4 0046 c066ce00 c0

Re: [Bugme-new] [Bug 9790] New: strange USB related problem

2008-01-22 Thread Andrew Morton
> On Tue, 22 Jan 2008 09:29:27 +0100 Oliver Neukum <[EMAIL PROTECTED]> wrote: > Am Dienstag, 22. Januar 2008 00:28:57 schrieb Serge Gavrilov: > > vuescan       D c066ce00  4972 25367      1 > >        d8adfdb4 0046 c066ce00 c066ce00 0282 d8adfd94 c046c0f9 > > d878ac80 > >        c066ce00

Re: [PATCH v2] Export suspend statistics

2008-01-22 Thread Oliver Neukum
Am Montag, 21. Januar 2008 22:43:25 schrieb Sarah Sharp: > +   dev->connect_time = jiffies; > +   dev->active_duration = -jiffies; >  #endif > if (root_hub)   /* Root hub always ok [and always wired] */ > dev->authorized = 1; > diff --git a/include/linux/usb.h b/incl

Re: [Bugme-new] [Bug 9790] New: strange USB related problem

2008-01-22 Thread Oliver Neukum
Am Dienstag, 22. Januar 2008 00:28:57 schrieb Serge Gavrilov: > vuescan       D c066ce00  4972 25367      1 >        d8adfdb4 0046 c066ce00 c066ce00 0282 d8adfd94 c046c0f9 > d878ac80 >        c066ce00 c2071080 d8be6c70 00857e29 0282 d8adfdc4 > 00857e29 >        d8adfe24 d8a

Re: [usb-storage] PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-22 Thread Guillaume Bedot
Hello, Le dimanche 20 janvier 2008 à 11:27 +0100, Hans de Goede a écrit : > Hi all, > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > needed to makes the cardreader on various HP multifunction printers work. > > Since the performance impact is negible we set this fla

Re: multiple devices for one USB interface - possible?

2008-01-22 Thread Oliver Neukum
Am Dienstag, 22. Januar 2008 03:08:41 schrieb Christian Schoenebeck: > I'm using usb_register_dev() to create USB character devices under /dev. As > far as I can see it however one can only create one device for the same USB > interface, correct? Yes, that's a limitation. You have to use generic