Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-20 Thread Linus Torvalds
On Mon, 19 Aug 2024 at 23:26, Michael Ellerman wrote: > > Linus Torvalds writes: > > +static struct vm_special_mapping vdso_mapping = { > > + .name = "[vdso]", > > + .pages = syscall_pages; > ^ > should be , Ack. Changed here lo

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-20 Thread Rob Landley
On 8/20/24 10:31, Linus Torvalds wrote: > On Mon, 19 Aug 2024 at 23:26, Michael Ellerman wrote: >> >> Linus Torvalds writes: >> > +static struct vm_special_mapping vdso_mapping = { >> > + .name = "[vdso]", >> > + .pages = syscall_pages; >> ^ >>

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-20 Thread Linus Torvalds
On Tue, 20 Aug 2024 at 14:17, Rob Landley wrote: > > Hexagon also has &&vdso_page which I don't understand (but have a toolchain > for > somewhere to at least smoketest...) The '&&' is just a typo. It should obviously be just a single '&'. As mentioned, the only testing that patch got was a x86-

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-20 Thread Rob Landley
On 8/20/24 16:31, Linus Torvalds wrote: > On Tue, 20 Aug 2024 at 14:17, Rob Landley wrote: >> >> Hexagon also has &&vdso_page which I don't understand (but have a toolchain >> for >> somewhere to at least smoketest...) > > The '&&' is just a typo. It should obviously be just a single '&'. As > m

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-20 Thread Linus Torvalds
On Tue, 20 Aug 2024 at 14:56, Rob Landley wrote: > > Tested-by: Rob Landley Ok, here's the patch with the fixes for problems that were pointed out, and with the beginnings of a commit message. I'm going to be traveling for the next ~10 days, and while I'll have my laptop and internet, I'm unlik

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-20 Thread Andrew Morton
On Tue, 20 Aug 2024 16:14:29 -0700 Linus Torvalds wrote: > Andrew - I think this is good, but there may be other issues lurking. > Do with it as you see fit, Hey you know me, I'll merge any old thing if I think it'll help nurture newbies.