Re: [PATCH 2/2] scripts/gdb: Support getting current task struct in UML

2023-02-15 Thread Jan Kiszka
On 15.02.23 00:35, Glenn Washburn wrote: > A running x86 UML kernel reports with architecture "i386:x86-64" as > it is a sub-architecture. However, a difference with bare-metal x86 > kernels is in how it manages tasks and the current task struct. To > identify that the inferior is a UML kernel and

Re: [PATCH V1] um: Fix compilation warnings

2023-02-15 Thread Geert Uytterhoeven
Hi Srinivasarao, On Wed, Feb 15, 2023 at 6:36 AM Srinivasarao Pathipati wrote: > On 2/15/2023 3:27 AM, Richard Weinberger wrote: > > - Ursprüngliche Mail - > >> Von: "Srinivasarao Pathipati" > >> static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc) > >> { > >> -

Re: [PATCH V1] um: Fix compilation warnings

2023-02-15 Thread Johannes Berg
On Wed, 2023-02-15 at 09:07 +0100, Geert Uytterhoeven wrote: > Hi Srinivasarao, > > On Wed, Feb 15, 2023 at 6:36 AM Srinivasarao Pathipati > wrote: > > On 2/15/2023 3:27 AM, Richard Weinberger wrote: > > > - Ursprüngliche Mail - > > > > Von: "Srinivasarao Pathipati" > > > > static void s

Re: [PATCH V1] um: Fix compilation warnings

2023-02-15 Thread Johannes Berg
On Tue, 2023-02-14 at 22:57 +0100, Richard Weinberger wrote: > - Ursprüngliche Mail - > > Von: "Srinivasarao Pathipati" > > static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc) > > { > > - struct uml_pt_regs r; > > + struct uml_pt_regs *r; > > int save_errno

Re: [PATCH V1] um: Fix compilation warnings

2023-02-15 Thread Srinivasarao Pathipati
Hi Greert Uytterhoeven, On 2/15/2023 1:37 PM, Geert Uytterhoeven wrote: Hi Srinivasarao, On Wed, Feb 15, 2023 at 6:36 AM Srinivasarao Pathipati wrote: On 2/15/2023 3:27 AM, Richard Weinberger wrote: - Ursprüngliche Mail - Von: "Srinivasarao Pathipati" static void sig_handler_common

Re: [PATCH 2/2] scripts/gdb: Support getting current task struct in UML

2023-02-15 Thread Glenn Washburn
On Wed, 15 Feb 2023 08:45:20 +0100 Jan Kiszka wrote: > On 15.02.23 00:35, Glenn Washburn wrote: > > A running x86 UML kernel reports with architecture "i386:x86-64" as > > it is a sub-architecture. However, a difference with bare-metal x86 > > kernels is in how it manages tasks and the current ta

Re: [PATCH 2/2] scripts/gdb: Support getting current task struct in UML

2023-02-15 Thread Jan Kiszka
On 15.02.23 16:55, Glenn Washburn wrote: > On Wed, 15 Feb 2023 08:45:20 +0100 > Jan Kiszka wrote: > >> On 15.02.23 00:35, Glenn Washburn wrote: >>> A running x86 UML kernel reports with architecture "i386:x86-64" as >>> it is a sub-architecture. However, a difference with bare-metal x86 >>> kerne

[PATCH v2 2/2] scripts/gdb: Support getting current task struct in UML

2023-02-15 Thread Glenn Washburn
A running x86 UML kernel reports with architecture "i386:x86-64" as it is a sub-architecture. However, a difference with bare-metal x86 kernels is in how it manages tasks and the current task struct. To identify that the inferior is a UML kernel and not bare-metal, check for the existence of the UM

[PATCH v2 1/2] scripts/gdb: Correct indentation in get_current_task

2023-02-15 Thread Glenn Washburn
There is an extra space in a couple blocks in get_current_task. Though python does not care, let's make the spacing consistent. Also, format better an if expression, removing unneeded parenthesis. Signed-off-by: Glenn Washburn --- scripts/gdb/linux/cpus.py | 18 +- 1 file changed

[PATCH v2 0/2] GDB: Support getting current task struct in UML

2023-02-15 Thread Glenn Washburn
Added suggestions from Jan. Glenn Glenn Washburn (2): scripts/gdb: Correct indentation in get_current_task scripts/gdb: Support getting current task struct in UML scripts/gdb/linux/cpus.py | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) Range-diff against v1