Re: [PATCH printk v3 09/40] um: kmsg_dump: use console_is_enabled()

On Mon 2022-11-07 15:22:07, John Ogness wrote: > Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). > > Signed-off-by: John Ogness > --- > arch/um/kernel/kmsg_dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/um/kernel/kmsg_dump.c b/arch/u

Re: [PATCH printk v3 09/40] um: kmsg_dump: use console_is_enabled()

On Mon 2022-11-07 15:22:07, John Ogness wrote: > Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). > > Signed-off-by: John Ogness > --- > arch/um/kernel/kmsg_dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/um/kernel/kmsg_dump.c b/arch/u

Re: [PATCH printk v3 09/40] um: kmsg_dump: use console_is_enabled()

On Wed 2022-11-09 15:56:11, Petr Mladek wrote: > On Mon 2022-11-07 15:22:07, John Ogness wrote: > > Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). > > > > Signed-off-by: John Ogness > > --- > > arch/um/kernel/kmsg_dump.c | 2 +- > > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH printk v3 11/40] um: kmsg_dumper: use srcu console list iterator

On Mon 2022-11-07 15:22:09, John Ogness wrote: > Rather than using the console_lock to guarantee safe console list > traversal, use srcu console list iteration. It might be obvious. But I would add: "It allows to dump the messages even when console_lock() is blocked during panic()." It will help