Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Geert Uytterhoeven
On Wed, May 25, 2022 at 1:45 AM Peter Xu wrote: > I observed that for each of the shared file-backed page faults, we're very > likely to retry one more time for the 1st write fault upon no page. It's > because we'll need to release the mmap lock for dirty rate limit purpose > with balance_dirty_p

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Peter Zijlstra
On Tue, May 24, 2022 at 07:45:31PM -0400, Peter Xu wrote: > I observed that for each of the shared file-backed page faults, we're very > likely to retry one more time for the 1st write fault upon no page. It's > because we'll need to release the mmap lock for dirty rate limit purpose > with balanc

Re: [PATCH] UML: add support for KASAN under x86_64

2022-05-25 Thread Vincent Whitchurch
On Tue, May 24, 2022 at 09:35:33PM +0200, David Gow wrote: > On Tue, May 24, 2022 at 3:34 AM Vincent Whitchurch > wrote: > > It works both with and without KASAN_VMALLOC. KASAN_STACK works too > > after I disabled sanitization of the stacktrace code. All kasan kunit > > tests pass and the test_k

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Johannes Weiner
On Tue, May 24, 2022 at 07:45:31PM -0400, Peter Xu wrote: > I observed that for each of the shared file-backed page faults, we're very > likely to retry one more time for the 1st write fault upon no page. It's > because we'll need to release the mmap lock for dirty rate limit purpose > with balanc

[PATCH 0/2] um: Kconfig: Style cleanups

2022-05-25 Thread Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. Juerg Haefliger (2): um: Kconfig: Fix indentation um/drivers: Kconfig: Fix indentation arch/um/Kconfig | 2 +- arch/um/dri

[PATCH 1/2] um: Kconfig: Fix indentation

2022-05-25 Thread Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. Signed-off-by: Juerg Haefliger --- arch/um/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/Kconfig

[PATCH 2/2] um/drivers: Kconfig: Fix indentation

2022-05-25 Thread Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. Signed-off-by: Juerg Haefliger --- arch/um/drivers/Kconfig | 54 - 1 file changed, 27 insertion

[PATCH] x86/um: Kconfig: Fix indentation

2022-05-25 Thread Juerg Haefliger
The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. Signed-off-by: Juerg Haefliger --- arch/x86/um/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/a

Re: [PATCH 07/16] signal: Wake up the designated parent

2022-05-25 Thread Oleg Nesterov
On 05/24, Oleg Nesterov wrote: > > On 05/24, Oleg Nesterov wrote: > > > > I fail to understand this patch... > > > > On 05/18, Eric W. Biederman wrote: > > > > > > Today if a process is ptraced only the ptracer will ever be woken up in > > > wait > > > > and why is this wrong? > > > > > Fixes: 75b9

Re: [PATCH 05/16] ptrace: Remove dead code from __ptrace_detach

2022-05-25 Thread Oleg Nesterov
On 05/24, Oleg Nesterov wrote: > > Sorry for delay. > > On 05/18, Eric W. Biederman wrote: > > > > Ever since commit 28d838cc4dfe ("Fix ptrace self-attach rule") it has > > been impossible to attach another thread in the same thread group. > > > > Remove the code from __ptrace_detach that was tryin

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Vineet Gupta
On 5/24/22 16:45, Peter Xu wrote: I observed that for each of the shared file-backed page faults, we're very likely to retry one more time for the 1st write fault upon no page. It's because we'll need to release the mmap lock for dirty rate limit purpose with balance_dirty_pages_ratelimited()