Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Michael S. Tsirkin
On Thu, Mar 10, 2022 at 03:17:03PM +0800, Xuan Zhuo wrote: > On Thu, 10 Mar 2022 02:00:39 -0500, "Michael S. Tsirkin" > wrote: > > On Tue, Mar 08, 2022 at 08:35:01PM +0800, Xuan Zhuo wrote: > > > virtio ring supports reset. > > > > > > Queue reset is divided into several stages. > > > > > > 1. no

Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Xuan Zhuo
On Thu, 10 Mar 2022 03:07:22 -0500, "Michael S. Tsirkin" wrote: > On Thu, Mar 10, 2022 at 03:17:03PM +0800, Xuan Zhuo wrote: > > On Thu, 10 Mar 2022 02:00:39 -0500, "Michael S. Tsirkin" > > wrote: > > > On Tue, Mar 08, 2022 at 08:35:01PM +0800, Xuan Zhuo wrote: > > > > virtio ring supports rese

Re: [PATCH v7 17/26] virtio_pci: queue_reset: support VIRTIO_F_RING_RESET

2022-03-10 Thread Xuan Zhuo
On Wed, 9 Mar 2022 16:54:10 +0800, Jason Wang wrote: > > 在 2022/3/8 下午8:35, Xuan Zhuo 写道: > > This patch implements virtio pci support for QUEUE RESET. > > > > Performing reset on a queue is divided into these steps: > > > > 1. virtio_reset_vq() - notify the device to reset the queu

Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Michael S. Tsirkin
On Thu, Mar 10, 2022 at 04:14:16PM +0800, Xuan Zhuo wrote: > On Thu, 10 Mar 2022 03:07:22 -0500, "Michael S. Tsirkin" > wrote: > > On Thu, Mar 10, 2022 at 03:17:03PM +0800, Xuan Zhuo wrote: > > > On Thu, 10 Mar 2022 02:00:39 -0500, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Mar 08, 2022

Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Xuan Zhuo
On Thu, 10 Mar 2022 07:17:09 -0500, "Michael S. Tsirkin" wrote: > On Thu, Mar 10, 2022 at 04:14:16PM +0800, Xuan Zhuo wrote: > > On Thu, 10 Mar 2022 03:07:22 -0500, "Michael S. Tsirkin" > > wrote: > > > On Thu, Mar 10, 2022 at 03:17:03PM +0800, Xuan Zhuo wrote: > > > > On Thu, 10 Mar 2022 02:00

[PATCH] docs: UML: Mention telnetd for port channel

2022-03-10 Thread Vincent Whitchurch
It is not obvious from the documentation that using the "port" channel for the console requires telnetd to be installed (see port_connection() in arch/um/drivers/port_user.c). Mention this, and the fact that UML will not boot until a client connects. Signed-off-by: Vincent Whitchurch --- Docume

Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Michael S. Tsirkin
On Thu, Mar 10, 2022 at 08:33:30PM +0800, Xuan Zhuo wrote: > On Thu, 10 Mar 2022 07:17:09 -0500, "Michael S. Tsirkin" > wrote: > > On Thu, Mar 10, 2022 at 04:14:16PM +0800, Xuan Zhuo wrote: > > > On Thu, 10 Mar 2022 03:07:22 -0500, "Michael S. Tsirkin" > > > wrote: > > > > On Thu, Mar 10, 2022

Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Xuan Zhuo
On Thu, 10 Mar 2022 08:04:27 -0500, "Michael S. Tsirkin" wrote: > On Thu, Mar 10, 2022 at 08:33:30PM +0800, Xuan Zhuo wrote: > > On Thu, 10 Mar 2022 07:17:09 -0500, "Michael S. Tsirkin" > > wrote: > > > On Thu, Mar 10, 2022 at 04:14:16PM +0800, Xuan Zhuo wrote: > > > > On Thu, 10 Mar 2022 03:07

Re: [PATCH] docs: UML: Mention telnetd for port channel

2022-03-10 Thread Anton Ivanov
On 10/03/2022 12:42, Vincent Whitchurch wrote: It is not obvious from the documentation that using the "port" channel for the console requires telnetd to be installed (see port_connection() in arch/um/drivers/port_user.c). Mention this, and the fact that UML will not boot until a client conne

Re: [PATCH 0/4] um: Assorted console related fixes

2022-03-10 Thread Glenn Washburn
On Wed, 9 Mar 2022 09:35:02 +0100 (CET) Richard Weinberger wrote: > - Ursprüngliche Mail - > >> This series fixes the console exit code to make sure UML > >> undoes everything it changed on the host side. > > > > I gave this a run hoping it would fix the issues I'm seeing with the consol

Re: [PATCH v7 17/26] virtio_pci: queue_reset: support VIRTIO_F_RING_RESET

2022-03-10 Thread Jason Wang
在 2022/3/9 下午5:32, Xuan Zhuo 写道: On Wed, 9 Mar 2022 16:54:10 +0800, Jason Wang wrote: 在 2022/3/8 下午8:35, Xuan Zhuo 写道: This patch implements virtio pci support for QUEUE RESET. Performing reset on a queue is divided into these steps: 1. virtio_reset_vq() - notify the device

Re: [PATCH v7 09/26] virtio_ring: split: implement virtqueue_reset_vring_split()

2022-03-10 Thread Jason Wang
在 2022/3/10 下午12:46, Xuan Zhuo 写道: On Wed, 9 Mar 2022 15:55:44 +0800, Jason Wang wrote: 在 2022/3/8 下午8:35, Xuan Zhuo 写道: virtio ring supports reset. Queue reset is divided into several stages. 1. notify device queue reset 2. vring release 3. attach new vring 4. notify device queue re-enable

Re: [PATCH v7 17/26] virtio_pci: queue_reset: support VIRTIO_F_RING_RESET

2022-03-10 Thread Jason Wang
在 2022/3/10 下午4:20, Xuan Zhuo 写道: On Wed, 9 Mar 2022 16:54:10 +0800, Jason Wang wrote: 在 2022/3/8 下午8:35, Xuan Zhuo 写道: This patch implements virtio pci support for QUEUE RESET. Performing reset on a queue is divided into these steps: 1. virtio_reset_vq() - notify the device