Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

2025-04-15 Thread Miguel Ojeda
On Tue, Apr 15, 2025 at 9:14 PM Miguel Ojeda wrote: > > Applied to `rust-fixes` -- thanks everyone! > > [ Reworded for relative paths. - Miguel ] Also: [ Arnd explains [1] that removing the qualifier is the way forward (thanks!): Rihgt, I tried this last week when it came

Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

2025-04-15 Thread Miguel Ojeda
On Sat, Apr 12, 2025 at 2:54 AM FUJITA Tomonori wrote: > > Remove the `volatile` qualifier used with __iomem in helper functions > in io.c. These helper functions are just wrappers around the > corresponding accessors so they are unnecessary. > > This fixes the following UML build error with CONFI

Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

2025-04-15 Thread Miguel Ojeda
On Tue, Apr 15, 2025 at 6:54 PM Arnd Bergmann wrote: > > Rihgt, I tried this last week when it came up first, removing the > 'volatile' annotations in the asm-generic/io.h header and then > all the ones that caused build regressions on arm/arm64/x86 > randconfig and allmodconfig builds. This patc

Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

2025-04-15 Thread Arnd Bergmann
On Tue, Apr 15, 2025, at 18:28, Miguel Ojeda wrote: > On Sat, Apr 12, 2025 at 2:54 AM FUJITA Tomonori > wrote: >> >> /home/fujita/git/linux-rust/arch/um/include/asm/io.h:19:42: note: passing >> argument to parameter 'addr' here >>19 | static inline void iounmap(void __iomem *addr) >> |

Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

2025-04-15 Thread Miguel Ojeda
On Sat, Apr 12, 2025 at 2:54 AM FUJITA Tomonori wrote: > > Remove the `volatile` qualifier used with __iomem in helper functions > in io.c. These helper functions are just wrappers around the > corresponding accessors so they are unnecessary. > > This fixes the following UML build error with CONFI

Re: [PATCH v2] rust: helpers: Remove volatile qualifier from io helpers

2025-04-14 Thread Danilo Krummrich
On Sat, Apr 12, 2025 at 09:53:41AM +0900, FUJITA Tomonori wrote: > Remove the `volatile` qualifier used with __iomem in helper functions > in io.c. These helper functions are just wrappers around the > corresponding accessors so they are unnecessary. > > This fixes the following UML build error wi