Re: [PATCH 3/9] block: default the discard granularity to sector size

2024-01-02 Thread Christoph Hellwig
On Tue, Jan 02, 2024 at 05:11:19PM -0500, John Pittman wrote: > Hi Christoph, is there a reason you used 512 instead of SECTOR_SIZE > from include/linux/blk_types.h? Thanks! To match the logical_block_size/physical_block_size/io_min assignments just below.

Re: [PATCH 3/9] block: default the discard granularity to sector size

2024-01-02 Thread John Pittman
Hi Christoph, is there a reason you used 512 instead of SECTOR_SIZE from include/linux/blk_types.h? Thanks! On Thu, Dec 28, 2023 at 2:56 AM Christoph Hellwig wrote: > > Current the discard granularity defaults to 0 and must be initialized by > any driver that wants to support discard. Default t