Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

2025-06-19 Thread Christian Brauner
On Tue, Jun 17, 2025 at 12:08:13PM +0200, Jan Kara wrote: > On Tue 17-06-25 06:25:34, Lorenzo Stoakes wrote: > > On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote: > > > On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > > > > Since commit c84bf6dd2b83 ("mm: introduc

Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

2025-06-19 Thread Christoph Hellwig
On Tue, Jun 17, 2025 at 06:25:34AM +0100, Lorenzo Stoakes wrote: > > > Most notably, this updates the elf logic to allow for the ability to > > > execute binaries on filesystems which have the .mmap_prepare hook, but > > > additionally we update nested filesystems. > > > > Can you please give the f

Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

2025-06-19 Thread Jan Kara
On Tue 17-06-25 06:25:34, Lorenzo Stoakes wrote: > On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote: > > On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > > > callback"), the f_op->mmap() hook

Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

2025-06-19 Thread Christoph Hellwig
On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > Additionally, commit bb666b7c2707 ("mm: add mmap_prepare() compatib

Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

2025-06-19 Thread Lorenzo Stoakes
On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote: > On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > > callback"), the f_op->mmap() hook has been deprecated in favour of > > f_op->mmap_prepare(

Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

2025-06-16 Thread Kees Cook
On June 16, 2025 12:33:22 PM PDT, Lorenzo Stoakes wrote: >Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file >callback"), the f_op->mmap() hook has been deprecated in favour of >f_op->mmap_prepare(). > >Additionally, commit bb666b7c2707 ("mm: add mmap_prepare() compatibility >l