Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Qi Zheng
On 2024/12/20 22:28, Kevin Brodsky wrote: On 20/12/2024 15:16, Qi Zheng wrote: Did I miss something? My patch series is not only for cleanup, but also for fixes of UAF issue [1], so is it possible to rebase your patch series onto mine? I can post v3 ASAP. I see, yours should be merged fir

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Kevin Brodsky
On 20/12/2024 15:16, Qi Zheng wrote: >>> >>> Did I miss something? >>> >>> My patch series is not only for cleanup, but also for fixes of >>> UAF issue [1], so is it possible to rebase your patch series onto >>> mine? I can post v3 ASAP. >> >> I see, yours should be merged first then. The issue is

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Qi Zheng
On 2024/12/20 21:50, Kevin Brodsky wrote: On 20/12/2024 12:46, Qi Zheng wrote: Hi Kevin, On 2024/12/20 18:49, Kevin Brodsky wrote: [...] Qi, shall we collaborate to make our series complementary? I believe my series covers patch 2 and 4 of your series, but it goes further by covering all l

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Kevin Brodsky
On 20/12/2024 12:46, Qi Zheng wrote: > Hi Kevin, > > On 2024/12/20 18:49, Kevin Brodsky wrote: >> [...] >> >> Qi, shall we collaborate to make our series complementary? I believe my >> series covers patch 2 and 4 of your series, but it goes further by >> covering all levels and all architectures, a

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Qi Zheng
Hi Kevin, On 2024/12/20 18:49, Kevin Brodsky wrote: Hi Peter, Qi, On 19/12/2024 18:19, Peter Zijlstra wrote: On Thu, Dec 19, 2024 at 04:44:16PM +, Kevin Brodsky wrote: Besides the ptlock management at PTE/PMD level, all the pagetable_*_[cd]tor have the same implementation. Introduce commo

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-20 Thread Kevin Brodsky
Hi Peter, Qi, On 19/12/2024 18:19, Peter Zijlstra wrote: > On Thu, Dec 19, 2024 at 04:44:16PM +, Kevin Brodsky wrote: >> Besides the ptlock management at PTE/PMD level, all the >> pagetable_*_[cd]tor have the same implementation. Introduce common >> helpers for all levels to reduce the duplica

Re: [PATCH 01/10] mm: Move common parts of pagetable_*_[cd]tor to helpers

2024-12-19 Thread Peter Zijlstra
On Thu, Dec 19, 2024 at 04:44:16PM +, Kevin Brodsky wrote: > Besides the ptlock management at PTE/PMD level, all the > pagetable_*_[cd]tor have the same implementation. Introduce common > helpers for all levels to reduce the duplication. Uff, I forgot to Cc you on the discussion here, sorry!: