Re: [PATCH] um: protect VMA iteration

2022-10-18 Thread Johannes Berg
On Mon, 2022-10-17 at 15:50 +0100, Matthew Wilcox wrote: > On Mon, Oct 17, 2022 at 11:06:30AM +0200, Johannes Berg wrote: > > From: Johannes Berg > > > > Looks like this is needed now, otherwise we get RCU > > splats from lockdep. But I don't know anything about > > this code ... > > You're gett

Re: [PATCH] um: protect VMA iteration

2022-10-17 Thread Matthew Wilcox
On Mon, Oct 17, 2022 at 11:06:30AM +0200, Johannes Berg wrote: > From: Johannes Berg > > Looks like this is needed now, otherwise we get RCU > splats from lockdep. But I don't know anything about > this code ... You're getting lockdep splats now because there was no checking before. I assumed th

Re: [PATCH] um: protect VMA iteration

2022-10-17 Thread Anton Ivanov
On 17/10/2022 10:06, Johannes Berg wrote: From: Johannes Berg Looks like this is needed now, otherwise we get RCU splats from lockdep. But I don't know anything about this code ... I went through it several times a couple of years ago looking if there is a way to optimize some of the flus