Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 07:12:48PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 07:06:53 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 06:43:30PM +0800, Xuan Zhuo wrote: > > > On Thu, 20 Jun 2024 06:15:08 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Thu, Jun 20, 2024

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 07:06:53 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 06:43:30PM +0800, Xuan Zhuo wrote: > > On Thu, 20 Jun 2024 06:15:08 -0400, "Michael S. Tsirkin" > > wrote: > > > On Thu, Jun 20, 2024 at 05:20:49PM +0800, Xuan Zhuo wrote: > > > > On Thu, 20 Jun 2024 05:14

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 06:43:30PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 06:15:08 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 05:20:49PM +0800, Xuan Zhuo wrote: > > > On Thu, 20 Jun 2024 05:14:24 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Thu, Jun 20, 2024

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 06:15:08 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 05:20:49PM +0800, Xuan Zhuo wrote: > > On Thu, 20 Jun 2024 05:14:24 -0400, "Michael S. Tsirkin" > > wrote: > > > On Thu, Jun 20, 2024 at 05:00:49PM +0800, Xuan Zhuo wrote: > > > > > > @@ -226,21 +248,37 @@

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 05:20:49PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 05:14:24 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 05:00:49PM +0800, Xuan Zhuo wrote: > > > > > @@ -226,21 +248,37 @@ struct virtqueue *virtio_find_single_vq(struct > > > > > virtio_device *vd

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 05:14:24 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 05:00:49PM +0800, Xuan Zhuo wrote: > > > > @@ -226,21 +248,37 @@ struct virtqueue *virtio_find_single_vq(struct > > > > virtio_device *vdev, > > > > > > > > static inline > > > > int virtio_find_vqs(struc

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 05:00:49PM +0800, Xuan Zhuo wrote: > > > @@ -226,21 +248,37 @@ struct virtqueue *virtio_find_single_vq(struct > > > virtio_device *vdev, > > > > > > static inline > > > int virtio_find_vqs(struct virtio_device *vdev, unsigned nvqs, > > > - struct virtqueue

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 03:56:34 -0400, "Michael S. Tsirkin" wrote: > On Wed, Apr 24, 2024 at 05:15:30PM +0800, Xuan Zhuo wrote: > > Now, we pass multi parameters to find_vqs. These parameters > > may work for transport or work for vring. > > > > And find_vqs has multi implements in many places: > >

Re: [PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-06-20 Thread Michael S. Tsirkin
On Wed, Apr 24, 2024 at 05:15:30PM +0800, Xuan Zhuo wrote: > Now, we pass multi parameters to find_vqs. These parameters > may work for transport or work for vring. > > And find_vqs has multi implements in many places: > > arch/um/drivers/virtio_uml.c > drivers/platform/mellanox/mlxbf-tmfifo.c

[PATCH vhost v9 3/6] virtio: find_vqs: pass struct instead of multi parameters

2024-04-24 Thread Xuan Zhuo
Now, we pass multi parameters to find_vqs. These parameters may work for transport or work for vring. And find_vqs has multi implements in many places: arch/um/drivers/virtio_uml.c drivers/platform/mellanox/mlxbf-tmfifo.c drivers/remoteproc/remoteproc_virtio.c drivers/s390/virtio/virtio_ccw.c