Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-23 Thread Michael S. Tsirkin
On Sat, Jun 22, 2024 at 06:07:35AM +, Wang, Wei W wrote: > On Thursday, June 20, 2024 5:01 PM, Michael S. Tsirkin wrote: > > On Thu, Jun 20, 2024 at 04:39:38PM +0800, Xuan Zhuo wrote: > > > On Thu, 20 Jun 2024 04:02:45 -0400, "Michael S. Tsirkin" > > wrote: > > > > On Wed, Apr 24, 2024 at 05:1

RE: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-21 Thread Wang, Wei W
On Thursday, June 20, 2024 5:01 PM, Michael S. Tsirkin wrote: > On Thu, Jun 20, 2024 at 04:39:38PM +0800, Xuan Zhuo wrote: > > On Thu, 20 Jun 2024 04:02:45 -0400, "Michael S. Tsirkin" > wrote: > > > On Wed, Apr 24, 2024 at 05:15:29PM +0800, Xuan Zhuo wrote: > > > > commit 6457f126c888 ("virtio: su

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 07:04:08PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 07:02:42 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 06:49:08PM +0800, Xuan Zhuo wrote: > > > On Thu, 20 Jun 2024 06:01:54 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Thu, Jun 20, 2024

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 07:02:42 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 06:49:08PM +0800, Xuan Zhuo wrote: > > On Thu, 20 Jun 2024 06:01:54 -0400, "Michael S. Tsirkin" > > wrote: > > > On Thu, Jun 20, 2024 at 05:04:53PM +0800, Xuan Zhuo wrote: > > > > On Thu, 20 Jun 2024 05:01

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 06:49:08PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 06:01:54 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 05:04:53PM +0800, Xuan Zhuo wrote: > > > On Thu, 20 Jun 2024 05:01:08 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Thu, Jun 20, 2024

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 06:01:54 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 05:04:53PM +0800, Xuan Zhuo wrote: > > On Thu, 20 Jun 2024 05:01:08 -0400, "Michael S. Tsirkin" > > wrote: > > > On Thu, Jun 20, 2024 at 04:39:38PM +0800, Xuan Zhuo wrote: > > > > On Thu, 20 Jun 2024 04:02

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 05:04:53PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 05:01:08 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 04:39:38PM +0800, Xuan Zhuo wrote: > > > On Thu, 20 Jun 2024 04:02:45 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Wed, Apr 24, 2024

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 05:01:08 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 04:39:38PM +0800, Xuan Zhuo wrote: > > On Thu, 20 Jun 2024 04:02:45 -0400, "Michael S. Tsirkin" > > wrote: > > > On Wed, Apr 24, 2024 at 05:15:29PM +0800, Xuan Zhuo wrote: > > > > commit 6457f126c888 ("vir

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Michael S. Tsirkin
On Thu, Jun 20, 2024 at 04:39:38PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 04:02:45 -0400, "Michael S. Tsirkin" > wrote: > > On Wed, Apr 24, 2024 at 05:15:29PM +0800, Xuan Zhuo wrote: > > > commit 6457f126c888 ("virtio: support reserved vqs") introduced this > > > support. Multiqueue virtio

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 04:02:45 -0400, "Michael S. Tsirkin" wrote: > On Wed, Apr 24, 2024 at 05:15:29PM +0800, Xuan Zhuo wrote: > > commit 6457f126c888 ("virtio: support reserved vqs") introduced this > > support. Multiqueue virtio-net use 2N as ctrl vq finally, so the logic > > doesn't apply. And n

Re: [PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-06-20 Thread Michael S. Tsirkin
On Wed, Apr 24, 2024 at 05:15:29PM +0800, Xuan Zhuo wrote: > commit 6457f126c888 ("virtio: support reserved vqs") introduced this > support. Multiqueue virtio-net use 2N as ctrl vq finally, so the logic > doesn't apply. And not one uses this. > > On the other side, that makes some trouble for us t

[PATCH vhost v9 2/6] virtio: remove support for names array entries being null.

2024-04-24 Thread Xuan Zhuo
commit 6457f126c888 ("virtio: support reserved vqs") introduced this support. Multiqueue virtio-net use 2N as ctrl vq finally, so the logic doesn't apply. And not one uses this. On the other side, that makes some trouble for us to refactor the find_vqs() params. So I remove this support. Signed-