Re: [PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops

2024-01-31 Thread Xuan Zhuo
On Wed, 31 Jan 2024 17:12:22 +0800, Jason Wang wrote: > On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote: > > > > In the functions vring_unmap_one_split and > > vring_unmap_one_split_indirect, > > multiple checks are made whether unmap is performed and whether it is > > INDIRECT. > > > > These two

Re: [PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops

2024-01-31 Thread Jason Wang
On Wed, Jan 31, 2024 at 5:43 PM Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2024 at 05:12:22PM +0800, Jason Wang wrote: > > I post a patch to store flags unconditionally at: > > > > https://lore.kernel.org/all/20220224122655-mutt-send-email-...@kernel.org/ > > what happened to it btw? Haven't g

Re: [PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops

2024-01-31 Thread Michael S. Tsirkin
On Wed, Jan 31, 2024 at 05:12:22PM +0800, Jason Wang wrote: > I post a patch to store flags unconditionally at: > > https://lore.kernel.org/all/20220224122655-mutt-send-email-...@kernel.org/ what happened to it btw? -- MST

Re: [PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops

2024-01-31 Thread Jason Wang
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote: > > In the functions vring_unmap_one_split and > vring_unmap_one_split_indirect, > multiple checks are made whether unmap is performed and whether it is > INDIRECT. > > These two functions are usually called in a loop, and we should put the > check

[PATCH vhost 04/17] virtio_ring: split: remove double check of the unmap ops

2024-01-30 Thread Xuan Zhuo
In the functions vring_unmap_one_split and vring_unmap_one_split_indirect, multiple checks are made whether unmap is performed and whether it is INDIRECT. These two functions are usually called in a loop, and we should put the check outside the loop. And we unmap the descs with VRING_DESC_F_INDIR