Re: [PATCH vhost 02/17] virtio_ring: packed: remove double check of the unmap ops

2024-01-31 Thread Xuan Zhuo
On Wed, 31 Jan 2024 17:12:19 +0800, Jason Wang wrote: > On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote: > > > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > > multiple checks are made whether unmap is performed and whether it is > > INDIRECT. > > > > These two functio

Re: [PATCH vhost 02/17] virtio_ring: packed: remove double check of the unmap ops

2024-01-31 Thread Jason Wang
On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo wrote: > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > multiple checks are made whether unmap is performed and whether it is > INDIRECT. > > These two functions are usually called in a loop, and we should put the > check outsid

[PATCH vhost 02/17] virtio_ring: packed: remove double check of the unmap ops

2024-01-30 Thread Xuan Zhuo
In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, multiple checks are made whether unmap is performed and whether it is INDIRECT. These two functions are usually called in a loop, and we should put the check outside the loop. And we unmap the descs with VRING_DESC_F_INDIRECT