Re: [PATCH v9] um: Enable preemption in UML

2024-07-01 Thread Anton Ivanov
On 01/07/2024 17:35, Johannes Berg wrote: On Mon, 2024-07-01 at 17:56 +0200, Johannes Berg wrote: Hmm. I also see a ton of this: BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1525 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 538, name: chan-switch.sh pr

Re: [PATCH v9] um: Enable preemption in UML

2024-07-01 Thread Anton Ivanov
On 01/07/2024 20:09, Johannes Berg wrote: On Mon, 2024-07-01 at 19:55 +0100, Anton Ivanov wrote: As Benjamin pointed out we no longer need this, so we can junk this patch at this point. If there will be any need to save/restore FPU in kernel context, I will revisit it. I think we still want/nee

Re: [PATCH v9] um: Enable preemption in UML

2024-07-01 Thread Johannes Berg
On Mon, 2024-07-01 at 19:55 +0100, Anton Ivanov wrote: > > > As Benjamin pointed out we no longer need this, so we can junk this > patch at this point. If there will be any need to save/restore FPU in > kernel context, I will revisit it. I think we still want/need the parts with the preempt_dis

Re: [PATCH v9] um: Enable preemption in UML

2024-07-01 Thread Johannes Berg
On Mon, 2024-07-01 at 17:56 +0200, Johannes Berg wrote: > Hmm. I also see a ton of this: > > BUG: sleeping function called from invalid context at > kernel/locking/rwsem.c:1525 > in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 538, name: > chan-switch.sh > preempt_count: 2, expected: 0 >

Re: [PATCH v9] um: Enable preemption in UML

2024-07-01 Thread Johannes Berg
Hmm. I also see a ton of this: BUG: sleeping function called from invalid context at kernel/locking/rwsem.c:1525 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 538, name: chan-switch.sh preempt_count: 2, expected: 0 RCU nest depth: 0, expected: 0 no locks held by chan-switch.sh/538. irq e

Re: [PATCH v9] um: Enable preemption in UML

2024-07-01 Thread Johannes Berg
> arch/um/Kconfig | 2 +- > arch/um/include/asm/fpu/api.h | 9 ++-- > arch/um/include/asm/thread_info.h | 4 +- > arch/um/kernel/Makefile | 4 ++ > arch/um/kernel/fpu.c | 71 +++ > arch/um/kernel/irq.c | 2

Re: [PATCH v9] um: Enable preemption in UML

2024-04-21 Thread Benjamin Berg
Hi, On Sat, 2024-04-20 at 13:22 +0100, Anton Ivanov wrote: > On 19/04/2024 14:47, Benjamin Berg wrote: > > Hi, > > > > On Wed, 2024-04-03 at 07:27 +0100, anton.iva...@cambridgegreys.com > > wrote: > > > From: Anton Ivanov > > > > > > 1. Preemption requires saving/restoring FPU state. This patch

Re: [PATCH v9] um: Enable preemption in UML

2024-04-20 Thread Anton Ivanov
On 19/04/2024 14:47, Benjamin Berg wrote: Hi, On Wed, 2024-04-03 at 07:27 +0100, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov 1. Preemption requires saving/restoring FPU state. This patch adds support for it using GCC intrinsics as well as appropriate storage space in the thread

Re: [PATCH v9] um: Enable preemption in UML

2024-04-19 Thread Benjamin Berg
Hi, On Wed, 2024-04-03 at 07:27 +0100, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > 1. Preemption requires saving/restoring FPU state. This patch > adds support for it using GCC intrinsics as well as appropriate > storage space in the thread structure. We reuse the space > whi

[PATCH v9] um: Enable preemption in UML

2024-04-02 Thread anton . ivanov
From: Anton Ivanov 1. Preemption requires saving/restoring FPU state. This patch adds support for it using GCC intrinsics as well as appropriate storage space in the thread structure. We reuse the space which is already allocated for the userspace threads in the thread_info structure. 2. irq cri