RE: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-06 Thread David Laight
From: Richard Henderson > Sent: 03 October 2024 17:47 > > On 9/30/24 06:23, Julian Vetter wrote: > > +void memset_io(volatile void __iomem *dst, int c, size_t count) > > +{ > > + uintptr_t qc = (u8)c; > > Missed one change to 'long' > > > + > > + qc |= qc << 8; > > + qc |= qc << 16; > > +

Re: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-03 Thread Richard Henderson
On 9/30/24 06:23, Julian Vetter wrote: +void memset_io(volatile void __iomem *dst, int c, size_t count) +{ + uintptr_t qc = (u8)c; Missed one change to 'long' + + qc |= qc << 8; + qc |= qc << 16; + +#ifdef CONFIG_64BIT + qc |= qc << 32; +#endif Could be 'qc *= -1ul /

Re: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-02 Thread kernel test robot
kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core patch link: https://lore.kernel.org/r/20240930132321.2785718-2-jvetter%40kalrayinc.com patch subject: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c config: powerpc-allnoconfig (https://download.01.org/0day-

[PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c

2024-09-30 Thread Julian Vetter
Various architectures have almost the same implementations for memcpy_{to,from}io and memset_io functions. So, consolidate them into the existing lib/iomap_copy.c. Reviewed-by: Yann Sionneau Signed-off-by: Julian Vetter --- Changes for v7: - Addressed reviewer comments from David: - Replaced N