Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-13 Thread Jason A. Donenfeld
On Thu, Oct 13, 2022 at 01:40:40PM +0200, Rolf Eike Beer wrote: > Am Donnerstag, 13. Oktober 2022, 12:16:35 CEST schrieb Florian Westphal: > > Rolf Eike Beer wrote: > > > Florian, can you comment and maybe fix it? > > > > Can't comment, do not remember -- this was 5 years ago. > > > > > Or you w

Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-13 Thread Rolf Eike Beer
Am Donnerstag, 13. Oktober 2022, 12:16:35 CEST schrieb Florian Westphal: > Rolf Eike Beer wrote: > > Florian, can you comment and maybe fix it? > > Can't comment, do not remember -- this was 5 years ago. > > > Or you wanted to move the variable before the loop and keep the random > > state betwe

Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-13 Thread Florian Westphal
Rolf Eike Beer wrote: > Florian, can you comment and maybe fix it? Can't comment, do not remember -- this was 5 years ago. > Or you wanted to move the variable before the loop and keep the random state > between the loops and only reseed when all '1' bits have been consumed. Probably. No clue,

Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-13 Thread Rolf Eike Beer
Am Dienstag, 11. Oktober 2022, 01:06:11 CEST schrieb Jason A. Donenfeld: > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real

Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-11 Thread Heiko Carstens
On Mon, Oct 10, 2022 at 05:06:11PM -0600, Jason A. Donenfeld wrote: > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real funct

[PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-10 Thread Jason A. Donenfeld
The prandom_u32() function has been a deprecated inline wrapper around get_random_u32() for several releases now, and compiles down to the exact same code. Replace the deprecated wrapper with a direct call to the real function. The same also applies to get_random_int(), which is just a wrapper arou