Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Maciej W. Rozycki
On Fri, 22 Jul 2022, Rob Herring wrote: > P.S. I really wish I/O space would disappear completely. Some systems make it happen already, such as the POWER9 platform and its PHB4 host bridge (which doesn't handle PCIe TLP I/O read or write commands at all), however some PCI/e devices do require

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Maciej W. Rozycki
On Fri, 22 Jul 2022, Rob Herring wrote: > > > So again, how does one get a 0 address handed out when that's not even > > > a valid region according to DT? Is there some legacy stuff that > > > ignores the bridge windows? > > > > It doesn't matter as just sets it as a generic parameter for > > th

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Rob Herring
On Fri, Jul 22, 2022 at 1:55 PM Arnd Bergmann wrote: > > On Fri, Jul 22, 2022 at 6:36 PM Rob Herring wrote: > > On Fri, Jul 22, 2022 at 9:27 AM Palmer Dabbelt wrote: > > > > From fu740: > >ranges = <0x8100 0x0 0x6008 0x0 > > 0x6008 0x0 0x1>, /* I/O

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Jessica Clarke
On 22 Jul 2022, at 20:55, Arnd Bergmann wrote: > > On Fri, Jul 22, 2022 at 6:36 PM Rob Herring wrote: >> On Fri, Jul 22, 2022 at 9:27 AM Palmer Dabbelt wrote: >> >> From fu740: >> ranges = <0x8100 0x0 0x6008 0x0 >> 0x6008 0x0 0x1>, /* I/O */ > ... >

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Arnd Bergmann
On Fri, Jul 22, 2022 at 6:36 PM Rob Herring wrote: > On Fri, Jul 22, 2022 at 9:27 AM Palmer Dabbelt wrote: > > From fu740: >ranges = <0x8100 0x0 0x6008 0x0 > 0x6008 0x0 0x1>, /* I/O */ ... > So again, how does one get a 0 address handed out when that

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Rob Herring
On Fri, Jul 22, 2022 at 1:23 PM Maciej W. Rozycki wrote: > > On Fri, 22 Jul 2022, Rob Herring wrote: > > > > Maybe the right thing to do here is actually to make the default > > > definitions of these macros non-zero, or to add some sort of ARCH_ > > > flavor of them and move that non-zero require

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Maciej W. Rozycki
On Fri, 22 Jul 2022, Rob Herring wrote: > > Maybe the right thing to do here is actually to make the default > > definitions of these macros non-zero, or to add some sort of ARCH_ > > flavor of them and move that non-zero requirement closer to where it > > comes from? From the look of it any port

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Rob Herring
On Fri, Jul 22, 2022 at 9:27 AM Palmer Dabbelt wrote: > > On Thu, 21 Jul 2022 16:06:52 PDT (-0700), Rob Herring wrote: > > On Tue, Jul 19, 2022 at 9:59 AM Palmer Dabbelt wrote: > >> > >> On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > >> > The asm/pci.h used for many newer arc

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Palmer Dabbelt
On Thu, 21 Jul 2022 16:06:52 PDT (-0700), Rob Herring wrote: On Tue, Jul 19, 2022 at 9:59 AM Palmer Dabbelt wrote: On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > The asm/pci.h used for many newer architectures share similar > definitions. Move the common parts to asm-gene

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Arnd Bergmann
On Fri, Jul 22, 2022 at 1:06 AM Rob Herring wrote: > On Tue, Jul 19, 2022 at 9:59 AM Palmer Dabbelt wrote: > > On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > > > diff --git a/arch/riscv/include/asm/pci.h b/arch/riscv/include/asm/pci.h > > > index 7fd52a30e605..12ce8150cfb0 1

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-21 Thread Rob Herring
On Tue, Jul 19, 2022 at 9:59 AM Palmer Dabbelt wrote: > > On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > > The asm/pci.h used for many newer architectures share similar > > definitions. Move the common parts to asm-generic/pci.h to allow for > > sharing code. > > > > Two thin

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-21 Thread Palmer Dabbelt
On Thu, 21 Jul 2022 15:05:34 PDT (-0700), sho...@gmail.com wrote: On Tue, Jul 19, 2022 at 08:58:39AM -0700, Palmer Dabbelt wrote: On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > The asm/pci.h used for many newer architectures share similar > definitions. Move the common part

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-21 Thread Stafford Horne
On Tue, Jul 19, 2022 at 08:58:39AM -0700, Palmer Dabbelt wrote: > On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > > The asm/pci.h used for many newer architectures share similar > > definitions. Move the common parts to asm-generic/pci.h to allow for > > sharing code. > > > >

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Palmer Dabbelt
On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: The asm/pci.h used for many newer architectures share similar definitions. Move the common parts to asm-generic/pci.h to allow for sharing code. Two things to note are: - isa_dma_bridge_buggy, traditionally this is defined in a

[PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-17 Thread Stafford Horne
The asm/pci.h used for many newer architectures share similar definitions. Move the common parts to asm-generic/pci.h to allow for sharing code. Two things to note are: - isa_dma_bridge_buggy, traditionally this is defined in asm/dma.h but these architectures avoid creating that file and add