Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > An: "Benjamin Berg" , "Richard Weinberger" > > CC: "linux-um" > Gesendet: Freitag, 5. Januar 2024 09:56:11 > Betreff: Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_i

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Johannes Berg
On Fri, 2024-01-05 at 09:12 +0100, Benjamin Berg wrote: > > Another option is giving the helper threads more memory, we don't have > > that many. > > Did you explore this option already? > > I had not really considered that. > > One thing though is that userspace_tramp calls os_info while working

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Benjamin Berg
Hi, On Thu, 2024-01-04 at 23:37 +0100, Richard Weinberger wrote: > On Fri, Nov 10, 2023 at 12:03 PM wrote: > > > > From: Benjamin Berg > > > > The threads allocated inside the kernel have only a single page of > > stack. Unfortunately, the vfprintf function in standard glibc may use > > too mu

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-04 Thread Richard Weinberger
On Fri, Nov 10, 2023 at 12:03 PM wrote: > > From: Benjamin Berg > > The threads allocated inside the kernel have only a single page of > stack. Unfortunately, the vfprintf function in standard glibc may use > too much stack-space, overflowing it. Another option is giving the helper threads more

[PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2023-11-10 Thread benjamin
From: Benjamin Berg The threads allocated inside the kernel have only a single page of stack. Unfortunately, the vfprintf function in standard glibc may use too much stack-space, overflowing it. To make os_info safe to be used by helper threads, use the kernel vscnprintf function into a smallish