Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-20 Thread Stafford Horne
On Tue, Jul 19, 2022 at 03:09:35PM +, David Laight wrote: > From: Stafford Horne > > Sent: 19 July 2022 13:24 > > > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > > On Tue, Jul 19, 2022 at 12:55 PM Stafford Horne wrote: > > Option 3: > > > > > Or we could try to keep t

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-20 Thread Stafford Horne
On Tue, Jul 19, 2022 at 07:32:46AM -0700, Christoph Hellwig wrote: > On Tue, Jul 19, 2022 at 10:05:46PM +0900, Stafford Horne wrote: > > > > Or we could try to keep the generic definition in a global header > > > > like linux/isa-dma.h. > > > > > > Perhaps option 3 makes the whole patch the most c

RE: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread David Laight
From: Stafford Horne > Sent: 19 July 2022 13:24 > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > On Tue, Jul 19, 2022 at 12:55 PM Stafford Horne wrote: > > > > > diff --git a/drivers/comedi/drivers/comedi_isadma.c > > > b/drivers/comedi/drivers/comedi_isadma.c > > > index 7

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Christoph Hellwig
On Tue, Jul 19, 2022 at 10:05:46PM +0900, Stafford Horne wrote: > > > Or we could try to keep the generic definition in a global header > > > like linux/isa-dma.h. > > > > Perhaps option 3 makes the whole patch the most clean. > > And this is the result, I will get this into the series and create

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Stafford Horne
On Tue, Jul 19, 2022 at 03:18:17PM +0200, Arnd Bergmann wrote: > On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne wrote: > > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > > > > And this is the result, I will

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Arnd Bergmann
On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne wrote: > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > And this is the result, I will get this into the series and create a v4 > tomorrow > if no issues. Looks

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Stafford Horne
On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > On Tue, Jul 19, 2022 at 12:55 PM Stafford Horne wrote: > > > > > diff --git a/drivers/comedi/drivers/comedi_isadma.c > > > b/drivers/comedi/drivers/comedi_isadma.c

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Stafford Horne
On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > On Tue, Jul 19, 2022 at 12:55 PM Stafford Horne wrote: > > > diff --git a/drivers/comedi/drivers/comedi_isadma.c > > b/drivers/comedi/drivers/comedi_isadma.c > > index 700982464c53..508421809128 100644 > > --- a/drivers/comedi/driv

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Arnd Bergmann
On Tue, Jul 19, 2022 at 12:55 PM Stafford Horne wrote: > diff --git a/drivers/comedi/drivers/comedi_isadma.c > b/drivers/comedi/drivers/comedi_isadma.c > index 700982464c53..508421809128 100644 > --- a/drivers/comedi/drivers/comedi_isadma.c > +++ b/drivers/comedi/drivers/comedi_isadma.c > @@ -10

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Stafford Horne
On Tue, Jul 19, 2022 at 09:45:58AM +0200, Arnd Bergmann wrote: > On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne wrote: > > On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann wrote: > >> > >> As mentioned before, it would be even better to just remove it > >> entirely from everything except x86, and encl

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-19 Thread Arnd Bergmann
On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne wrote: > On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann wrote: >> >> As mentioned before, it would be even better to just remove it >> entirely from everything except x86, and enclose the four >> references in an explicit "#ifdef X86_32". The variable d

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-17 Thread Arnd Bergmann
On Mon, Jul 18, 2022 at 6:37 AM Christoph Hellwig wrote: > > On Sun, Jul 17, 2022 at 12:34:53PM +0900, Stafford Horne wrote: > > Two things to note are: > > > > - isa_dma_bridge_buggy, traditionally this is defined in asm/dma.h but > >these architectures avoid creating that file and add the d

Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-17 Thread Christoph Hellwig
On Sun, Jul 17, 2022 at 12:34:53PM +0900, Stafford Horne wrote: > Two things to note are: > > - isa_dma_bridge_buggy, traditionally this is defined in asm/dma.h but >these architectures avoid creating that file and add the definition >to asm/pci.h. This doesn't have anyting to do with PC

[PATCH v2 2/2] asm-generic: Add new pci.h and use it

2022-07-16 Thread Stafford Horne
The asm/pci.h used for many newer architectures share similar definitions. Move the common parts to asm-generic/pci.h to allow for sharing code. Two things to note are: - isa_dma_bridge_buggy, traditionally this is defined in asm/dma.h but these architectures avoid creating that file and add