Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-05 Thread Marek Maślanka
On Sat, Jan 4, 2025 at 3:07 AM Luis Chamberlain wrote: > > On Fri, Jan 03, 2025 at 07:58:13AM +0100, Jürgen Groß wrote: > > On 03.01.25 03:06, Andrew Cooper wrote: > > > > Hi Mike, > > > > > > > > This commit is making my intel box not boot in mm-unstable :>) I > > > > bisected it to > > > > this

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-03 Thread Luis Chamberlain
On Fri, Jan 03, 2025 at 07:58:13AM +0100, Jürgen Groß wrote: > On 03.01.25 03:06, Andrew Cooper wrote: > > > Hi Mike, > > > > > > This commit is making my intel box not boot in mm-unstable :>) I bisected > > > it to > > > this commit. > > > > For what it's worth, we've found the same under Xen t

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-03 Thread Marek Marczykowski-Górecki
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Thu, Jan 02, 2025 at 09:57:14PM -0800, Andrew Morton wrote: > On Fri, 3 Jan 2025 02:06:10 + Andrew Cooper > wrote: > > > > Hi Mike, > > > > > > This commit is making my intel box not boot in mm-unstable :>) I bisected > > > it to > > > thi

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Jürgen Groß
On 03.01.25 03:06, Andrew Cooper wrote: Hi Mike, This commit is making my intel box not boot in mm-unstable :>) I bisected it to this commit. For what it's worth, we've found the same under Xen too. There's one concrete bug in the series, failing to cope with the absence of superpages (fix in

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Andrew Morton
On Fri, 3 Jan 2025 02:06:10 + Andrew Cooper wrote: > > Hi Mike, > > > > This commit is making my intel box not boot in mm-unstable :>) I bisected > > it to > > this commit. > > For what it's worth, we've found the same under Xen too. > > There's one concrete bug in the series, failing to

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Andrew Cooper
> Hi Mike, > > This commit is making my intel box not boot in mm-unstable :>) I bisected it > to > this commit. For what it's worth, we've found the same under Xen too. There's one concrete bug in the series, failing to cope with the absence of superpages (fix in https://lore.kernel.org/xen-deve

Re: [PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2025-01-02 Thread Lorenzo Stoakes
Hi Mike, This commit is making my intel box not boot in mm-unstable :>) I bisected it to this commit. It seems to be having an unhandled kernel page fault on exec, so I guess not actually making it exec somehow? It is a pretty standard intel machine (arch linux config, slightly scaled down via m

[PATCH 6/8] modules: switch to execmem API for remapping as RW and restoring ROX

2024-12-26 Thread Mike Rapoport
From: "Mike Rapoport (Microsoft)" Instead of using writable copy for module text sections, temporarily remap the memory allocated from execmem's ROX cache as writable and restore its ROX permissions after the module is formed. This will allow removing nasty games with writable copy in alternativ