Re: [PATCH 5/7] um: Add an internal header shared among the user code

2024-04-23 Thread Tiwei Bie
On 4/23/24 8:22 PM, Johannes Berg wrote: > On Tue, 2024-04-23 at 20:09 +0800, Tiwei Bie wrote: >> On 4/23/24 7:30 PM, Johannes Berg wrote: >>> On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote: $(USER_OBJS:.o=.%): \ - c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include $(sr

Re: [PATCH 5/7] um: Add an internal header shared among the user code

2024-04-23 Thread Johannes Berg
On Tue, 2024-04-23 at 20:09 +0800, Tiwei Bie wrote: > On 4/23/24 7:30 PM, Johannes Berg wrote: > > On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote: > > > > > > $(USER_OBJS:.o=.%): \ > > > - c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include > > > $(srctree)/include/linux/kern_levels.h -incl

Re: [PATCH 5/7] um: Add an internal header shared among the user code

2024-04-23 Thread Tiwei Bie
On 4/23/24 7:30 PM, Johannes Berg wrote: > On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote: >> >> $(USER_OBJS:.o=.%): \ >> -c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include >> $(srctree)/include/linux/kern_levels.h -include user.h >> $(CFLAGS_$(basetarget).o) >> +c_flags = -Wp,-MD

Re: [PATCH 5/7] um: Add an internal header shared among the user code

2024-04-23 Thread Johannes Berg
On Tue, 2024-04-23 at 19:24 +0800, Tiwei Bie wrote: > > $(USER_OBJS:.o=.%): \ > - c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include > $(srctree)/include/linux/kern_levels.h -include user.h > $(CFLAGS_$(basetarget).o) > + c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include > $(srctr

[PATCH 5/7] um: Add an internal header shared among the user code

2024-04-23 Thread Tiwei Bie
Move relevant declarations to this header. This will address below -Wmissing-prototypes warnings: arch/um/os-Linux/elf_aux.c:26:13: warning: no previous prototype for ‘scan_elf_aux’ [-Wmissing-prototypes] arch/um/os-Linux/mem.c:213:13: warning: no previous prototype for ‘check_tmpexec’ [-Wmissin