Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-04 Thread Miguel Ojeda
On Wed, Sep 4, 2024 at 9:38 AM Jiaxun Yang wrote: > > Reported at: > https://github.com/rust-embedded/wg/issues/792#issuecomment-2328133517 Thanks for the link! Added to our bullet point about the target spec file in https://github.com/Rust-for-Linux/linux/issues/2. Cheers, Miguel

Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-04 Thread Jiaxun Yang
在2024年9月3日九月 下午8:01,Miguel Ojeda写道: > On Tue, Sep 3, 2024 at 8:32 PM Jiaxun Yang wrote: >> >> Ahh thanks for the elaboration. > > You're welcome! > >> However, kernel supports many ISA variants that are not defined by any rust >> target >> triple, I'm not really sure if it's appropriate to def

Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-03 Thread Miguel Ojeda
On Tue, Sep 3, 2024 at 8:32 PM Jiaxun Yang wrote: > > Ahh thanks for the elaboration. You're welcome! > However, kernel supports many ISA variants that are not defined by any rust > target > triple, I'm not really sure if it's appropriate to define them all in > upstream. They need to be in u

Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-03 Thread Jiaxun Yang
在2024年9月3日九月 下午7:17,Miguel Ojeda写道: [...] > > I guess you mean you are getting the warning about the > unknown/unstable feature passed to the backend? i.e. `rustc` knows > about those LLVM ones and forwards them when enabled via > `-Ctarget-feature` (with a warning): > > rustc --target mips6

Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-03 Thread Miguel Ojeda
On Tue, Sep 3, 2024 at 7:53 PM Jiaxun Yang wrote: > > Thanks for your review! You're welcome! > Triples defined for MIPS bare-metal target is surprisingly lacking, we do have > little-endian 32-bit bare-metal target mipsel-unknown-none but big-endian and > 64 bit variants are missing. Hmm... So

Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-03 Thread Jiaxun Yang
在2024年9月3日九月 下午6:44,Miguel Ojeda写道: > On Tue, Sep 3, 2024 at 7:15 PM Jiaxun Yang wrote: >> >> We don't use builtin target as there is no sutiable baremetal >> target for us that can cover all ISA variants supported by kernel. > > Since we should try to go away from using `target.json`: what was

Re: [PATCH 3/3] rust: Enable for MIPS

2024-09-03 Thread Miguel Ojeda
On Tue, Sep 3, 2024 at 7:15 PM Jiaxun Yang wrote: > > We don't use builtin target as there is no sutiable baremetal > target for us that can cover all ISA variants supported by kernel. Since we should try to go away from using `target.json`: what was not possible to enable via e.g. `-Ctarget-feat

[PATCH 3/3] rust: Enable for MIPS

2024-09-03 Thread Jiaxun Yang
Enable rust for linux by implement generate_rust_target.rs and select relevant Kconfig options. We don't use builtin target as there is no sutiable baremetal target for us that can cover all ISA variants supported by kernel. Link: https://github.com/Rust-for-Linux/linux/issues/107 Signed-off-by: