Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-29 Thread Nadav Amit
On Nov 29, 2022, at 7:06 AM, Steven Rostedt wrote: > On Tue, 29 Nov 2022 04:25:38 + > Nadav Amit wrote: > > >> I will need to further debug it, but this issue does not occur every time. >> >> The kernel didn’t crash exactly - it’s more of a deadlock. I have lockdep >> enabled, so it is no

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-29 Thread Steven Rostedt
On Tue, 29 Nov 2022 04:25:38 + Nadav Amit wrote: > I will need to further debug it, but this issue does not occur every time. > > The kernel didn’t crash exactly - it’s more of a deadlock. I have lockdep > enabled, so it is not a deadlock that lockdep knows. Could it be that > somehow thing

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-28 Thread Nadav Amit
On Nov 28, 2022, at 8:15 PM, Steven Rostedt wrote: > !! External Email > > On Tue, 29 Nov 2022 02:36:22 + > Nadav Amit wrote: > >> On Nov 22, 2022, at 12:51 PM, Nadav Amit wrote: >> >>> But more importantly, the current “inline”->”notrace” solution just papers >>> over missing “notrace”

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-28 Thread Steven Rostedt
On Tue, 29 Nov 2022 02:36:22 + Nadav Amit wrote: > On Nov 22, 2022, at 12:51 PM, Nadav Amit wrote: > > > But more importantly, the current “inline”->”notrace” solution just papers > > over missing “notrace” annotations. Anyone can remove the “inline” at any > > given moment since there is n

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-28 Thread Nadav Amit
On Nov 22, 2022, at 12:51 PM, Nadav Amit wrote: > But more importantly, the current “inline”->”notrace” solution just papers > over missing “notrace” annotations. Anyone can remove the “inline” at any > given moment since there is no direct (or indirect) relationship between > “inline” and “notra

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-22 Thread Nadav Amit
On Nov 22, 2022, at 12:09 PM, Arnd Bergmann wrote: > !! External Email > > On Tue, Nov 22, 2022, at 20:53, Nadav Amit wrote: >> From: Nadav Amit >> >> Functions that are marked as "inline" are currently also not tracable. >> Apparently, this has been done to prevent differences between differe

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-22 Thread Steven Rostedt
On Tue, 22 Nov 2022 21:09:08 +0100 "Arnd Bergmann" wrote: > On Tue, Nov 22, 2022, at 20:53, Nadav Amit wrote: > > From: Nadav Amit > > > > Functions that are marked as "inline" are currently also not tracable. > > Apparently, this has been done to prevent differences between different > > config

Re: [PATCH 3/3] compiler: inline does not imply notrace

2022-11-22 Thread Arnd Bergmann
On Tue, Nov 22, 2022, at 20:53, Nadav Amit wrote: > From: Nadav Amit > > Functions that are marked as "inline" are currently also not tracable. > Apparently, this has been done to prevent differences between different > configs that caused different functions to be tracable on different > platform