Re: [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread David Sterba
On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead and remove the holder argument from the > call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls. Please

Re: [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Hannes Reinecke
On 6/6/23 09:39, Christoph Hellwig wrote: Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't make sense, so pass NULL instead and remove the holder argument from the call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls. Signed-off-by: Christoph Hellwig --

Re: [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead and remove the holder argument from the > call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls. > > Sig

[PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-06 Thread Christoph Hellwig
Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't make sense, so pass NULL instead and remove the holder argument from the call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls. Signed-off-by: Christoph Hellwig --- fs/btrfs/super.c | 16 ++--