Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-19 Thread Christian Brauner
On Tue, Jun 17, 2025 at 12:28:17PM +0200, Jan Kara wrote: > On Mon 16-06-25 20:33:29, Lorenzo Stoakes wrote: > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > > callback"), the f_op->mmap() hook has been deprecated in favour of > > f_op->mmap_prepare(). > > > > This callback

Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-19 Thread Ryusuke Konishi
On Tue, Jun 17, 2025 at 4:48 AM Lorenzo Stoakes wrote: > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling

Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-19 Thread David Sterba
On Mon, Jun 16, 2025 at 08:33:29PM +0100, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error

Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-19 Thread Jan Kara
On Mon 16-06-25 20:33:29, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling > can b

Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-19 Thread Viacheslav Dubeyko
On Mon, 2025-06-16 at 20:33 +0100, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handlin

Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-19 Thread Damien Le Moal
On 6/17/25 4:33 AM, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling > can be perf

[PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

2025-06-16 Thread Lorenzo Stoakes
Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file callback"), the f_op->mmap() hook has been deprecated in favour of f_op->mmap_prepare(). This callback is invoked in the mmap() logic far earlier, so error handling can be performed more safely without complicated and bug-prone sta