Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-19 Thread Alexander Gordeev
> Reviewed-by: Alexander Gordeev Sorry, I meant for s390. Can not judge the other archs impact.

Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-18 Thread Alexander Gordeev
On Mon, Feb 17, 2025 at 07:08:28PM +, Matthew Wilcox (Oracle) wrote: > If the first access to a folio is a read that is then followed by a > write, we can save a page fault. s390 implemented this in their > mk_pte() in commit abf09bed3cce ("s390/mm: implement software dirty > bits"), but other

Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-18 Thread Alexander Gordeev
On Tue, Feb 18, 2025 at 05:06:38PM +, Matthew Wilcox wrote: ... > > With the above the implicit dirtifying of hugetlb PTEs (as result of > > mk_huge_pte() -> mk_pte()) in make_huge_pte() is removed: > > > > static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page, > >

Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-18 Thread Matthew Wilcox
On Tue, Feb 18, 2025 at 05:20:28PM +0100, Alexander Gordeev wrote: > > +++ b/arch/s390/include/asm/pgtable.h > > @@ -1451,12 +1451,7 @@ static inline pte_t mk_pte_phys(unsigned long > > physpage, pgprot_t pgprot) > > > > static inline pte_t mk_pte(struct page *page, pgprot_t pgprot) > > { > >

Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-18 Thread Alexander Gordeev
On Mon, Feb 17, 2025 at 07:08:28PM +, Matthew Wilcox (Oracle) wrote: Hi Matthew, > If the first access to a folio is a read that is then followed by a > write, we can save a page fault. s390 implemented this in their > mk_pte() in commit abf09bed3cce ("s390/mm: implement software dirty > bit

Re: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-18 Thread David Hildenbrand
On 17.02.25 20:08, Matthew Wilcox (Oracle) wrote: If the first access to a folio is a read that is then followed by a write, we can save a page fault. s390 implemented this in their mk_pte() in commit abf09bed3cce ("s390/mm: implement software dirty bits"), but other architectures can also benef

[PATCH 1/7] mm: Set the pte dirty if the folio is already dirty

2025-02-17 Thread Matthew Wilcox (Oracle)
If the first access to a folio is a read that is then followed by a write, we can save a page fault. s390 implemented this in their mk_pte() in commit abf09bed3cce ("s390/mm: implement software dirty bits"), but other architectures can also benefit from this. Signed-off-by: Matthew Wilcox (Oracle