Re: [PATCH 09/12] sd: convert to the atomic queue limits API

2024-05-30 Thread Christoph Hellwig
On Thu, May 30, 2024 at 10:16:33AM +0100, John Garry wrote: >> -static void sd_config_write_same(struct scsi_disk *); >> +static void sd_config_discard(struct scsi_disk *sdkp, struct queue_limits >> *lim, >> +unsigned int mode); > > Are there any reasons why we keep forward declaration

Re: [PATCH 09/12] sd: convert to the atomic queue limits API

2024-05-30 Thread John Garry
On 29/05/2024 06:04, Christoph Hellwig wrote: Assign all queue limits through a local queue_limits variable and queue_limits_commit_update so that we can't race updating them from multiple places, and free the queue when updating them so that in-progress I/O submissions don't see half-updated lim

Re: [PATCH 09/12] sd: convert to the atomic queue limits API

2024-05-29 Thread Damien Le Moal
On 5/29/24 14:04, Christoph Hellwig wrote: > Assign all queue limits through a local queue_limits variable and > queue_limits_commit_update so that we can't race updating them from > multiple places, and free the queue when updating them so that s/free/freeze > in-progress I/O submissions don't s

[PATCH 09/12] sd: convert to the atomic queue limits API

2024-05-28 Thread Christoph Hellwig
Assign all queue limits through a local queue_limits variable and queue_limits_commit_update so that we can't race updating them from multiple places, and free the queue when updating them so that in-progress I/O submissions don't see half-updated limits. Signed-off-by: Christoph Hellwig --- dri