Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-07 Thread Christoph Hellwig
On Wed, Jun 07, 2023 at 02:13:33PM +0200, Hannes Reinecke wrote: >> +++ b/include/linux/cdrom.h >> @@ -64,6 +64,7 @@ struct cdrom_device_info { >> int (*exit)(struct cdrom_device_info *); >> int mrw_mode_page; >> __s64 last_media_change_ms; >> +bool opened_for_data; >> }; >>

Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-07 Thread Hannes Reinecke
On 6/6/23 09:39, Christoph Hellwig wrote: Set a flag when a cdrom_device_info is opened for writing, instead of trying to figure out this at release time. This will allow to eventually remove the mode argument to the ->release block_device_operation as nothing but the CDROM drivers uses that arg

Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:24AM +0200, Christoph Hellwig wrote: > Set a flag when a cdrom_device_info is opened for writing, instead of > trying to figure out this at release time. This will allow to eventually > remove the mode argument to the ->release block_device_operation as > nothing but

Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-06 Thread Phillip Potter
On Tue, Jun 06, 2023 at 09:39:24AM +0200, Christoph Hellwig wrote: > Set a flag when a cdrom_device_info is opened for writing, instead of > trying to figure out this at release time. This will allow to eventually > remove the mode argument to the ->release block_device_operation as > nothing but

[PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-06 Thread Christoph Hellwig
Set a flag when a cdrom_device_info is opened for writing, instead of trying to figure out this at release time. This will allow to eventually remove the mode argument to the ->release block_device_operation as nothing but the CDROM drivers uses that argument. Signed-off-by: Christoph Hellwig --