Re: [PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store

2024-05-30 Thread Bart Van Assche
On 5/28/24 22:04, Christoph Hellwig wrote: Don't reset the discard settings to no-op over and over when a user writes to the provisioning attribute as that is already the default mode for ZBC devices. In hindsight we should have made writing to the attribute fail for ZBC devices, but the code ha

Re: [PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store

2024-05-29 Thread Damien Le Moal
On 5/29/24 14:04, Christoph Hellwig wrote: > Don't reset the discard settings to no-op over and over when a user > writes to the provisioning attribute as that is already the default > mode for ZBC devices. In hindsight we should have made writing to > the attribute fail for ZBC devices, but the c

[PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store

2024-05-28 Thread Christoph Hellwig
Don't reset the discard settings to no-op over and over when a user writes to the provisioning attribute as that is already the default mode for ZBC devices. In hindsight we should have made writing to the attribute fail for ZBC devices, but the code has probably been around for far too long to ch