Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Christoph Hellwig
On Fri, May 31, 2024 at 08:48:12AM +0200, Ilya Dryomov wrote: > We should revert io_opt from opts->alloc_size to objset_bytes (I think > it's what you meant to say but typoed). Yes, sorry. > How do you want to handle it? I can put together a patch, send it to > ceph-devel and it will be picked b

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Ilya Dryomov
On Fri, May 31, 2024 at 7:54 AM Christoph Hellwig wrote: > > On Thu, May 30, 2024 at 09:48:06PM +0200, Ilya Dryomov wrote: > > For rbd, this change effectively lowers max_sectors from 4M to 64K or > > less and that is definitely not desirable. From previous interactions > > with users we want max

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Christoph Hellwig
On Thu, May 30, 2024 at 09:48:06PM +0200, Ilya Dryomov wrote: > For rbd, this change effectively lowers max_sectors from 4M to 64K or > less and that is definitely not desirable. From previous interactions > with users we want max_sectors to match max_hw_sectors -- this has come > up a quite a few

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Ilya Dryomov
On Wed, May 29, 2024 at 7:05 AM Christoph Hellwig wrote: > > The soft max_sectors limit is normally capped by the hardware limits and > an arbitrary upper limit enforced by the kernel, but can be modified by > the user. A few drivers want to increase this limit (nbd, rbd) or > adjust it up or dow

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Bart Van Assche
On 5/28/24 22:04, Christoph Hellwig wrote: The soft max_sectors limit is normally capped by the hardware limits and an arbitrary upper limit enforced by the kernel, but can be modified by the user. A few drivers want to increase this limit (nbd, rbd) or adjust it up or down based on hardware cap

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-29 Thread Damien Le Moal
On 5/29/24 14:04, Christoph Hellwig wrote: > The soft max_sectors limit is normally capped by the hardware limits and > an arbitrary upper limit enforced by the kernel, but can be modified by > the user. A few drivers want to increase this limit (nbd, rbd) or > adjust it up or down based on hardwa

[PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-28 Thread Christoph Hellwig
The soft max_sectors limit is normally capped by the hardware limits and an arbitrary upper limit enforced by the kernel, but can be modified by the user. A few drivers want to increase this limit (nbd, rbd) or adjust it up or down based on hardware capabilities (sd). Change blk_validate_limits t