Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-06-08 Thread Eric W. Biederman
Kyle Huey writes: > On Thu, May 19, 2022 at 11:05 AM Eric W. Biederman > wrote: >> >> Sebastian Andrzej Siewior writes: >> >> > On 2022-05-18 20:26:05 [-0700], Kyle Huey wrote: >> >> Is there a git branch somewhere I can pull to test this? It doesn't apply >> >> cleanly to Linus's tip. >> > >>

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Peter Zijlstra
On Fri, May 20, 2022 at 02:32:24PM -0500, Eric W. Biederman wrote: > Sebastian Andrzej Siewior writes: > > > On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > >> > >> For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > >> ptrace_freeze_traced has completed successfully

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: >> >> For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once >> ptrace_freeze_traced has completed successfully. Which fundamentally >> means the lock dance of dropping siglock and grabbing

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Sebastian Andrzej Siewior
On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > After this set of changes only cgroup_enter_frozen should remain a > stumbling block for PREEMPT_RT in the ptrace_stop path. Yes, I can confirm that. I have no systemd-less system at hand which means I can't boot a kernel without CGROUP su

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-20 Thread Sebastian Andrzej Siewior
On 2022-05-18 17:49:50 [-0500], Eric W. Biederman wrote: > > For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once > ptrace_freeze_traced has completed successfully. Which fundamentally > means the lock dance of dropping siglock and grabbing tasklist_lock does > not work on PREEMPT_

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-19 Thread Eric W. Biederman
Sebastian Andrzej Siewior writes: > On 2022-05-18 20:26:05 [-0700], Kyle Huey wrote: >> Is there a git branch somewhere I can pull to test this? It doesn't apply >> cleanly to Linus's tip. > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > ptrace_stop-clea

Re: [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-18 Thread Sebastian Andrzej Siewior
On 2022-05-18 20:26:05 [-0700], Kyle Huey wrote: > Is there a git branch somewhere I can pull to test this? It doesn't apply > cleanly to Linus's tip. https://kernel.googlesource.com/pub/scm/linux/kernel/git/ebiederm/user-namespace.git ptrace_stop-cleanup-for-v5.19 > - Kyle Sebastian _

[PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock

2022-05-18 Thread Eric W. Biederman
For ptrace_stop to work on PREEMT_RT no spinlocks can be taken once ptrace_freeze_traced has completed successfully. Which fundamentally means the lock dance of dropping siglock and grabbing tasklist_lock does not work on PREEMPT_RT. So I have worked through what is necessary so that tasklist_l