Re: [PATCH 00/10] Account page tables at all levels

2025-01-03 Thread Kevin Brodsky
On 20/12/2024 20:31, Dave Hansen wrote: > On 12/20/24 02:58, Kevin Brodsky wrote: >>> One super tiny nit is that the PAE pgd _can_ be allocated using >>> __get_free_pages(). It was originally there for Xen, but I think it's >>> being used for PTI only at this point and the comments are wrong-ish. >

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Dave Hansen
On 12/20/24 02:58, Kevin Brodsky wrote: >> One super tiny nit is that the PAE pgd _can_ be allocated using >> __get_free_pages(). It was originally there for Xen, but I think it's >> being used for PTI only at this point and the comments are wrong-ish. >> >> I kinda think we should just get rid of

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Dave Hansen
On 12/20/24 02:58, Kevin Brodsky wrote: >> Acked-by: Dave Hansen > Just to double-check, are your ack'ing the x86 changes specifically? If > so I'll add your Acked-by on patch 6, 7 and 9. Feel free to add it to each patch in the series.

Re: [PATCH 00/10] Account page tables at all levels

2024-12-20 Thread Kevin Brodsky
On 19/12/2024 18:13, Dave Hansen wrote: > On 12/19/24 08:44, Kevin Brodsky wrote: >> >> +---+-+---+--++ >> | x86 | Y | Y | Y/N >>

Re: [PATCH 00/10] Account page tables at all levels

2024-12-19 Thread Dave Hansen
On 12/19/24 08:44, Kevin Brodsky wrote: > > +---+-+---+--++ > | x86 | Y | Y | Y/N > | kmem_cache at pgd level if PAE | >

[PATCH 00/10] Account page tables at all levels

2024-12-19 Thread Kevin Brodsky
We currently have a pair of ctor/dtor calls for lower page table levels, up to PUD. At PTE and PMD level, these handle split locks, if supported. Additionally, the helpers ensure correct accounting of page table pages to the corresponding process. This series takes that principle to its logical co