Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-16 Thread Vincent Whitchurch
On Mon, Jun 13, 2022 at 08:58:40AM +0200, Jason Wang wrote: > On Fri, Jun 10, 2022 at 11:12 PM Vincent Whitchurch > wrote: > > diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c > > index 5c092a9153ea..027847023184 100644 > > --- a/arch/um/drivers/virt-pci.c > > +++ b/arch/um/dr

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-13 Thread Michael S. Tsirkin
On Mon, Jun 13, 2022 at 02:58:40PM +0800, Jason Wang wrote: > On Fri, Jun 10, 2022 at 11:12 PM Vincent Whitchurch > wrote: > > > > Call virtio_device_ready() to make this driver work after commit > > b4ec69d7e09 ("virtio: harden vring IRQ"), since the driver uses the > > virtqueues in the probe fu

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-12 Thread Jason Wang
On Fri, Jun 10, 2022 at 11:12 PM Vincent Whitchurch wrote: > > Call virtio_device_ready() to make this driver work after commit > b4ec69d7e09 ("virtio: harden vring IRQ"), since the driver uses the > virtqueues in the probe function. (The virtio core sets the device > ready when probe returns.) >

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-12 Thread Vincent Whitchurch
On Sat, Jun 11, 2022 at 02:34:04AM +0200, Michael S. Tsirkin wrote: > BTW Johannes I think you need to spec this device and get > an ID - what's the plan for that? Current hack of punting > this to userspace isn't really any good long term. There is work ongoing in QEMU to add a new vfio-user prot

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-12 Thread Michael S. Tsirkin
On Sun, Jun 12, 2022 at 10:58:20AM +0200, Johannes Berg wrote: > On Fri, 2022-06-10 at 20:34 -0400, Michael S. Tsirkin wrote: > > > > Also fixes this commit: > > > > commit 68f5d3f3b6543266b29e047cfaf9842333019b4c > > Author: Johannes Berg > > Date: Fri Mar 5 13:19:58 2021 +0100 > > > > u

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-12 Thread Johannes Berg
On Fri, 2022-06-10 at 20:34 -0400, Michael S. Tsirkin wrote: > > Also fixes this commit: > > commit 68f5d3f3b6543266b29e047cfaf9842333019b4c > Author: Johannes Berg > Date: Fri Mar 5 13:19:58 2021 +0100 > > um: add PCI over virtio emulation driver Hm, why? It worked before the harden cha

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-10 Thread Michael S. Tsirkin
On Fri, Jun 10, 2022 at 05:12:03PM +0200, Vincent Whitchurch wrote: > Call virtio_device_ready() to make this driver work after commit > b4ec69d7e09 ("virtio: harden vring IRQ"), since the driver uses the > virtqueues in the probe function. (The virtio core sets the device > ready when probe retur

Re: [PATCH] um: virt-pci: set device ready in probe()

2022-06-10 Thread Johannes Berg
On Fri, 2022-06-10 at 17:12 +0200, Vincent Whitchurch wrote: > Call virtio_device_ready() to make this driver work after commit > b4ec69d7e09 ("virtio: harden vring IRQ"), since the driver uses the > virtqueues in the probe function. (The virtio core sets the device > ready when probe returns.) >

[PATCH] um: virt-pci: set device ready in probe()

2022-06-10 Thread Vincent Whitchurch
Call virtio_device_ready() to make this driver work after commit b4ec69d7e09 ("virtio: harden vring IRQ"), since the driver uses the virtqueues in the probe function. (The virtio core sets the device ready when probe returns.) Fixes: 8b4ec69d7e09 ("virtio: harden vring IRQ") Signed-off-by: Vincen