Re: [PATCH] um: Fix misaligned stack in stub_exe

2024-10-21 Thread Johannes Berg
On Sat, 2024-10-19 at 13:54 +0800, David Gow wrote: > > Okay, it turns out this breaks clang: > arch/um/kernel/skas/stub_exe.c:84:2: error: non-ASM statement in naked > function is not supported Fun :) Interesting too, I've _definitely_ got some code elsewhere, that's usually compiled with clang

Re: [PATCH] um: Fix misaligned stack in stub_exe

2024-10-18 Thread David Gow
On Fri, 18 Oct 2024 at 07:10, David Gow wrote: > > The stub_exe could segfault when built with some compilers (e.g. gcc > 13.2.0), as SSE instructions which relied on stack alignment could be > generated, but the stack was misaligned. > > This seems to be due to the __start entry point being run w

[PATCH] um: Fix misaligned stack in stub_exe

2024-10-17 Thread David Gow
The stub_exe could segfault when built with some compilers (e.g. gcc 13.2.0), as SSE instructions which relied on stack alignment could be generated, but the stack was misaligned. This seems to be due to the __start entry point being run with a 16-byte aligned stack, but the x86_64 SYSV ABI wantin