Re: [PATCH] arch: um: rust: Add i386 support for Rust

2024-06-05 Thread Johannes Berg
On Wed, 2024-06-05 at 19:59 +0200, Ard Biesheuvel wrote: > > > > -ifdef CONFIG_X86_64 > > > +ifneq ($(or $(CONFIG_X86_64),$(CONFIG_X86_32)),) > > > > These configurations are mutually exclusive, so would it look more > > readable to have it be: > > > > > > ifeq ($(CONFIG_X86_32)$(CONFIG_X86_64)

Re: [PATCH] arch: um: rust: Add i386 support for Rust

2024-06-05 Thread Ard Biesheuvel
On Wed, 5 Jun 2024 at 08:22, Nathan Chancellor wrote: > > Hi David, > > Just a fly by comment on style, I don't have much to say content :) > > On Wed, Jun 05, 2024 at 06:40:50AM +0800, David Gow wrote: > > At present, Rust in the kernel only supports 64-bit x86, so UML has > > followed suit. Howe

Re: [PATCH] arch: um: rust: Add i386 support for Rust

2024-06-04 Thread Nathan Chancellor
Hi David, Just a fly by comment on style, I don't have much to say content :) On Wed, Jun 05, 2024 at 06:40:50AM +0800, David Gow wrote: > At present, Rust in the kernel only supports 64-bit x86, so UML has > followed suit. However, it's significantly easier to support 32-bit i386 > on UML than o

[PATCH] arch: um: rust: Add i386 support for Rust

2024-06-04 Thread David Gow
At present, Rust in the kernel only supports 64-bit x86, so UML has followed suit. However, it's significantly easier to support 32-bit i386 on UML than on bare metal, as UML does not use the -mregparm option (which alters the ABI), which is not yet supported by rustc[1]. Add support for CONFIG_RU