Re: [PATCH v4 0/7] of: populate of_root node if bootloader doesn't

2024-03-08 Thread Rob Herring
On Fri, Feb 16, 2024 at 05:05:49PM -0800, Stephen Boyd wrote: > Arch maintainers, please ack/review patches. > > This is a resend of a series from Frank last year[1]. I worked in Rob's > review comments to unconditionally call unflatten_device_tree() and > fixup/audit calls to of_have_populated_dt

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-28 Thread Rob Herring
On Tue, Feb 27, 2024 at 05:34:58PM +, Mark Rutland wrote: > On Fri, Feb 23, 2024 at 11:17:02AM -0700, Rob Herring wrote: > > On Fri, Feb 23, 2024 at 3:23 AM Will Deacon wrote: > > > > > > On Thu, Feb 22, 2024 at 05:03:17PM -0700, Rob Herring wrote: > > >

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-23 Thread Rob Herring
On Fri, Feb 23, 2024 at 3:23 AM Will Deacon wrote: > > On Thu, Feb 22, 2024 at 05:03:17PM -0700, Rob Herring wrote: > > On Fri, Feb 16, 2024 at 05:05:54PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > >

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-22 Thread Rob Herring
and copy the 'initial_boot_params' data. > > Cc: Rob Herring > Cc: Frank Rowand > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: > Signed-off-by: Stephen Boyd > --- > arch/arm64/kernel/setup.c | 3 +-- > 1 file changed, 1 insertion(

Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware

2024-02-21 Thread Rob Herring
oved because it prevents > > overlays from creating platform devices when the empty root node is > > used. > > > > [sb...@kernel.org: Update of_have_populated_dt() to treat this empty dtb > > as not populated. Drop setup_of() initcall] > > > > Signed-off-by:

Re: [PATCH v3 7/7] of: Add KUnit test to confirm DTB is loaded

2024-02-13 Thread Rob Herring
: > > > > > Add a KUnit test that confirms a DTB has been loaded, i.e. there is a > > > > > root node, and that the of_have_populated_dt() API works properly. > > > > > > > > > > Cc: Rob Herring > > > > > Cc:

Re: [PATCH v2 1/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-02 Thread Rob Herring
On Wed, Jan 31, 2024 at 02:59:53PM -0800, Stephen Boyd wrote: > Quoting Rob Herring (2024-01-31 12:54:05) > > On Mon, Jan 29, 2024 at 04:45:00PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > > on platf

Re: [PATCH v2 1/7] arm64: Unconditionally call unflatten_device_tree()

2024-01-31 Thread Rob Herring
but the > bootloader has loaded a DTB so that we don't allow both ACPI and DT to > be used during boot. If there isn't a valid initial_boot_params dtb then > unflatten_device_tree() returns early so this is fine. > > Cc: Rob Herring > Cc: Frank Rowand > Cc: Catal

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-19 Thread Rob Herring
On Thu, Jan 18, 2024 at 03:26:43PM +, Mark Rutland wrote: > On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > > Quoting Mark Rutland (2024-01-16 03:51:14) > > > Hi Stephen, > > > > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > > Call this function uncond

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-18 Thread Rob Herring
On Thu, Jan 18, 2024 at 2:46 AM Geert Uytterhoeven wrote: > > Hi Rob, > > On Wed, Jan 17, 2024 at 6:41 PM Rob Herring wrote: > > On Tue, Jan 16, 2024 at 05:18:15PM -0800, Stephen Boyd wrote: > > > Quoting Rob Herring (2024-01-15 12:32:30) > > > > On Fri, Ja

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-17 Thread Rob Herring
On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > Quoting Mark Rutland (2024-01-16 03:51:14) > > Hi Stephen, > > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > > on platforms that don

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-17 Thread Rob Herring
On Tue, Jan 16, 2024 at 05:18:15PM -0800, Stephen Boyd wrote: > Quoting Rob Herring (2024-01-15 12:32:30) > > On Fri, Jan 12, 2024 at 12:07:47PM -0800, Stephen Boyd wrote: > > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > index da9826accb1b..9628e48baa15

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-15 Thread Rob Herring
7;t > fully initialized. > > Signed-off-by: Frank Rowand > Link: > https://lore.kernel.org/r/20230317053415.2254616-2-frowand.l...@gmail.com > Cc: Rob Herring > [sb...@kernel.org: Update of_have_populated_dt() to treat this empty dtb > as not populated. Drop se

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-15 Thread Rob Herring
27;t see an issue with that. There was worry when ACPI was added that systems would pass both DT and ACPI tables and that the kernel must only use ACPI. That was more to force ACPI adoption, but I'm not sure if that actually exists in any early system. I think we're past forcing ado

Re: UML for arm64

2023-06-23 Thread Rob Herring
On Thu, Jun 22, 2023 at 2:14 PM Benjamin Berg wrote: > > Hi, > > On Thu, 2023-06-22 at 21:41 +0200, Johannes Berg wrote: > > On Thu, 2023-06-22 at 13:22 -0600, Rob Herring wrote: > > > I'm interested in getting UML working on Arm. Is anyone aware of any

UML for arm64

2023-06-22 Thread Rob Herring
Hi all, I'm interested in getting UML working on Arm. Is anyone aware of any efforts to do this already? I've not found anything searching around. Or perhaps a port to any other arch as I'd imagine any 2nd arch will require some refactoring. Thanks, Rob ___

Re: [PATCH 2/8] of: Enable DTB loading on UML for KUnit tests

2023-03-08 Thread Rob Herring
n to load a > DTB is ignored if CONFIG_OF_KUNIT is enabled so that only one DTB is > loaded at a time. > > Add a simple unit test to confirm that the DTB loading worked. Future > tests will add to the kunit.dtsi file to include their specific test > nodes. > > Cc: Richard Weinb

Re: [PATCH] virt-pci: add platform bus support

2023-03-06 Thread Rob Herring
On Tue, Feb 14, 2023 at 01:12:25PM +0100, Vincent Whitchurch wrote: > On Mon, Feb 13, 2023 at 06:54:49PM +0100, Johannes Berg wrote: > > On Fri, 2023-01-27 at 15:30 +0100, Vincent Whitchurch wrote: > > > My first approach to getting platform drivers working on UML was by > > > adding a minimal PCI-

Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

2023-03-06 Thread Rob Herring
On Sat, Mar 4, 2023 at 9:39 AM Frank Rowand wrote: > > On 3/2/23 17:57, Stephen Boyd wrote: > > Quoting Rob Herring (2023-03-02 12:18:34) > >> On Thu, Mar 2, 2023 at 1:44 PM Stephen Boyd wrote: > >>> > >>> Quoting Rob Herring (2023-03-02 09:13:59

Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

2023-03-02 Thread Rob Herring
On Thu, Mar 2, 2023 at 1:44 PM Stephen Boyd wrote: > > Quoting Rob Herring (2023-03-02 09:13:59) > > On Wed, Mar 1, 2023 at 7:38 PM Stephen Boyd wrote: > > > > > > This patch series adds unit tests for the clk fixed rate basic type and > > > the clk

Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

2023-03-02 Thread Rob Herring
On Thu, Mar 2, 2023 at 2:14 AM David Gow wrote: > > On Thu, 2 Mar 2023 at 09:38, Stephen Boyd wrote: > > > > This patch series adds unit tests for the clk fixed rate basic type and > > the clk registration functions that use struct clk_parent_data. To get > > there, we add support for loading a D

Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data

2023-03-02 Thread Rob Herring
On Wed, Mar 1, 2023 at 7:38 PM Stephen Boyd wrote: > > This patch series adds unit tests for the clk fixed rate basic type and > the clk registration functions that use struct clk_parent_data. To get > there, we add support for loading a DTB into the UML kernel that's > running the unit tests alon

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Rob Herring
On Fri, Jul 22, 2022 at 1:55 PM Arnd Bergmann wrote: > > On Fri, Jul 22, 2022 at 6:36 PM Rob Herring wrote: > > On Fri, Jul 22, 2022 at 9:27 AM Palmer Dabbelt wrote: > > > > From fu740: > >ranges = <0x8100 0x0 0x6008 0x0 > &g

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Rob Herring
On Fri, Jul 22, 2022 at 1:23 PM Maciej W. Rozycki wrote: > > On Fri, 22 Jul 2022, Rob Herring wrote: > > > > Maybe the right thing to do here is actually to make the default > > > definitions of these macros non-zero, or to add some sort of ARCH_ > > > f

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-22 Thread Rob Herring
On Fri, Jul 22, 2022 at 9:27 AM Palmer Dabbelt wrote: > > On Thu, 21 Jul 2022 16:06:52 PDT (-0700), Rob Herring wrote: > > On Tue, Jul 19, 2022 at 9:59 AM Palmer Dabbelt wrote: > >> > >> On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > >&

Re: [PATCH v3 2/2] asm-generic: Add new pci.h and use it

2022-07-21 Thread Rob Herring
On Tue, Jul 19, 2022 at 9:59 AM Palmer Dabbelt wrote: > > On Sun, 17 Jul 2022 17:41:14 PDT (-0700), sho...@gmail.com wrote: > > The asm/pci.h used for many newer architectures share similar > > definitions. Move the common parts to asm-generic/pci.h to allow for > > sharing code. > > > > Two thin

Re: [PATCH v4 01/11] timekeeping: add raw clock fallback for random_get_entropy()

2022-04-14 Thread Rob Herring
On Thu, Apr 14, 2022 at 12:38:49AM +0200, Jason A. Donenfeld wrote: > Hi Rob, > > On Wed, Apr 13, 2022 at 4:32 PM Rob Herring wrote: > > 'does not have a usable get_cycles(), ...' as clearly some arches have > > get_cycles() and yet still need a fallback.

Re: [PATCH v4 03/11] riscv: use fallback for random_get_entropy() instead of zero

2022-04-13 Thread Rob Herring
On Wed, Apr 13, 2022 at 6:56 AM Jason A. Donenfeld wrote: > > In the event that random_get_entropy() can't access a cycle counter or > similar, falling back to returning 0 is really not the best we can do. > Instead, at least calling random_get_entropy_fallback() would be > preferable, because tha

Re: [PATCH v4 01/11] timekeeping: add raw clock fallback for random_get_entropy()

2022-04-13 Thread Rob Herring
On Wed, Apr 13, 2022 at 6:55 AM Jason A. Donenfeld wrote: > > The addition of random_get_entropy_fallback() provides access to > whichever time source has the highest frequency, which is useful for > gathering entropy on platforms without available cycle counters. It's > not necessarily as good as